#pokersource@irc.freenode.net IRC Log for
Monday 1 February 2010

Back to #pokersource@irc.freenode.net Log Calendar

Back to to Sunday 31 January 2010

Poker Free Software http://pokersource.info/ with IRC archives http://pokersource.info/irc/pokersource@irc.freenode.net/"

00:23:24 dachary left #pokersource.
00:24:14 dachary joined #pokersource.
00:27:29 ckudige joined #pokersource.
00:28:08 ckudige: dachary: !
00:28:20 dachary: ckudige: hey
00:28:27 dachary: welcome :-)
00:28:39 ckudige: Thanks !
00:29:07 ckudige: I was just going through the z2 tickets to get started
00:29:27 ckudige: btw is drupal-chandan server ready ?
00:29:29 dachary: Did you get the specs ? Sent a mail.
00:29:55 dachary: ckudige: will be prepared monday afternoon.
00:30:17 dachary: just after the upgrade so that you have a stable state to start with.
00:30:41 ckudige: Yeah I am just going through it right now
00:31:35 ckudige: so what I am planning to do is first understand where the code is setup, how to start it stop it, running the test cases etc. The dig into the z2 tickets in detail.
00:32:19 ckudige: I will also chat with Pierre when he is online and I want to pick one of the tickets that I can try working on my own to make sure I understand everything
00:32:50 ckudige: and take it from there. But for the first week or two both of you will be hearing from me a lot of questions
00:33:16 dachary: /etc/drupal/6/sites/all/modules/os_poker/ is where the code is
00:34:33 ckudige: I am assuming the repository is baselined with the original version of drupal with all poker specific stuff added on top right ? I like to understand that too, so I know whats part of drupal and whats part of pokersource
00:35:48 dachary: ckudige: I would be worried if you had no questions ;-)
00:36:29 ckudige: dachary: so what is your working hours ?
00:36:43 dachary: Pierre made sure all is localized in /etc/drupal/6/sites/all/modules/os_poker/ and the corresponding theme /etc/drupal/6/sites/all/themes/poker/
00:37:13 dachary: the rest is drupal installation but no random hacks
00:37:19 ckudige: great!
00:37:25 dachary: the drupal installation is not trivial though
00:37:45 dachary: and replicating it to your place might be a little difficult, which is why I proposed a clone
00:38:10 dachary: Pierre is working from a mercurial copy of /etc/drupal/6/sites/all
00:38:30 dachary: ckudige: you will be able to hg clone /etc/drupal/6/sites/all to your machine if you like
00:38:53 ckudige: yeah its probably a better idea doing that as I get to learn any other intricacies involved in installation
00:39:34 ckudige: is there an upstream for this repository ? is there a process for push back to the upstream ?
00:40:03 ckudige: (I am assuming this code base is being used for other projects too)
00:40:07 dachary: 404 is the upstream for drupal work
00:40:27 dachary: drupal-kez.pokersource.info is the upstream for poker (jpoker) integration work
00:40:39 dachary: and it gets consolidated every monday morning on drupal-demo
00:40:57 ckudige: okay
00:41:02 dachary: that's what's going to happen tomorrow morning (monday morning, not your tomorrow morning ;-)
00:42:03 ckudige: okay, thats good.
00:42:42 ckudige: so regarding the z2/ tickets - is this specifically for this project ?
00:44:08 ckudige: ^ dachary
00:44:27 dachary: ckudige: yes
00:47:42 dachary: my working hours are 9:30 to midnight. I'll therefore be online when you wake up.
00:52:27 macmaN quit IRC (Read error: Connection reset by peer).
00:57:33 tarbo2 quit IRC (Ping timeout: 258 seconds).
00:59:51 tarbo2 joined #pokersource.
01:36:00 dachary quit IRC (Read error: Operation timed out).
02:35:45 tarbo2 quit IRC (Ping timeout: 246 seconds).
02:40:16 tarbo2 joined #pokersource.
02:40:16 tarbo2 quit IRC (Changing host).
02:40:16 tarbo2 joined #pokersource.
02:50:38 saqimtiaz quit IRC (Quit: Leaving.).
02:57:34 bkuhn quit IRC (Quit: Sleeping.).
03:07:22 macmaN joined #pokersource.
03:14:11 macmaN quit IRC (Read error: Connection reset by peer).
05:17:54 macmaN joined #pokersource.
05:22:31 macmaN quit IRC (Read error: Connection reset by peer).
07:01:26 macmaN joined #pokersource.
07:25:41 tarbo2 quit IRC (Quit: leaving).
07:51:15 tarbo2 joined #pokersource.
08:20:27 brian quit IRC (Ping timeout: 256 seconds).
08:33:50 brian joined #pokersource.
08:33:52 mongolito404 joined #pokersource.
08:33:53 brian quit IRC (Changing host).
08:33:53 brian joined #pokersource.
08:34:20 mongolito404: Hello worlx
08:34:30 mongolito404: s/worlx/world
09:03:21 mongolito404: ckudige: Hi
09:03:46 ckudige: mongolito404: Hi there !
09:04:01 ckudige: Is this Pierre ?
09:04:17 mongolito404: Yep
09:04:30 ckudige: Hey, its nice to meet you!
09:05:01 mongolito404: same here
09:05:45 ckudige: I had a chat with Loic and got a good idea about the ticketing system etc
09:06:06 ckudige: I was looking to get some pointers regarding the code and multiple paths in the code that Loic mentioned about
09:07:06 ckudige: and also want to get the drupal-poker installed and running on my local system. Are there any pre-requisites ? I have a Mac osx laptop
09:08:02 mongolito404: The multiple paths Loic was referring to is is the fac that, as with many lrge and powerfull stuff, there isn't a single solution to implement one feature while working in Drupal. There is always the solution to build everything from scratch, but there is many available third party modules you can build on.
09:08:52 mongolito404: ckudige: Yes there is many requirements
09:10:07 ckudige: mongolito404: I see. I guess its true with most frameworks like symfony or cakephp which has lots of plugins available. Does drupal have a MVC structure ? (model, view, controller)
09:10:19 mongolito404: ckudige: No
09:10:37 mongolito404: Actually Drupal is a fist a (flaxible) CMS system.
09:10:58 mongolito404: And is very procedural. There is almost no OOP in the base APIs
09:11:04 ckudige: I see
09:11:31 ckudige: Even without OOP you can still write very structured code as long as you are careful
09:11:35 mongolito404: The bases are the Hooks system and the FAPI.
09:11:50 mongolito404: FAPI == Forms API
09:12:39 ckudige: okay
09:13:46 ckudige: I will check out the FAPI later
09:14:27 saqimtiaz joined #pokersource.
09:14:35 ckudige: saqimtiaz: !
09:14:46 saqimtiaz: hello
09:14:59 ckudige: mongolito404: so can I install drupal-poker on top of an existing drupal installation? Or does it have to be installed from scratch ?
09:15:23 mongolito404: ckudige: You better starts from scratch.
09:15:31 ckudige: saqimtiaz: No sure if you remember me. But I worked with you last year for a few months, and now I am back :)
09:15:35 mongolito404: There is a (incomplete) documentation at http://drupal.pokersource.info/HOWTO.txt
09:15:41 ckudige: mongolito404: okay
09:16:01 dachary joined #pokersource.
09:16:41 saqimtiaz: ckudige: I remember :) Nice to have you back!
09:16:42 mongolito404: As I said, you will probably be better working on a VM (cloned from an existing one)
09:17:15 ckudige: mongolito404: okay. I was hoping to run it on my local machine for ease of development. But I guess its going to be a tough installation :)
09:17:23 mongolito404: ckudige: Yes
09:17:26 ckudige: saqimtiaz: same here, nice to be back !
09:18:02 dachary: morning
09:18:11 ckudige: dachary: hi!
09:18:11 saqimtiaz: morning sir
09:19:10 dachary: ckudige: could actually run it from your computer easily. It's a 10GB virtual machine and it can boot from virtualbox.
09:20:33 ckudige: dachary: Ah okay, thats not a bad idea
09:20:35 mongolito404: ckudige: On the VM, the code is in a Mercurial repository. Since it is a distributed VCS, we can work in our VM then sync. back with each others periodically/when needed (at least on each Monday).
09:20:42 dachary: with a fast network cnx to the hosted virtual machine it's no trouble for me to work on it accross the network instead of running it locally. But if you have a slower round trip time, it may be better for you.
09:21:36 ckudige: yeah connection is always an issue out here :)
09:21:51 ckudige: where can I download the image from ?
09:22:06 mongolito404: I'm working locally but I have to push my changes to the server (using rsync over SSH to run it).
09:23:19 ckudige: mongolito404: do you mean you edit locally but run it by pushing to the server ?
09:23:33 mongolito404: ckudige: Yes
09:24:30 mongolito404: using rsync
09:24:48 mongolito404: Which only upload the changed files
09:24:50 ckudige: yeah thats a bit of a pain for me .. as my connection keeps playing up
09:25:06 ckudige: for the most part it would work, but sometimes the connection is slow
09:25:36 mongolito404: As dachary said, you can run the VM locally
09:25:48 ckudige: Yeah I will probably do that way
09:26:45 ckudige: arghh .. did he say 10GB virtual machine :) That would take me forever !
09:26:47 dachary: Sp4rKy: did you start preparing drupal-chandan yet ?
09:26:53 Sp4rKy: yep
09:26:58 Sp4rKy: creating the vm
09:27:35 dachary: Sp4rKy: can you set a gzipped copy of the volume for ckudige to download while you're at it ?
09:28:00 Sp4rKy: yep
09:28:03 Sp4rKy: after the sync I guess ?
09:28:11 dachary: Sp4rKy: yes :-)
09:28:33 dachary: ckudige: I bet it will be over the next morning ;-)
09:28:45 dachary: Sp4rKy: thanks
09:29:19 ckudige: dachary: 10 GB is a huge download ... I am not sure how long it will take me to download ! For now I will stick with drupal-chandan :)
09:29:48 mongolito404: ckudige: If you haven't done it already, http://drupal.org/node/206753 is a good start to see how things work in the Drupal work.
09:30:22 ckudige: mongolito404: thanks
09:30:22 dachary: how fast is your link from us to you ?
09:31:06 mongolito404: s/Drupal work/Drupal world
09:31:23 ckudige: dachary: my fast link has a 50GB limit monthly .which I am mostly over. So I need to use a dialup connectiont o download which would take me forever
09:31:57 dachary: ckudige: Oo.
09:32:28 ckudige: dachary: So I guess I will forget having a local VM :(
09:32:30 dachary: 50GB is not much indeed : I understand why 10GB is a big deal :-)
09:32:50 ckudige: yeah ... out here in Australia I had to kick and scream just to get 50GB limit!
09:33:08 dachary: I'll have it mailed for you :-D
09:33:14 mongolito404: ckudige: 15-20Gb/month are common in Belgium
09:33:27 ckudige: dachary: haha
09:33:46 dachary: mongolito404: 15-20Gb limit on the cnx ? Oo
09:34:14 mongolito404: That Belgium, we did get ride of our old state owned telco.
09:34:48 dachary: mongolito404: but now you have unlimited internet access, right ?
09:34:49 ckudige: we are still trying to do that here ... its still a monopoly out here
09:35:21 mongolito404: dachary: I'm one of the happy few with an unlimited connexion
09:35:33 ckudige: whats more frustrating is that the connection speed is very fast (10 Mbps) but latency is bad
09:35:41 dachary: mongolito404: you're kidding me.
09:35:55 mongolito404: dachary: No I'm not...
09:36:09 dachary: mongolito404: it's why you want to move abroad ? :-)
09:36:32 mongolito404: No, telco. in North America are not very good neither
09:36:52 ckudige: mongolito404: Out in USA most of my friends have high speed with no download limits
09:37:12 ckudige: even when I lived there few years back it was pretty fast
09:37:51 mongolito404: Agree, the situation is probably a little bit better than here... but at least Belgacom is not lobbying against Net Neutrality
09:38:09 mongolito404: And you can get decent speed even in "rural" area
09:38:23 dachary forgot what it's like to have network limits... dark ages :-(
09:38:51 saqimtiaz: I'd probably blow the 20gb limit in a week...
09:39:11 mongolito404: saqimtiaz: What for ?
09:39:37 dachary: if for nothing else just by sharing music and films with friends :-D
09:39:42 saqimtiaz: my default behaviour isn't to see if I already have something, its to download it :D
09:39:58 dachary: for me backups will come second
09:41:06 dachary: pokersource has ~6TB backups sitting behind a regular internet individual access
09:41:34 mongolito404: Sharing with friends, you mean like buccaneer with eyes patch and parrot... Bad boys. HADOPI will kick your ass... or not.
09:43:29 dachary: mongolito404: :-) I can't wait for them to nail me. That would be their biggest mistake in years.
09:43:52 saqimtiaz: oh boy, dachary would enjoy that
09:44:06 mongolito404: ckudige: Have you any experience with (distributed) VCS ? We use Mercurial.
09:44:51 mongolito404: dachary: Now that the whole world laugh at France fiasco with HADOPI, we have some smart-ass senatros that want one for Belgium...
09:45:22 ckudige: mongolito404: Yeah I have used mercurial before but probably not to the extent you do here. But I am familiar with the clone/push/pull concepts
09:46:37 mongolito404: ckudige: I'm using Mercurial for a month and half... before that I used Bazaar a bit and was mostly used to SVN (and I try to forget having worked with CVS).
09:47:17 ckudige: mongolito404: Yeah I have been using SVN for a very long time. And believe it or not, I used CVS, and RCS and even SCCS before that. Took me a long time to forget it all :)
09:49:50 ckudige: dachary: I was going through the spec you sent me. It has references to a lot of pictures. Where can I get them from ?
09:56:44 j1b joined #pokersource.
10:40:18 mongolito404: Sp4rKy, dachary: What the external SSH port for drupal-kez ?
10:41:06 dachary: not sure there already is one : proppy goes thru the VPN
10:41:29 Sp4rKy: mongolito404: 22074
10:41:34 dachary: :-)
10:41:41 Sp4rKy: :)
10:54:06 mongolito404: proppy is still not ready but I started to sync. code on drupal-demo
10:54:36 mongolito404: I started by pulling changes in the /usr/src/pb_jpoker from his VM to mine. I had to merge some changes made on drupal-demo to it. The I pushed all the changes to drupal-demo.
10:55:10 dachary: mongolito404: ok
10:55:20 mongolito404: I also pushed changes in /root/drupal from drupal-404 to drupal-demo. Proppry did make any changes there on his VM.
10:56:18 mongolito404: I also used "chown -R root:www-data . && chmod -R g+rwX ." to ensure writability to Shindig configuration file by ShindigIntegrator.
10:57:03 mongolito404: Then I cleared the drupal cache. And finally ran one of the test for ShindigIntegrator to force it to re-write the Shindig configuration file.
10:57:28 proppy joined #pokersource.
10:57:37 proppy: Sorry for being late
10:57:44 ckudige: mongolito404: what is under /root/drupal ?
10:57:48 ckudige: proppy: hi !
10:57:55 proppy: ckudige: Hi !
10:58:08 proppy: I'm sick, I'll see the doctor tomorrow morning
10:58:30 mongolito404: ckudige: Most of the third party code for Drupal, incl. our module and themes.
10:59:05 ckudige: mongolito404: is this different from /etc/drupal/6/sites/all/modules/os_poker/ ?
10:59:22 Sp4rKy: mongolito404: proppy dachary can I stop mysql on drupal-404 a few minutes to snap it ?
10:59:34 mongolito404: Sp4rKy: Yes
10:59:53 mongolito404: /root/drupal is a symlink to /etc/drupal/6/sites/all/
11:00:12 ckudige: mongolito404: ah then it makes sense !
11:02:17 ckudige: mongolito404: what does Shindig do ?
11:03:04 mongolito404: Shindig is a Open Social container
11:03:27 mongolito404: ShindigIntegrator integrates it with Drupal, so that Drupal can be used as an OpenSocial container.
11:03:50 ckudige: ah okay
11:04:07 proppy: mongolito404: Sp4rKy: can I push finished ticket changeset on drupal-demo
11:04:08 mongolito404: We use it to embed jpoker (a JavaScript client for poker-network if I'm not mistaken)
11:04:50 ckudige: okay
11:04:59 mongolito404: proppy: I pulled changes in the /usr/src/pb_jpoker from your VM to mine. I had to merge some changes made on drupal-demo to it. The I pushed all the changes to drupal-demo.
11:05:49 proppy: mongolito404: were there any outgoing changeset, in root/drupal ?
11:05:54 proppy: (I don't believe so)
11:06:02 mongolito404: ckudige: jpoker itself is no an OpenSocial application and here is some additional code to make it behave has one.
11:06:06 mongolito404: proppy: Not on drupal-kez
11:06:13 proppy: mongolito404: ok
11:06:27 proppy: mongolito404: so I will check the finished ticket one by one then
11:06:31 proppy: and mark them in production
11:07:09 mongolito404: Ok
11:07:35 mongolito404: You still have to push update for anything not in /usr/src/pb_jpoker or root/drupal (like updating package)
11:08:09 mongolito404: And I'll need instruction of what needs to be done on drupal-404 too (or should I pull changes from drupal-demo / once it is ready ?)
11:09:19 mongolito404: proppy: We have un unresolved issue at http://drupal-dev.pokersource.info/z2/ticket/21#comment:9
11:09:54 proppy: http://drupal-dev.pokersource.info/z2/ticket/3#comment:20 -> checked and marked as production
11:11:15 proppy: mongolito404: did you apply http://drupal.org/files/issues/shindig_integrator_appservice_use_appid.patch on shindig integrator ?
11:12:36 proppy: mongolito404: i have the following error on drupal-demo
11:12:37 proppy: Permission denied for to get property Window.document from . var game_id = $.query.load(top.document.location + '').get('game_id');
11:12:53 proppy: I believe something in os_poker, or pb_poker still point to drupal-404
11:13:18 mongolito404: Still now ?
11:13:22 proppy: mongolito404: the gadget url is http://drupal-404.pokersource.info/drupal6/sites/all/modules/shindig_integrator/shindig/php/gadgets/ifr?synd=default&container=default&viewer=346&owner=346&aid=MTY=&mid=b3NfcG9rZXI=&nocache=1&country=US&lang=EN&view=canvas&parent=http%3A%2F%2Fdrupal-demo.pokersource.info&up_os_poker_skin=http%3A%2F%2Fdrupal-demo.pokersource.info%2Fdrupal6%2F%3Fq%3Dpoker%2Fskin.css&up_money=%7B%221%22%3A+199500%7D&up_reward1=1265018
11:13:31 proppy: mongolito404: let me reload
11:13:47 proppy: mongolito404: now it is working
11:13:52 proppy: mongolito404: did you change anything ?
11:14:11 mongolito404: Yes, I ran the ShindigIntegrator test to force a config refresh
11:14:32 mongolito404: I forgot to "hg update" in /root/drupal the first time
11:14:40 proppy: mongolito404: just after I reported 'Permission denied' ?
11:14:51 mongolito404: proppy: Yes
11:14:54 proppy: mongolito404: ok :)
11:15:14 proppy: so I believe http://drupal.org/files/issues/shindig_integrator_appservice_use_appid.patch is applied
11:15:19 mongolito404: Yes it is
11:15:56 proppy: http://drupal-dev.pokersource.info/z2/ticket/22#comment:9 -> check and marked as production
11:17:06 proppy: mongolito404: do you know if there is a way to query finished ticket not in production ?
11:17:24 proppy: ah I can query "finished" Resolution
11:17:26 proppy: not status :)
11:17:30 mongolito404: http://drupal-dev.pokersource.info/z2/query?status=assigned&status=ready&group=status&component=Drupal&component=Integration&order=priority&col=id&col=summary&col=type&col=priority&col=milestone
11:17:33 proppy: http://drupal-dev.pokersource.info/z2/query?order=priority&resolution=finished&col=id&col=summary&col=type&col=component
11:17:56 mongolito404: http://drupal-dev.pokersource.info/z2/query?status=assigned&status=ready&group=component&col=id&col=summary&col=type&col=priority&col=milestone&order=priority
11:18:23 proppy: mongolito404: what is status "ready" ?
11:18:32 mongolito404: ready == to be put in production
11:18:42 mongolito404: production == deplayed on drupal-demo
11:18:49 proppy: oh ok
11:18:54 mongolito404: and once it is properly tested i can be closed
11:18:55 proppy: I still marked mine as "finished" (not ready)
11:19:04 proppy: so I'll have to reopen them
11:19:14 proppy: mongolito404: I will use 'ready' flag for the next milestone
11:19:15 mongolito404: Yes
11:19:22 proppy: and no more 'finished'
11:20:46 proppy: http://drupal-dev.pokersource.info/z2/ticket/57#comment:8 -> checked and marked as production
11:21:00 proppy: I'm done with last week z2 tickets
11:21:12 proppy: checking /trac/ tickets now
11:22:16 mongolito404: When the test to validate a fix is trivial, we can close the ticket. For production can be used for cases when the dev. think the ticket is fixed but when the client (or dachary's ) may disagree or want to validate it himself.
11:22:59 ckudige: okay
11:23:25 proppy: http://drupal-dev.pokersource.info/trac/login root login changed ?
11:23:49 mongolito404: proppy: Don't known I'm using my own login
11:24:18 proppy: no tickets on /trac/
11:24:31 proppy: mongolito404: it seams that /trac/ doesn't have the 'finished' status
11:24:36 proppy: I mean resolution
11:25:17 proppy: all the /trac/ tickets have been marked in production last week
11:25:27 proppy: in component 'Poker'
11:25:59 proppy: mongolito404: so http://drupal-dev.pokersource.info/z2/ticket/21 is the only pb with today merge ?
11:26:36 mongolito404: Until now yes
11:28:59 proppy: mongolito404: the following patch should do the trick on drupal-demo
11:28:59 proppy: http://pastebin.com/f745f4cb3
11:31:37 proppy: dachary: about http://drupal-dev.pokersource.info/z2/ticket/18, we are waiting for commanditor input, should we update drupal-demo with the new table lit even if all the table could not have been created (because of missing limit),
11:31:56 proppy: mongolito404: oups sorry bad patch
11:32:08 proppy: mongolito404: http://pastebin.com/f85861e2 better patch
11:32:24 dachary: proppy: you can update drupal-demo with what you've done and leave the rest out.
11:32:45 proppy: dachary: I forgot the ticket because it was not marked as 'finished'
11:34:11 proppy: dachary: what about http://drupal-dev.pokersource.info/z2/ticket/24
11:34:36 dachary: update with what you've done : it's better than nothing
11:34:39 proppy: 'Hands played' is working, but not 'Biggest Pot Won', 'Best hand', and 'Hands won'
11:34:47 dachary: understood
11:35:01 proppy: shoudl we update poker social, even thought the ticket is not finished ?
11:35:23 dachary: proppy: I think you can. Do you see a reason not to ?
11:35:52 proppy: dachary: I guess that code has not be pulled on opensocial.dachary yet,
11:35:58 proppy: and that packet needs to be regenerated
11:36:16 proppy: these include fixed for https://gna.org/bugs/?15202 too
11:36:45 proppy: dachary: I would feel more confident if you review that code, and do the pull, rather putting them myself in production
11:37:04 dachary: proppy: where is the code ?
11:37:06 proppy: dachary: so maybe we should wait for http://drupal-dev.pokersource.info/z2/ticket/24 to be completed, and properly merged
11:37:17 dachary: I can do it right now
11:37:35 proppy: https://gna.org/bugs/?15202#comment2
11:37:52 proppy: "" Feel free to hg pull http://drupal-kez.pokersource.info/pokersocial/ """
11:38:10 proppy: there is also fixes for http://drupal-dev.pokersource.info/z2/ticket/24
11:39:06 proppy: but only for 'hands played'
11:39:21 proppy: mongolito404: I'll apply http://pastebin.com/f85861e2 after the package has been updated
11:40:06 proppy: oh wait, I'll apply it now on drupal-kez to test, and apply it again on drupal-demo after the package has been updated
11:40:11 dachary: hg incoming http://drupal-kez.pokersource.info/pokersocial/
11:40:11 dachary: comparing with http://drupal-kez.pokersource.info/pokersocial/
11:40:11 dachary: abort: 'http://drupal-kez.pokersource.info/pokersocial/' does not appear to be an hg repository!
11:40:54 proppy: dachary:
11:40:55 proppy: proppy@pasokon:/tmp$ hg clone http://drupal-kez.pokersource.info/pokersocial/
11:40:55 proppy: destination directory: pokersocial
11:40:55 proppy: requesting all changes
11:40:55 proppy: adding changesets
11:40:55 proppy: adding manifests
11:40:56 proppy: adding file changes
11:40:59 dachary: hg incoming static-http://drupal-kez.pokersource.info/pokersocial/
11:40:59 dachary: abort: requirement 'fncache' not supported!
11:41:16 proppy: dachary: which version of mercurial are you using ?
11:41:33 dachary: upgrading mercurial
11:43:16 proppy: mongolito404: I have errors after merging your change in /root/drupal
11:43:30 proppy: pulling agin
11:43:33 mongolito404: On ur VM ?
11:44:18 proppy: yes
11:45:01 mongolito404: what error, in the gadget ?
11:45:02 proppy: mongolito404: should I run shindig integrator test ?
11:45:30 proppy: mongolito404: error 500 when making request to the server
11:45:30 proppy: exceptions.ValueError: No JSON object could be decoded
11:45:32 mongolito404: Yoiu have to ensure that the webserver has write access to the shindi config file that ShindigIntegrator will rite when running the test
11:45:35 mongolito404: Then yes, run the test
11:46:03 mongolito404: The test atually run the install procedure for SI. This procedure write the Shindig config file.
11:46:21 proppy: ok
11:47:18 mongolito404: This is ugly, in a perfect world with plenty of free time I should report this as a bug to SI with a patch that provide Shindig config dynamically from Drupal instead of generating.
11:47:44 proppy: mongolito404: I have the following error http://drupal-kez.pokersource.info/shindig_error.html
11:47:47 mongolito404: The worse part is copying ShindigIntegrator* classes from shindig_files to shindig/php/src/sample
11:47:52 proppy: when making a shindig request from the poker server
11:48:14 proppy: so I guess I should install imagecache :)
11:48:27 proppy: mongolito404: about config.php I thought we could put a relative patch
11:48:28 proppy: path
11:48:35 proppy: instead of an absolute one
11:48:36 mongolito404: proppy: Enable the image cache module in adminbuild//module, you will need to update Image API, Tansliteration and Image API Gd
11:48:37 proppy: for gadget server
11:48:40 proppy: what do you think ?
11:48:54 proppy: mongolito404: since shindigintegrator is in /root/drupal mercurial repository now
11:49:02 proppy: we should have the same configuration everywhere
11:49:12 mongolito404: config.php ?
11:49:37 proppy: mongolito404: drupal-kez:~/drupal# hg diff .
11:49:37 proppy: diff -r ae99bc62f2a4 modules/shindig_integrator/shindig/php/config/local.php
11:49:37 proppy: --- a/modules/shindig_integrator/shindig/php/config/local.php Mon Feb 01 10:38:12 2010 +0100
11:49:37 proppy: +++ b/modules/shindig_integrator/shindig/php/config/local.php Mon Feb 01 11:49:25 2010 +0100
11:49:38 proppy: @@ -6,7 +6,7 @@
11:49:38 proppy: class ShindigConfigException extends Exception {}
11:49:38 proppy: $shindigConfig = array(
11:49:38 proppy: - "gadget_server" => "http://drupal-404.pokersource.info/drupal6/sites/all/modules/shindig_integrator/shindig/php",
11:49:38 proppy: + "gadget_server" => "/drupal6/sites/all/modules/shindig_integrator/shindig/php",
11:49:39 proppy: "web_prefix" => "/drupal6/sites/all/modules/shindig_integrator/shindig/php",
11:49:39 proppy: "default_js_prefix" => "/drupal6/sites/all/modules/shindig_integrator/shindig/php/gadgets/js/",
11:49:40 proppy: "default_iframe_prefix" => "sites/all/modules/shindig_integrator/shindig/php/gadgets/ifr?",
11:49:50 mongolito404: This file is gnerated by ShindigIntegrator
11:50:13 proppy: yes, but it it still commited to the vcs :)
11:50:24 mongolito404: Yes because I didn't exclude it
11:50:38 dachary done upgrading to poker-network-2.0 (from farm)
11:50:47 mongolito404: Since the file is generated we should exclude it.
11:51:18 proppy: enabled ImageAPI, ImageAPI GD2, ImageCached
11:51:20 proppy: -d
11:51:34 proppy: and Transliteration
11:53:21 proppy: mongolito404: is /root/drupal/modules/shindig_integrator/shindig/php/config/local.php the file I should provide the webserver write access to ?
11:53:46 mongolito404: Yes and anything in /root/drupal/modules/shindig_integrator/shindig/php/src/sample
11:54:16 mongolito404: Any failure to write these file will be reported when running any test using SindigIntegrator
11:54:26 proppy: social/sample
11:55:19 mongolito404: yes
11:57:26 proppy: (Note deleteApp data still use appId from token)
12:00:39 mongolito404: proppy Not on drupal-demo
12:00:51 dachary: proppy: tests run ok, coverage same as yours, generating packages
12:02:17 mongolito404: Ok, all Drupal/Integration fixes are on drupal-demo and seems to work.
12:02:44 dachary: proppy: http://opensocial.pokersource.info/ repository upgraded with your latest patches ( package 1.0.2 ).
12:03:15 proppy: dachary: thanks
12:03:31 proppy: dachary: still checking buy in notification is fixed by http://pastebin.com/f85861e2
12:03:32 mongolito404: Fixed a small bug for the "Invite Now" link in the buddy list on drupal-demo
12:03:39 mongolito404: The change is commited here and need to be pulled
12:03:44 proppy: since it seems to be the only blocked we have on drupal-demo
12:04:18 proppy: dachary: I'm worried that https://gna.org/bugs/?15207 may be mandatory for http://drupal-dev.pokersource.info/z2/ticket/21 to be fixed
12:05:40 proppy: mongolito404: about #21
12:05:46 proppy: I'm positive that 2010-02-01 12:04:51+0100 [HTTPPageGetter,client] Stopping factory http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[1,943,300000]>
12:05:49 proppy: has been sent
12:05:59 proppy: after applying http://pastebin.com/f85861e2 and restarting the server
12:06:09 proppy: but the amount of chips is still not updated
12:06:40 proppy: how do I check that the corresponding code has been called ?
12:07:31 mongolito404: Can you check the response the server gave you for the call to http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[1,943,300000]
12:07:42 proppy: mongolito404: if I reload the page the amount is updated
12:07:59 dachary: proppy: I think you are correct and I wrote it down at http://drupal-dev.pokersource.info/z2/ticket/21#comment:10
12:08:38 dachary: proppy: thanks for pointing this
12:09:44 mongolito404: proppy: I'm lost, are you doing your test with a fix for https://gna.org/bugs/?15207 applied ?
12:10:02 mongolito404: And what user are you using. From http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[1,943,300000] I assume your are logged as root ?
12:11:01 proppy: dachary: no I'm doing a test with http://pastebin.com/f85861e2 applied, which is a fix in poker.social.xml configuration, in answer to mongolito404 comment http://drupal-dev.pokersource.info/z2/ticket/21#comment:9
12:11:19 proppy: mongolito404: yes
12:11:20 dachary: mongolito404: proppy https://gna.org/bugs/?15207 can be left for later. It's a race condition and if we're lucky it will not show. If we experience erratic behavior in this area, we know where to look for. There is no need to try to fix or reproduce a possible erratic behavior at this point.
12:11:48 proppy: mongolito404: I don't have direct access to the response from http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[1,943,300000] http call
12:11:58 proppy: mongolito404: can I patch pokersocial to add debug statements
12:12:13 dachary: proppy: http://pastebin.com/f85861e2 ok
12:12:31 mongolito404: Well, if you call http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[1,943,300000] before the update to user money is written to the database, the displayed amount will not get updated right.
12:16:38 mongolito404: proppy: You can test the callback URL manually using any CLI http client
12:16:41 mongolito404: such as wget
12:16:58 mongolito404: On drupal demo => wget "http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[302,555,300000]" -o out.txt
12:17:08 proppy: ok
12:17:08 mongolito404: The output should be {"errorMsg":null,"error":false,"messages":[{"type":"debug","body":"Recevied BUY_IN for user 302"}]}
12:17:16 mongolito404: I just tested it and it works
12:17:48 mongolito404: On the browser, with Firebug, I can confirm that just after calling it, I get a response to the poker/messags/send request
12:18:02 mongolito404: The response include the event to trigger a refresh for the chips amount
12:18:04 proppy: ok
12:18:16 proppy: mongolito404: I updated pokersocial to print the output
12:18:24 mongolito404: From the URL "http://localhost/drupal6/?q=poker/messages/send/&type=BUY_IN&args=[302,555,300000]", only the first value in args (302) is actually used
12:18:33 proppy: locally
12:19:53 proppy: mongolito404: 2010-02-01 12:19:31+0100 [HTTPPageGetter,client] notify: {"errorMsg":null,"error":false,"messages":[{"type":"debug","body":"Recevied BUY_IN for user 1"}]}
12:20:45 mongolito404: Now, are you user with UID 1 (that would be root on drupal-demo) ?
12:21:23 proppy: mongolito404: I'm testing on drupal-kez
12:21:26 proppy: mongolito404: yes
12:21:34 proppy: I'm user root
12:22:08 proppy: mongolito404: in firebug I have a call to http://drupal-kez.pokersource.info/drupal6/?q=poker/messages/receive&_=1265023207566&ajax=1 which have failled
12:22:14 proppy: with empty response header, and response
12:22:18 mongolito404: You can check with firebug, but you should have received an os_poker_update_chips event
12:22:39 ckudige: mongolito404: bbs
12:23:20 dachary: bbl lunch
12:23:23 proppy: mongolito404: which http response body trigger the os_poker-update_chips_event ?
12:23:23 mongolito404: proppy: The request ends with no response ?
12:23:26 proppy: mongolito404: yes
12:23:31 proppy: no response header, no response
12:23:53 mongolito404: And the resuested ended, it is not still waiting for a response ?
12:24:04 proppy: yes
12:24:09 mongolito404: weird
12:24:09 proppy: trying again
12:24:46 proppy: mongolito404: how now the response is still waiting
12:24:54 proppy: mongolito404: and I'm already seated
12:25:31 proppy: mongolito404: so to me it seems the javascript part is not called
12:25:43 proppy: mongolito404: ah the call ended with CacheHTML{"errorMsg":null,"error":false,"messages":[{"type":"noop","body":null}]}
12:26:52 mongolito404: In os_poker_messages.php, a CUpdateUserChipsCount is enqued when receiving a BUY_IN event. The os_poker_update_chips is added to the message queu when running the run method of the CUpdateUserChipsCount. Which is executed from os_poker_poll_messages when calling CScheduler::instance()->Trigger("live")
12:27:03 mongolito404: The messages are then collected and outputed in JSON
12:27:26 mongolito404: {"errorMsg":null,"error":false,"messages":[{"type":"noop","body":null}]} means the long poll ended without any messages
12:27:41 mongolito404: The BUY_IN is not called if you are already seated
12:29:04 Sp4rKy: dachary: drupal-chandan is available on z2-81.pokersource.info, port 22103
12:29:05 proppy: mongolito404: sorry I was not already seated,
12:29:11 proppy: I clicked on click to sit
12:30:27 proppy: mongolito404: I'm trying on http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=978
12:31:40 proppy: http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=958
12:33:08 mongolito404: Site off-line on drupal-kez
12:34:02 mongolito404: Ok, I just sit at a tble on drupal-kez and received the os_poker_update_chips event
12:34:10 proppy: mongolito404: it is back http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=959
12:34:40 proppy: mongolito404: and the chip amount was updated ?
12:35:13 proppy: maybe I should try with another user than root
12:36:49 mongolito404: user warning: MySQL server has gone away query
12:36:49 proppy: site offline on drupal-kez :(
12:37:33 proppy: [2836309.634005] Out of memory: kill process 19388 (mysqld) score 19917 or a child
12:37:48 mongolito404: lunch time. i don't mind to eat at the computer to help but I've to go out to fetch some food...
12:37:55 mongolito404: bbs
12:38:35 proppy: mongolito404: ahah
12:38:38 proppy: I received {"errorMsg":null,"error":false,"messages":[{"type":"os_poker_update_chips","body":{"amount":"1500"}} events
12:38:40 proppy: put
12:38:52 proppy: mongolito404: now that I seated, I received amount = 150
12:38:54 proppy: 1500
12:38:56 proppy: instead of 500
12:39:50 proppy: checking poker logs
12:40:23 proppy: oh ok
12:40:25 proppy: money was 2000
12:40:28 proppy: not it is 500
12:43:15 proppy: I tried again and it was not updated
12:43:28 proppy: maybe it is because of the race condition we mentionned earlier
12:43:56 proppy: and buy in handler is not sending the message
12:43:59 mongolito404: Yes, the amount in the os_poker_update_chips is fetched from the DB when the message is generated
12:44:06 proppy: if if the amount of money doesn't change
12:44:32 proppy: mongolito404: does it send the message even if the amount has not changed ?
12:44:40 mongolito404: proppy: Yes it should
12:44:44 mongolito404: There is no check
12:45:00 proppy: wierd
12:45:16 proppy: so I should always receive the event
12:45:30 proppy: and if the amount is bad, it would show there is a race condition
12:45:59 mongolito404: yes
12:46:21 proppy: tried on http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=979
12:46:25 proppy: and no message received yet
12:46:46 proppy: 2010-02-01 12:46:00+0100 [HTTPPageGetter,client] notify: {"errorMsg":null,"error":false,"messages":[{"type":"debug","body":"Recevied BUY_IN for user 278"}]}
12:47:00 proppy: mongolito404: is there a way to check the db for "messages"
12:47:05 mongolito404: Yes
12:47:30 mongolito404: The messages are in poker_scheduler
12:48:39 mongolito404: SELECT * from poker_scheduler WHERE uid = xxx AND trigger like '%live%'
12:50:56 proppy: only one live event | 2862 | 278 | CDailyChips | ["login","live"] | 2010-02-02 12:35:44 | NULL \
12:51:09 proppy: mysql> SELECT * from poker_scheduler WHERE uid = 278 AND trigger like '%live%';
12:51:10 proppy: ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'trigger like '%live%'\
12:51:10 proppy: ' at line 1
12:52:07 proppy: what an awful name 'trigger', for a database field;
12:52:53 AndChat- joined #pokersource.
12:53:26 AndChat- is now known as mongolito404_And.
12:53:56 mongolito404_And looking for fois...
12:54:19 mongolito404_And: s/fois/food
12:55:07 proppy: ok :)
12:55:21 proppy: maybe canAddTask is returning FALSE
12:56:33 AndChat- joined #pokersource.
12:57:18 AndChat-: It will if there is already an enqued upd chips event
12:58:56 mongolito404_And quit IRC (Ping timeout: 248 seconds).
12:59:01 AndChat- is now known as mongolito404_dro.
13:00:50 proppy: added some debug into os_poker_message
13:02:44 proppy: $resp["messages"][] = array("type" => "debug", "body" => t('Recevied BUY_IN for user !uid, scheduled task !tid', array('!uid' => $uid, '!tid' => $tid)));
13:03:17 emilie joined #pokersource.
13:03:40 proppy: 2010-02-01 13:03:10+0100 [HTTPPageGetter,client] notify: {"errorMsg":null,"error":false,"messages":[{"type":"debug","body":"Recevied BUY_IN for user 278, scheduled task 2870"}]\
13:06:13 mornifle joined #pokersource.
13:06:27 proppy: ^Gmysql> select * from poker_scheduler where id_task = 2870;
13:06:27 proppy: Empty set (0.00 sec)
13:07:17 proppy sad that the task is deleted from db
13:09:10 mongolito404_dro: The task is deleted when live id triggered
13:09:36 mongolito404_dro: s/id/is
13:15:13 proppy: commenting the destroy task
13:15:19 proppy: to check that the task is still in db
13:16:20 proppy: mysql> select * from poker_scheduler where id_task = 2871;
13:16:20 proppy: +---------+-----+-----------------------+----------+---------------------+-----------+---------+---------------------+
13:16:21 proppy: | id_task | uid | type | trigger | moment | arguments | visible | timestamp |
13:16:21 proppy: +---------+-----+-----------------------+----------+---------------------+-----------+---------+---------------------+
13:16:21 proppy: | 2871 | 278 | CUpdateUserChipsCount | ["live"] | 2010-01-31 13:15:45 | NULL | 0 | 2010-02-01 13:15:45 |
13:16:21 proppy: +---------+-----+-----------------------+----------+---------------------+-----------+---------+---------------------+
13:18:58 proppy: mongolito404_dro: I don't undestand how it could work
13:19:05 proppy: the messages spool doesn't seem persistant
13:19:12 proppy: it is only kept in memory
13:19:41 mornifle: dachary: ping
13:19:57 AndChat- joined #pokersource.
13:21:04 proppy: AndChat-: I got it
13:21:06 mongolito404: proppy: The spool is in memory and filled when running the 'live' task
13:21:14 proppy: mongolito404: the long poll is to blame
13:21:20 mongolito404: s/task/tasks
13:21:40 proppy: there is a sleep(60) in long poll calls
13:21:54 proppy: which means there can be a 60 secondes delay before the chips are updated
13:21:55 proppy: for example
13:21:58 mongolito404: The live task CUpdateUserChipsCount adds an os_poker_update_chips message to the spool
13:22:13 proppy: browser call message/_received and there is no task
13:22:19 proppy: sleep(60)
13:22:24 mongolito404_dro quit IRC (Ping timeout: 248 seconds).
13:22:26 proppy: server notify buy in
13:22:32 proppy: drupal schedule the task
13:22:46 mongolito404: If you have two window opened with the Drupal site, only one of the frame receive the message
13:22:48 proppy: (still sleeping)
13:22:54 proppy: (still sleeping)
13:23:26 proppy: browser call message/_received returns empty result (because there were no task/message, before going to sleep)
13:23:37 proppy: browser made a new call to message/_receive
13:23:48 proppy: there is a scheduled task
13:23:53 proppy: task execution push a message
13:24:02 proppy: browser returns this message
13:24:09 proppy: mongolito404: does it makes senses ?
13:24:37 proppy: mongolito404: which means at worst there could be a 60 delay between CUpdateUserChipsCount scheduling, and the handling by the javascript side
13:25:30 mongolito404: sleep(60) is only when not ($current_user && $current_user->uid != 0) == there is no currently logged in user
13:25:55 mongolito404: Otherwise, sleep(3) is used in a 20-passes loop
13:26:13 mongolito404: So the max delay should be 3secs.
13:26:18 proppy: mongolito404: ah you're right
13:26:32 proppy: mongolito404: FYI
13:26:39 proppy: when I removed the DestroyTask call
13:26:45 proppy: I successfully got the message
13:26:51 proppy: on every poll
13:27:46 mongolito404: You mean that sometime to the message is fetched and removed from the DB but you don't see it in firebug ?
13:28:11 proppy: mongolito404: yes
13:28:16 proppy: "sometimes"
13:28:57 mongolito404: So #21 does work but we have a bug in the browser-server messaging system ?
13:28:57 proppy: could it be possible that the task is executed by somewhere else in the code ?
13:29:04 proppy: mongolito404: yes,
13:29:08 proppy: I would say that
13:29:38 mongolito404: proppy: I shouldn't. But who knows. Even after all this time, I'm still surprised by the code and what I found in it
13:29:38 proppy: if I comment //$this->DestroyTask($toDetroy); scheduler.class.php:285
13:29:44 proppy: I always get the messages
13:30:46 mongolito404: And this is the message added by BUY_IN handler, not added before by any other event that update the chips count ?
13:31:57 mongolito404: There is only two call to CScheduler::DestroyTask, one is in CScheduler::Trigger and the other in CScheduler::TriggerHelper. Tha later is only used in test cases.
13:32:18 proppy: mongolito404: ah maybe this is an old one
13:32:46 proppy: mongolito404: also I think the drupal part will not schedule CUpdateUserChipsCount twice
13:32:53 proppy: because there is a limit of 1
13:33:09 mongolito404: Yes it will not trigger it twice
13:33:19 proppy: schedule twice
13:33:27 mongolito404: yes
13:34:17 mongolito404: If you add to add more than one, CScheduler::CanAddTask will returns false and the task will not be scheduled.
13:36:03 proppy: mongolito404: I'm confused
13:36:18 proppy: I'm not sure how to debug things further
13:42:24 AndChat- quit IRC (Quit: Bye).
13:42:57 mongolito404: I don't know neither
13:45:51 mongolito404: I could write a test to check that poker/messages/send does enqueue the CUpdateUserChipsCount task
13:46:15 mongolito404: Did you try calling it by hand using wget in CLI ?
13:46:47 mongolito404: This is easier to check if all the Drupal-side works because you easily control the request to poker/messages/send.
13:47:25 mongolito404: You can even use it when the user is not logged in with Drupal.
13:47:36 proppy: added some debugs to scheduler
13:47:37 proppy: scheduledCUpdateUserChipsCount: [{"file":"\/etc\/dr\
13:47:37 proppy: upal\/6\/sites\/all\/modules\/os_poker\/os_poker_messages.php","line":67,"function":"Trigger","class":"CScheduler","object":{},"type":"->","args":["live"]},{"function":"os_poke\
13:47:37 proppy: r_poll_messages","args":[]},{"file":"\/usr\/share\/drupal6\/includes\/menu.inc","line":348,"function":"call_user_func_array","args":["os_poker_poll_messages",[]]},{"file":"\/us\
13:47:37 proppy: r\/share\/drupal6\/index.php","line":19,"function":"menu_execute_active_handler","args":[]}]
13:52:39 proppy: adding more debug to os_poker_messages.php
13:53:34 proppy: LONG_POLL_LIVE_CHECK_BEGIN
13:53:34 proppy: -
13:53:34 proppy: scheduled: CUpdateUserChipsCount
13:53:34 proppy: backtrace: [{"file":"\/etc\/drupal\/6\/sites\/all\/modules\/os_poker\/os_poker_messages.php","line":68,"function":"Trigger","class":"CScheduler","object":{},"type":"->","args":\
13:53:35 proppy: ["live"]},{"function":"os_poker_poll_messages","args":[]},{"file":"\/usr\/share\/drupal6\/includes\/menu.inc","line":348,"function":"call_user_func_array","args":["os_poker_pol\
13:53:35 proppy: l_messages",[]]},{"file":"\/usr\/share\/drupal6\/index.php","line":19,"function":"menu_execute_active_handler","args":[]}]
13:53:35 proppy: -
13:53:35 proppy: messages: [{"type":"os_poker_update_chips","body":{"amount":"2000"}}]
13:54:23 emilie quit IRC (Quit: Leaving.).
13:56:02 emilie joined #pokersource.
13:58:05 mongolito404: proppy: So the task is properly enqueued and dequeued. And the message should then be in a response.
13:58:50 mongolito404: Your are positive that you don't have multiple browser window opened for the same user.
13:59:40 mornifle quit IRC (Ping timeout: 246 seconds).
13:59:48 mongolito404: And your are positive the os_poker_update_chips is not in any response to requests to poker/message/receive
14:01:40 proppy: mongolito404: I think I was looking at the wrong response
14:03:22 proppy: {"errorMsg":null,"error":false,"messages":[{"type":"os_poker_messagebox","body":{"inbox":1,"picture":"sites\/all\/modules\/os_poker\/images\/mailbox.png"}},{"type":"os_poker_update_chips","body":{"amount":"2000"}}]}
14:03:31 proppy: I receive it as part of the first request
14:03:43 proppy: so maybe https://gna.org/bugs/?15207 is to blame
14:05:18 mongolito404: Maybe
14:05:28 mongolito404: When checking I see another possible race condition.
14:07:19 proppy: mongolito404: wierd
14:07:24 proppy: sometime the call to http://drupal-kez.pokersource.info/drupal6/?q=poker/messages/receive&_=1265029582116&ajax=1 returns
14:07:26 proppy: sometimes not
14:07:52 proppy: while I do see LONG_POLL_LIVE_CHECK_BEGIN
14:07:52 proppy: -
14:07:52 proppy: scheduled: CUpdateUserChipsCount
14:07:53 proppy: backtrace: [{"file":"\/etc\/drupal\/6\/sites\/all\/modules\/os_poker\/os_poker_messages.php","line":68,"function":"Trigger","class":"CScheduler","object":{},"type":"->","args":\
14:07:53 proppy: ["live"]},{"function":"os_poker_poll_messages","args":[]},{"file":"\/usr\/share\/drupal6\/includes\/menu.inc","line":348,"function":"call_user_func_array","args":["os_poker_pol\
14:07:53 proppy: l_messages",[]]},{"file":"\/usr\/share\/drupal6\/index.php","line":19,"function":"menu_execute_active_handler","args":[]}]
14:07:53 proppy: -
14:07:53 proppy: messages: [{"type":"os_poker_update_chips","body":{"amount":"2000"}}]
14:07:54 proppy: -
14:07:54 proppy: count: 2
14:07:55 proppy: -
14:07:55 proppy: LONG_POLL_LIVE_CHECK_END
14:07:56 proppy: int he logs
14:08:10 dachary: back
14:09:28 mongolito404: The "current_user" is loaded from DB early in os_poker_poll_messages. CUpdateUserChipsCount::Run does not force a reload from the database. So the chips amount is actually what was loaded earlier when os_poker_poll_messages started. The fix is easy.
14:10:41 proppy: mongolito404: maybe I have an hidden browser somewhere
14:10:48 proppy: that is receiving the request, instead of me
14:10:49 proppy: LONG_POLL_LIVE_CHECK_END{"errorMsg":null,"error":false,"messages":[{"type":"os_poker_messagebox","body":{"inbox":1,"picture":"sites\/all\/modules\/os_poker\/images\/mailbox.png\
14:10:50 proppy: "}},{"type":"os_poker_update_chips","body":{"amount":"2000"}}]}
14:11:07 proppy: mongolito404: ah I see
14:11:33 proppy: mongolito404: that's wierd because in firebug I see {"errorMsg":null,"error":false,"messages":[{"type":"noop","body":null}]}
14:11:34 dachary: mongolito404: proppy could you please summarize the remaining problems that need work on drupal-demo ?
14:11:53 proppy: dachary: http://drupal-dev.pokersource.info/z2/ticket/21
14:12:06 proppy: dachary: http://drupal-dev.pokersource.info/z2/ticket/18
14:12:27 proppy: http://drupal-dev.pokersource.info/z2/ticket/24
14:12:31 proppy: dachary: ^
14:12:35 proppy: we're still on 21
14:13:28 dachary: http://drupal-dev.pokersource.info/z2/ticket/18 do you mean that pokersocial has not been updated yet ?
14:13:44 proppy: dachary: yes, because we were working on 21
14:13:46 dachary: or do you mean that only hands played is updated and not the rest ?
14:14:07 proppy: dachary: I mean that neither table list, nor opensocial has been updated while we were working on #21
14:15:47 dachary: Could you pause #21 and work #18 and #24 ? The reason why I ask is that I think #18 and #24 can be solved in less than one hour. #21 is probably not going to be resolved any time soon : it's an open problem. Am I mistaken ?
14:15:49 proppy: dachary: since #21 seemed to be a blocked I gave debugging it priority
14:16:36 proppy: dachary: I thought it was a blocker problem, for drupal-demo production upgrade today
14:16:59 proppy: and that #18 #21 were bonus since they were not closed has finished
14:17:00 mongolito404: proppy: You can use http://pastebin.com/d39f702d2 to avoids the race condition I just mentionned
14:17:06 proppy: sorry for the miss interpretation
14:17:10 mongolito404: Not sure if this will help be it couldn't hurt
14:17:11 dachary: it is. But we're in a better position if it's the last blocking problem.
14:17:32 dachary: Instead of being one of the 3 remaining problems.
14:17:50 dachary: It's not a misinterpretation on your part.
14:18:13 proppy: dachary: ok
14:18:23 proppy: sorry for the lack of vision regarding priority :)
14:18:55 dachary: You can't work the details AND ensure the prioirities, you should not feel bad about this.
14:19:45 proppy: dachary: can't upgrade package on drupal-demo
14:19:45 proppy: drupal-demo:~# apt-get install python-pokersocial
14:19:45 proppy: Reading package lists... Done
14:19:45 proppy: Building dependency tree
14:19:46 proppy: Reading state information... Done
14:19:46 proppy: Some packages could not be installed. This may mean that you have
14:19:46 proppy: requested an impossible situation or if you are using the unstable
14:19:46 proppy: distribution that some required packages have not yet been created
14:19:46 proppy: or been moved out of Incoming.
14:19:47 proppy: The following information may help to resolve the situation:
14:19:47 proppy: The following packages have unmet dependencies:
14:19:48 proppy: python-pokersocial: Depends: python-central (>= 0.6.11) but 0.6.8 is to be installed
14:19:48 proppy: E: Broken packages
14:19:56 proppy: (FYI, it is lenny)
14:20:23 proppy: looking if python-centre 0.6.11 is avaiable in backports
14:20:31 dachary: hum
14:20:33 proppy: no :(
14:20:45 dachary: let me fix this
14:21:42 proppy: will updated table list in the meantime
14:21:47 MotherOfCOBOL: hola
14:23:39 dachary: proppy: apt-get update ; apt-get install --reinstall
14:24:23 proppy: dachary: done
14:24:33 dachary: works ?
14:24:53 mongolito404: MotherOfCOBOL: Hi
14:25:13 dachary: MotherOfCOBOL: hey
14:27:12 proppy: restarde poker-network server on drupal-demo
14:27:23 proppy: fix fix for http://drupal-dev.pokersource.info/z2/ticket/18
14:27:27 proppy: and http://drupal-dev.pokersource.info/z2/ticket/24
14:27:30 proppy: checking now
14:28:25 proppy: dachary: table list updated
14:28:36 proppy: but please notice that http://drupal-dev.pokersource.info/trac/ticket/171 is not fixed
14:28:46 dachary: mongolito404: I see only 6 buddies in the buddy list at the bottom of the page.
14:29:04 dachary: proppy: yes
14:29:11 proppy: dachary: and also stakes are hardcoded
14:29:25 dachary: proppy: yes
14:29:35 proppy: dachary: what is the login/pass for admin http://drupal-dev.pokersource.info/trac/ticket/171
14:29:46 proppy: I wanted to add that stakes are hardcoded
14:30:22 mongolito404: dachary: Which user ? (password plz). We already had this but I may have been fixed in the poker theme and not in pbpoker
14:30:28 proppy: dachary: checked that stakes are updated
14:30:30 proppy: oups
14:30:37 proppy: hand played not stakes
14:30:48 Sp4rKy quit IRC (Ping timeout: 246 seconds).
14:32:38 proppy: http://drupal-dev.pokersource.info/trac/ticket/171#comment:1 updated
14:32:52 proppy: dachary: http://drupal-dev.pokersource.info/z2/ticket/18, http://drupal-dev.pokersource.info/z2/ticket/24 update in production
14:33:03 proppy: dachary: I will not mark the ticket as production
14:33:14 proppy: since the ticket are not closed
14:33:17 proppy: dachary: do you agree ?
14:33:27 dachary: proppy: mongolito404 now is the time where I need drupal-demo. Is there anything preventing me from trying it, except for the race condition ?
14:33:28 proppy: and please take notes of http://drupal-dev.pokersource.info/trac/ticket/171 limitation
14:33:36 dachary: proppy: I agree
14:33:46 mongolito404: dachary: Not for me
14:34:04 mongolito404: Except this " I see only 6 buddies in the buddy list at the bottom of the page" issue you just mentionned
14:34:11 proppy: please note that I haven't applied mongolito404 tentative fix for the race condition
14:34:11 proppy: http://pastebin.com/d39f702d2
14:34:18 proppy: since I've not tested it yet
14:34:37 dachary: I will manage. Is there anything else I should know ?
14:34:46 proppy: (race condition = http://drupal-dev.pokersource.info/z2/ticket/21)
14:34:50 proppy: dachary: not to my knowledge
14:38:23 proppy: back to debuggin #21 on drupal-kez
14:40:32 mongolito404: I already applied http://pastebin.com/d39f702d2 on drupal-demo
14:41:04 proppy: mongolito404: how ok
14:41:57 dachary: I'm testing right now, ping me if you think of something :-)
14:42:52 dachary: proppy: please reduce the timeout of the players back to 15 seconds in the .xml file
14:43:14 proppy: dachary: on drupal-demo ?
14:43:27 ckudige: dachary: I am about head off soon. Send me the details for drupal-chandan when its ready and I will start playing with it in the morning
14:44:17 proppy: dachary: I will restart drupal-demo poker server, with player_timeout=15 in all
14:44:19 proppy: dachary: do you agree ?
14:44:26 dachary: ckudige: cheers. will do
14:44:40 dachary: proppy: not just now, please. just the update in the configuration file.
14:44:45 proppy: dachary: ok
14:44:52 proppy: dachary: configuration file updated
14:45:06 proppy: let me know when I should restart the server
14:45:20 ckudige: dachary: proppy: mongolito404: bye
14:45:31 proppy: ckudige: see you, sorry not to have talked to you a lot :)
14:45:33 proppy: was busy
14:45:58 ckudige: proppy: no worries, this is the busiest day of the week! I will catch up tomorrow :)
14:47:13 bruno|taf quit IRC (Ping timeout: 260 seconds).
14:47:44 dachary: proppy: could you divide the table stakes by 10 ? 30-60 => 3/6 etc ?
14:47:47 bruno|taf joined #pokersource.
14:49:09 proppy: dachary: doing it, do I need to check if the corresponding stakes exist in poker-engine
14:49:11 proppy: before changing them ?
14:49:30 proppy: 5-10 0.5 -> 1 ?
14:49:37 proppy: 5-10 -> 0.5 - 1 ?
14:50:40 proppy: 10-20 -> 1-2
14:51:44 proppy: 30-60 -> 3-6
14:51:50 dachary: good
14:52:27 dachary: proppy: also please revert back to 60 seconds timeout... don't ask me why :-D
14:53:07 proppy: 100-200 -> 10-20
14:53:19 proppy: dachary: ok player_timeout=15 -> player_timeout=60
14:53:27 Sp4rKy_ joined #pokersource.
14:53:27 dachary: the person who designed the stakes now sees that ... you don't even have enough chips to start with the lowest table :-D
14:53:29 proppy: dachary: what about tables that have been commented out
14:53:35 Sp4rKy_ quit IRC (Client Quit).
14:53:36 proppy: because they were no corresponding limit ?
14:53:40 dachary: leave them commented out
14:53:43 dachary: it's ok for now
14:53:51 dachary: we're just scaling down
14:53:58 proppy: because if we divide the stakes by 10
14:54:02 proppy: they may be avaiable
14:54:16 proppy: for example 500 - 1000 -> there is 50-100
14:55:04 proppy: but for 200-400 -> there is no 20-40
14:55:16 dachary: yes but it's not mandatory
14:55:23 dachary: let's not over do it
14:55:26 proppy: ok
14:55:49 proppy: dachary: so the following table are still commented
14:55:50 proppy: http://pastebin.com/m180ea1c0
14:56:01 dachary: mongolito404: proppy the test is successfull and the user is happy. He congratulates your efforts.
14:56:02 proppy: and their corresponding buyin has not be divided by 10
14:56:07 proppy: dachary: let me know when I should restart the server
14:56:35 proppy: dachary: thanks
14:56:39 proppy: dachary: will take a lunch break then
14:56:46 dachary: proppy: you can restart
14:56:55 proppy: dachary: restarted
14:59:08 dachary: thanks
15:00:29 mongolito404: dachary: :D
15:02:56 bkuhn joined #pokersource.
15:09:00 proppy: mongolito404: I think there is a pb with the long poll
15:09:09 proppy: regarding chip update
15:09:30 proppy: mongolito404: the first time I sit on a table (with your patch applied), the amount is always updated
15:09:44 proppy: mongolito404: but, when I leave the table, and sit on another one
15:09:45 proppy: it is not
15:09:56 proppy: while server side, I see that the request has been handled
15:10:09 proppy: 2010-02-01T15:08:07+01:00scheduled: CUpdateUserChipsCount
15:10:09 proppy: backtrace: [{"file":"\/etc\/drupal\/6\/sites\/all\/modules\/os_poker\/os_poker_messages.php","line":68,"function":"Trigger","class":"CScheduler","object":{},"type":"->","args":\
15:10:09 proppy: ["live"]},{"function":"os_poker_poll_messages","args":[]},{"file":"\/usr\/share\/drupal6\/includes\/menu.inc","line":348,"function":"call_user_func_array","args":["os_poker_pol\
15:10:09 proppy: l_messages",[]]},{"file":"\/usr\/share\/drupal6\/index.php","line":19,"function":"menu_execute_active_handler","args":[]}]
15:10:10 proppy: 2010-02-01T15:08:07+01:00messages: [{"type":"os_poker_update_chips","body":{"amount":"1205"}}]
15:10:10 proppy: 2010-02-01T15:08:07+01:00count: 2
15:10:10 proppy: 2010-02-01T15:08:07+01:00LONG_POLL_LIVE_CHECK_END{"errorMsg":null,"error":false,"messages":[{"type":"os_poker_messagebox","body":{"inbox":1,"picture":"sites\/all\/modules\/os_p\
15:10:10 proppy: oker\/images\/mailbox.png"}},{"type":"os_poker_update_chips","body":{"amount":"1205"}}]}
15:10:16 proppy: I mean drupal side
15:10:36 proppy: and the firebug doesn't shows that result at all in the request tab
15:11:07 proppy: mongolito404: could it be possible that it it replies in a pending long poll instead
15:11:20 proppy: from previous patch I was on
15:11:26 proppy: mongolito404: do you understand ?
15:11:36 mongolito404: proppy: YEs
15:11:40 mongolito404: I don't know
15:11:49 mongolito404: It may be possible if the request is not canceled server side
15:11:49 proppy: mongolito404: does it makes sense
15:12:05 proppy: mongolito404: from the log I added to drupal os_poker_messages, it looks like the message was delivered
15:12:17 proppy: but I can't see it in firebug
15:12:56 proppy: maybe I should print the timestamp
15:13:03 proppy: of the request
15:13:12 proppy: http://drupal-kez.pokersource.info/drupal6/?q=poker/messages/receive&_=1265033269296&ajax=1
15:14:18 proppy: mongolito404: I think the pb would not happen if os_poker_messages, was not looping and sleeping
15:14:54 mongolito404: I really don't know.
15:15:10 mongolito404: I've never looked deeply in how long poll can be done in PHP nor in Durpal
15:17:19 proppy: mongolito404: a temporary workaround could be to reduce the number of pass to only 1
15:18:39 mongolito404: proppy: Probably
15:19:03 proppy: this way drupal could never deliver to an already cancelled poll, because poll will not last more than one request
15:20:12 mongolito404: But that would be a long call anymore
15:23:00 proppy: mongolito404: yes, maybe there is a way to check that the request has been cancelled
15:23:04 proppy: in drupal
15:23:56 mongolito404: proppy: I never saw any
15:24:10 mongolito404: But until recently I assumed the cancellation was already handled by PHP
15:24:53 proppy: you mean that the execution of the scripts, with looping sleep is aborded ?
15:26:46 mongolito404: Is though so but I never checked
15:31:11 proppy: mongolito404: I can confirm that the looping poll are not interrupted
15:32:04 mongolito404: so that may be the cause of the disappearing messages
15:32:49 proppy: mongolito404: with the following patch http://pastebin.com/f6288a2e
15:32:51 proppy: mongolito404: yes
15:32:56 proppy: they are actually delivered
15:33:04 proppy: but not to a running browser
15:33:08 proppy: they are delivered in the void
15:34:53 mongolito404: proppy: So I think we should close #21 and call it a new issue. Then see with dachary how we can fix this long polling issue.
15:35:22 proppy: mongolito404: wait I still need to update poker.social.xml
15:35:25 proppy: on drupal-demo
15:35:28 proppy: before closing #21
15:35:35 proppy: dachary: could I restart the server on drupal-demo ?
15:35:42 dachary: proppy: a sec
15:36:07 dachary: proppy: yes
15:36:14 proppy: I forgot to updated poker.social.xml with http://pastebin.com/f85861e2
15:36:39 dachary: let me know when it's restarted
15:37:03 proppy: dachary: restarted
15:37:40 proppy: mongolito404: could you add your patch/changeset to http://drupal-dev.pokersource.info/z2/ticket/21 ?
15:38:24 proppy: added mine in http://drupal-dev.pokersource.info/z2/ticket/21#comment:12
15:39:45 mongolito404: proppy: You mean commit http://pastebin.com/d39f702d2 ?
15:39:58 proppy: mongolito404: yes
15:40:11 mongolito404: will do
15:43:48 dachary drupal-demo backup done. It's valuable to keep a state that makes the user happy :-)
15:44:10 proppy: mongolito404: filled http://drupal-dev.pokersource.info/trac/ticket/173
15:44:18 proppy: dachary: filled http://drupal-dev.pokersource.info/trac/ticket/173
15:44:25 proppy: now having a lunch break for real
15:45:04 proppy: mongolito404: I think we can close #21 after https://gna.org/bugs/?15207 is fixed
15:45:18 dachary: proppy: :-)
15:45:20 mongolito404: proppy: I agree
15:46:17 mongolito404: we spotted an issue with the long poll. #21 works as expected except for this issue which is more general.
15:46:52 dachary: proppy: mongolito404 now there will be a major revision of the ticket priorities. And tomorrow morning we will discuss how to handle this. I'm not sure exactly how it will look.
15:50:10 mongolito404: dachary: That's what I understood from your yesterday mail.
16:16:17 mornifle joined #pokersource.
16:33:39 dachary quit IRC (Ping timeout: 246 seconds).
16:57:53 proppy: back
17:01:12 dachary joined #pokersource.
17:01:12 dachary quit IRC (Changing host).
17:01:12 dachary joined #pokersource.
18:06:39 dachary: proppy: here ?
18:06:52 proppy: dachary: yes, starring at pokersocial code :)
18:07:08 dachary: :-)
18:07:32 dachary: trying to nail the race condition ?
18:07:45 proppy: no, working on http://drupal-dev.pokersource.info/z2/ticket/24 as you advised
18:08:03 proppy: dachary: should I work on https://gna.org/bugs/?15207 instead ?
18:08:12 proppy: I thought that today #24 had priority
18:08:28 dachary: no, it was just a wild guess. #24 is top priority indeed.
18:09:23 proppy: dachary: about pokersocial sql schema, are you available for a few question ?
18:09:42 proppy: (achievements sql schema)
18:10:12 proppy: I'm not sure what:
18:10:13 proppy: win_row_max INT DEFAULT 0,
18:10:13 proppy: win_row_last INT DEFAULT 0,
18:10:13 proppy: win_row INT DEFAULT 0,
18:10:13 proppy: hand_row_max INT DEFAULT 0,
18:10:14 proppy: hand_row_last INT DEFAULT 0,
18:10:14 proppy: hand_row INT DEFAULT 0,
18:10:14 dachary: sure. But first I would like us to review the pending tickets and discuss them shortly (5 minutes each). Can we do that ?
18:10:14 proppy: are for
18:10:21 proppy: dachary: sure
18:10:31 dachary: the priorities are set
18:10:45 proppy: dachary: on http://drupal-dev.pokersource.info/z2/query?status=accepted&status=assigned&status=new&status=reopened&group=owner&order=priority&col=id&col=summary&col=owner&col=type&col=component&milestone=5+feb+2010
18:10:45 proppy: ?
18:11:19 proppy: I see 2 tasks one for client one for server
18:11:22 proppy: http://drupal-dev.pokersource.info/z2/ticket/17 <- client
18:11:33 proppy: http://drupal-dev.pokersource.info/z2/ticket/24 <- server
18:11:45 dachary: hold it
18:11:52 dachary: you're going too fast
18:12:01 dachary: I'm looking for the query :-)
18:12:54 proppy: dachary: do you want to talk about ticket that are already assigned/accepted to 'client' or 'server' for next milestone
18:13:15 proppy: or ticket that are assigned to admin, waiting for me to assign them to me
18:13:42 dachary: http://drupal-dev.pokersource.info/z2/query?status=accepted&status=assigned&status=new&status=reopened&group=type&order=priority&priority=now&col=id&col=summary&col=status&col=milestone
18:14:01 dachary: http://drupal-dev.pokersource.info/z2/query?status=accepted&status=assigned&status=new&status=reopened&group=component&order=priority&priority=now&col=id&col=summary&col=status&col=milestone
18:14:05 dachary: this one :-0
18:14:15 dachary: I'm interested in tickets with priority "now" only
18:14:16 proppy: the latter ?
18:14:39 dachary: http://drupal-dev.pokersource.info/z2/query?status=accepted&status=assigned&status=new&status=reopened&group=component&order=priority&priority=now&col=id&col=summary&col=status&col=milestone
18:14:40 dachary: yes
18:14:45 proppy: dachary: should I look a url #1 url #2 or both
18:14:46 proppy: ok
18:15:01 dachary: we're looking at "Server" and "Client" tickets
18:15:15 mongolito404: Allthese tickets should have 5/2 as milestone, right ?
18:15:37 proppy: dachary: yes what about the milestone of these ticket ?
18:15:49 dachary: mongolito404: hey :-) maybe, maybe not. They are all candidates. It's up to us to decide which one will make it and which one won't.
18:15:49 mongolito404: Or are you only talking about Client/Server tickets ?
18:16:00 mongolito404: dachary: Ok
18:16:01 proppy: I see milestone for 4 of them, #17, #24, #82, #86
18:16:06 dachary: mongolito404: that's also for you but I thought you were gone already ;-)
18:16:08 proppy: dachary: ok
18:16:37 mongolito404: I should be "gone"... will see the tickets tomorrow morning.
18:16:46 proppy: dachary: if I understand http://drupal-dev.pokersource.info/z2/ticket/17 well
18:16:47 dachary: mongolito404: ok, thanks !
18:16:55 proppy: it is about skinning the poker lobby
18:17:04 proppy: i.e doing some css for it to look like the mockup
18:17:10 proppy: dachary: do you agree ?
18:18:28 dachary: yes, I do. And I thought that would be a good first interaction with Ulrike
18:18:52 dachary: I don't think it can be completed this week though.
18:19:22 emilie quit IRC (Quit: Leaving.).
18:19:25 dachary: Because there is an associated pending problem that needs to be solved before it goes online : how do we notify the user about an ongoing tournment.
18:19:30 proppy: dachary: but you assigned it to ' 29 jan 2010 ' deadline
18:20:13 dachary: proppy: not anymore
18:20:16 proppy: dachary: is there a separate ticket for tournament related issues ? or should it be handled in http://drupal-dev.pokersource.info/z2/ticket/17 ?
18:20:49 proppy: dachary: yes I updated the deadline to 5 feb 2010 friday, but if it can't be completed this week, this is a probleme
18:21:01 proppy: dachary: I'm trying to understand the scope of this ticket
18:21:01 dachary: http://drupal-dev.pokersource.info/z2/ticket/83 is the ticket that blocks /83
18:21:17 dachary: /17 rather
18:21:23 proppy: dachary: I thought http://drupal-dev.pokersource.info/z2/ticket/17 was only about css integration
18:21:24 proppy: my bad
18:21:39 dachary: proppy: basically the scope of the ticket is "make tournament work"
18:21:56 proppy: yes, I miss interpreted the title
18:22:03 proppy: basicaly I thought Mockup == CSS
18:22:27 dachary: http://drupal-dev.pokersource.info/z2/ticket/75
18:22:31 proppy: I understand now, sorry for the confusion
18:23:04 dachary: #75 #83 and #17 are all about tournaments and they are all expecting input from the client, therefore we can't set a deadline, therefore it's not for this week.
18:23:51 dachary: http://drupal-dev.pokersource.info/z2/ticket/56 seems straightforward
18:23:56 proppy: dachary: so should remove the Milestone from 75 ?
18:24:02 proppy: oups 17 I meant
18:24:11 dachary: proppy: I did it alrady
18:24:14 dachary: already
18:24:15 proppy: you already did it ok
18:24:46 proppy: dachary: about #56 I believe it could be done with CSS
18:25:05 dachary: It's also a good occasion to interact with MotherOfCOBOL
18:25:42 dachary: Any doubts about #56 ?
18:26:01 proppy: dachary: about interacting with MotherOfCOBOL, what do you prefer ?
18:26:14 dachary: how do you mean ?
18:26:27 proppy: I take charge of the ticket, and I explain to MotherOfCOBOL how I fixed it
18:26:47 proppy: or MotherOfCOBOL takes charge of the ticket, and ask me for help if needed ?
18:26:48 dachary: yes
18:26:50 dachary: first one
18:26:52 proppy: ok
18:26:55 proppy: understood
18:27:14 dachary: MotherOfCOBOL: is new, you take the lead. When she has more experience, this will change ;-)
18:27:38 dachary: let's move to the server tickets
18:27:51 dachary: oh
18:27:51 proppy: what about #80 and #83 ?
18:27:53 dachary: #80
18:27:56 proppy: "Client"
18:28:03 dachary: #83 is also about tournaments, postponed
18:28:25 dachary: #80 looks like javascript behaviour change in the list of table mostly.
18:28:35 dachary: Do you see anything tricky ?
18:28:45 proppy: #80 a) b) is css
18:28:53 proppy: and c) is revert javascript code
18:29:08 proppy: that has been asked to be removed, in a previous ticket
18:29:45 proppy: http://drupal-dev.pokersource.info/z2/ticket/16
18:30:00 dachary: yes
18:30:14 dachary: typical change of heart I'm afraid :-(
18:30:37 proppy: so #80 will also be a good candidate for interactif with MotherOfCOBOL
18:30:45 proppy: at least for point a) and b)
18:30:57 dachary nods
18:31:10 dachary: shall we move to server tickets ?
18:31:19 proppy: #83 (waiting for client input)
18:31:23 proppy: dachary: yes
18:31:29 dachary: #24 and #86
18:31:37 dachary: #25 and #82 are not for you
18:31:52 dachary: #82 will be for me and Sp4rKy
18:31:58 dachary: #25 is undecided
18:32:07 dachary: #24 and #86 are linked
18:32:16 proppy: I don't get, http://drupal-dev.pokersource.info/z2/ticket/82 but it's ok :)
18:33:01 proppy: I think you inverted tickets #25 seems for you and sp4rky
18:33:06 proppy: and #82 looks undecided
18:33:26 dachary: no
18:33:36 dachary: but it does not matter :-)
18:33:40 proppy: ok
18:33:45 dachary: about #86
18:33:55 dachary: implementing all can't be done this week
18:33:56 dachary: but
18:34:20 dachary: there are many rewards that are very unlikely and can be postponed.
18:34:22 j1b quit IRC (Quit: Ex-Chat).
18:34:29 proppy: dachary: ok
18:34:31 dachary: let me create a two tickets in /trac/ to sort that out
18:34:38 proppy: I think implementing 24 before 86 makes sense
18:34:50 dachary: (phone)
18:34:57 proppy: dachary: please don't create a ticket by rewards :)
18:41:14 bkuhn is now known as bkuhnIdle.
18:41:27 dachary: (back)
18:41:28 dachary: sorry
18:41:33 dachary: proppy: :-)
18:41:49 dachary: I thougth about creating a ticket for the rewards that are most likely ;-)
18:42:02 proppy: about achievement #86 and stats #24
18:42:08 dachary: yes ?
18:42:19 proppy: I would like to discuss with you the sql schema
18:42:27 proppy: of the current achievments table
18:43:33 proppy: dachary: there are more achievement described than fields in this sql table
18:44:21 proppy: and the achievement table looks generic like " hole_aa INT DEFAULT 0 "
18:44:52 proppy: while achievement are pretty specific #04 Bullets Player wins with AA hole cards
18:45:08 proppy: I wonder how they were related
18:45:39 proppy: IIRC for achievement drupal only needs UserData matching the name of the achievement to be set
18:46:04 proppy: is drupal also looking at the achievements sql table ?
18:47:07 proppy: grepping os_poker code
18:47:34 dachary: (sorting rewards)
18:48:00 proppy: and I'm also wondering the purpose of these field
18:48:01 proppy: win_all_in INT DEFAULT 0,
18:48:01 proppy: win_row_max INT DEFAULT 0,
18:48:01 proppy: win_row_last INT DEFAULT 0,
18:48:01 proppy: win_row INT DEFAULT 0,
18:48:01 proppy: hand_row_max INT DEFAULT 0,
18:48:02 proppy: hand_row_last INT DEFAULT 0,
18:48:02 proppy: hand_row INT DEFAULT 0,
18:48:02 proppy: chip_swing INT DEFAULT 0,
18:48:33 proppy: also meaning of hole_* and strenght_* field is unclear to me
18:48:48 dachary: http://drupal-dev.pokersource.info/trac/ticket/175
18:49:23 proppy: hole_ : number of time this hand as been deal to this user, or number of time user has won with this hand ? or just 1 or 0 flag
18:49:39 proppy: same for strength_
18:50:52 proppy: 19 It's my round! Player buys a gift for every player at the table, value doesn't matter PS/SN Its_my_round.gif Bronce (looks like a drupal thing)
18:50:54 dachary: I suggest you take a look at 175
18:51:06 dachary: it's a simpler subset of the rewards
18:51:14 proppy: dachary: that's what I'm doing :)
18:51:25 proppy: 20 Challenger Player participates in a challenge PS/SN challenger.gif Bronce (are challenge working ?)
18:51:26 dachary: ok :-)
18:52:19 dachary: Unless you broke it since the last time you tested it, they are in the same state you left them :-)
18:53:15 proppy: dachary: yes, but last time I tested it, the drupal workflow was unclear IIRC
18:53:24 proppy: IIRC I tested it using urls
18:54:06 proppy: checking if there is a way to know that a tourney is a challenge, from the tourney_serial
18:54:11 dachary: Yes, and the drupal workflow is still very unclear, because it's a tournament for which there is no notification.
18:54:37 dachary: proppy: you rightfully picked the most complicated reward
18:54:45 dachary: It's my round!
18:55:44 proppy: "my round" ?
18:55:57 dachary: is also a little tricky because it implies cooperation between drupal & jpoker. I actually think it's for mongolito404 to implement, at the same place he handles the distribution of gifts. In this sense it's not PS/SN
18:55:59 proppy: maybe we can use tourney_name to know if this is a challenge
18:56:02 dachary: proppy: 19
18:56:20 dachary: It's my round! reward number 19
18:56:35 proppy: if there is "versus" in the tourney name it means it is a challenge
18:57:13 proppy: because the gadget call tourneyCreate with %(serial1)dversus%(serial2)d as packet.name
18:57:47 dachary: proppy: let's forget about challenge
18:57:47 proppy: PS = pokersource, SN = socialnetwork ?
18:57:50 dachary: http://drupal-dev.pokersource.info/trac/ticket/175
18:57:59 dachary: updated to say the reward for challenge is optional
18:58:11 proppy: dachary: ok
18:58:25 dachary: since the challenge workflow is yet to be defined, it would be a mistake to focus on this. Thanks for bringing this to my attention.
18:58:48 proppy: np, thanks for taking the time, to review this with me
19:00:36 proppy: about rewards #19, I think you're right to says it needs to be implemented in drupal, because currently pokersource knows nothing about gift
19:01:03 dachary: Let say #85 on Z2 translates in http://drupal-dev.pokersource.info/trac/ticket/175 and http://drupal-dev.pokersource.info/trac/ticket/3 will be completed later. Ok ?
19:02:04 dachary: proppy: http://drupal-dev.pokersource.info/trac/ticket/176
19:02:32 proppy: http://drupal-dev.pokersource.info/trac/ticket/3 is a catch all "made rewards works" ticket ?
19:02:49 dachary: http://drupal-dev.pokersource.info/trac/ticket/175 updated with 19 removed
19:02:57 proppy: dachary: ok
19:02:59 dachary: #3 => yes :)
19:03:05 proppy left #pokersource.
19:03:15 proppy joined #pokersource.
19:03:17 proppy: oups
19:03:19 dachary: its the ticket that will be closed when the rewards are complete
19:03:32 proppy: ok
19:03:47 proppy: alongside with http://drupal-dev.pokersource.info/z2/ticket/86
19:04:26 dachary: no, #86 will be closed when http://drupal-dev.pokersource.info/trac/ticket/175
19:04:31 proppy: dachary: oh ok
19:04:33 proppy: I understand
19:05:15 proppy: so 'most rewards are not working', will be fixed when 'most rewards are working'
19:05:21 proppy: it makes perfect sense ! :)
19:06:58 proppy: dachary: I have question about 2 Blind Hen Player wins his first hand PS blindhen.gif Bronce
19:07:08 proppy: does it means first hand ever,
19:07:20 proppy: ?
19:07:39 proppy: or first and since joining the table
19:08:05 proppy: I guess it means "first hand ever"
19:08:49 dachary: first hand ever
19:09:11 dachary: and first hand since joining the table would not make a difference ;-)
19:10:07 proppy: yes, you're correct :)
19:10:19 proppy: a rewards is a one time thing
19:11:53 proppy: so #56, #80, #24, #86 are candidate for the next deadline
19:11:54 proppy: dachary: ^
19:12:10 proppy: for client/server
19:13:18 proppy: (#86 == #175)
19:13:57 dachary: yes
19:16:31 proppy: http://drupal-dev.pokersource.info/z2/ticket/86 has already 5 fev deadline
19:16:38 proppy: http://drupal-dev.pokersource.info/z2/ticket/24 too
19:17:10 proppy: reassigned http://drupal-dev.pokersource.info/z2/ticket/56#comment:12 to client, and assigned milestone
19:17:57 proppy: reassigned http://drupal-dev.pokersource.info/z2/ticket/80#comment:3 to client, and assigned milestone
19:18:11 dachary: bbl
19:19:06 proppy: reassigned http://drupal-dev.pokersource.info/z2/ticket/86#comment:2 to server
19:28:14 bkuhnIdle is now known as bkuhn.
19:55:34 mornifle quit IRC (Ping timeout: 245 seconds).
20:05:47 mongolito404 quit IRC (Quit: Leaving.).
20:20:11 bruno98 quit IRC (Read error: Operation timed out).
20:21:56 mornifle joined #pokersource.
21:02:52 bruno|taf quit IRC (Quit: Leaving.).
21:03:07 ramboz joined #pokersource.
21:07:34 proppy: http://drupal-dev.pokersource.info/z2/ticket/24#comment:9 updated
21:18:30 proppy: mailed pokersource about todays work
21:18:42 proppy quit IRC (Quit: Leaving.).
23:04:02 macmaN quit IRC (Read error: Connection reset by peer).
23:54:25 ckudige: dachary: 'morning !
23:54:35 dachary: ckudige: :-D
23:54:39 dachary: morning sir
23:54:58 ckudige: I realised it was a very hectic day yesterday !
23:55:18 dachary: :-D
23:55:29 dachary: monday's...
23:55:38 dachary: the rest of the week won't be like this ;-)
23:55:52 ckudige: pierre gave me a detailed explanation of the process yesterday ... I now have a more first-hand experience being a spectator :)
23:56:11 ckudige: Yeah, I am sure! But half of the fun in coding is the craziness during integration right ?
23:56:26 dachary: :-)
23:56:43 ckudige: I also started looking at the code .. its a bit hairy I must say :)
23:56:46 dachary: Yes, as long as it does not turn into a nightmare. I think we're in a good place.
23:56:56 ckudige: definitely
23:57:17 dachary: ckudige: there is too much code indeed. If it was not for the tests, it would be a hopeless mess.
23:58:15 ckudige: yeah ... once I have my server I want to run the tests, and get started from there. Its always the best place to start getting familiar
23:58:26 dachary: But it's not nonsense. There is logic in it. And it's not absurd. It's the best mess you can get ;-)
23:58:35 dachary: You have the server.
23:58:37 ckudige: hehe, I will take your word on it !
23:59:04 dachary: didn't sp4rky give you access ?
23:59:07 thy quit IRC (Quit: Leaving.).
23:59:18 ckudige: nope .. not that I know of
23:59:38 ckudige: yesterday I logged in as root to Pierre's server and clicked on admin panel and poof went his server ... poor guy ... turned out to be some cache misbehaviour!!
23:59:45 dachary: :-)
23:59:48 ckudige: (he was also doing something as root at the same time)

Proceed to Tuesday 2 February 2010

Brought to you by your friendly neighborhood Logger Bot.