Back to #pokersource@irc.freenode.net Log Calendar
Back to to Sunday 17 January 2010
| 00:29:33 | macmaN | quit IRC (Read error: 54 (Connection reset by peer)). |
| 00:33:26 | proppy | joined #pokersource. |
| 00:35:29 | bkuhn | joined #pokersource. |
| 00:47:10 | proppy | quit IRC ("Leaving."). |
| 01:05:29 | mornifle | quit IRC ("Leaving."). |
| 02:31:38 | bkuhn | quit IRC (zelazny.freenode.net irc.freenode.net). |
| 02:31:39 | brian_ | quit IRC (zelazny.freenode.net irc.freenode.net). |
| 02:32:57 | macmaN | joined #pokersource. |
| 02:45:22 | macmaN | quit IRC (Read error: 104 (Connection reset by peer)). |
| 02:54:38 | bkuhn | joined #pokersource. |
| 02:54:38 | brian_ | joined #pokersource. |
| 04:48:25 | macmaN | joined #pokersource. |
| 04:51:24 | macmaN | quit IRC (Read error: 104 (Connection reset by peer)). |
| 05:29:29 | bkuhn | quit IRC ("Sleeping"). |
| 06:54:28 | macmaN | joined #pokersource. |
| 08:25:38 | dachary | quit IRC (Read error: 113 (No route to host)). |
| 08:32:00 | jbs | joined #pokersource. |
| 08:32:04 | jbs | left #pokersource. |
| 08:57:49 | mongolito404 | joined #pokersource. |
| 09:15:16 | dachary | joined #pokersource. |
| 09:17:05 | mongolito404: | Hello World |
| 09:25:05 | dachary: | :-) |
| 09:25:13 | dachary: | hi |
| 09:25:39 | emilie | joined #pokersource. |
| 09:28:08 | dachary: | emilie: bonjour |
| 09:31:19 | proppy | joined #pokersource. |
| 09:32:38 | dachary: | proppy: bonjour |
| 09:33:24 | proppy: | dachary: hi |
| 09:33:30 | proppy: | sorry to be late :) |
| 09:33:36 | dachary: | :-D |
| 09:33:52 | proppy: | 53 seconds late |
| 09:34:15 | mongolito404: | dachary: About http://drupal-dev.pokersource.info/trac/ticket/15#comment:18, I guess I should do what is required to force opening of the ''fortgot password'' page in a box (at least when redirected from user.rest) ? |
| 09:34:27 | dachary: | Do you know where to find the reward related code ? I mean the "newcomer" code. |
| 09:34:40 | dachary: | proppy: ^ |
| 09:34:54 | dachary: | "newcomer" is when a player sits at the table |
| 09:34:59 | proppy: | ok |
| 09:35:03 | proppy: | for the first time ? |
| 09:35:24 | dachary: | yes |
| 09:35:32 | proppy: | will look where it is in poker.js and os_poker |
| 09:35:49 | dachary: | mongolito404: I'm not sure what you mean. Do you know where the regression comes from ? |
| 09:36:26 | dachary: | hum |
| 09:36:31 | dachary: | I'm reading your comment |
| 09:36:39 | proppy: | poker.arriveNotify = function(serial) { parent.os_poker_sit(); }; |
| 09:36:40 | dachary: | I will try again |
| 09:36:58 | dachary: | mongolito404: did you try ? |
| 09:36:59 | proppy: | case 'PacketPokerPlayerArrive': |
| 09:37:00 | proppy: | if(server.loggedIn() && packet.serial == server.serial) { |
| 09:37:00 | proppy: | jpoker.message('poker.update arrive ' + packet.serial); |
| 09:37:00 | proppy: | poker.arriveNotify(packet.serial); |
| 09:37:00 | proppy: | } |
| 09:37:01 | proppy: | break; |
| 09:37:02 | proppy: | in poker.js |
| 09:37:38 | dachary: | mongolito404: I just tried and it works perfectly. |
| 09:37:45 | proppy: | ./os_poker.toolkit.js:114:function os_poker_sit(players_at_table) |
| 09:37:54 | dachary: | you can close the ticket, sorry for the noise. |
| 09:38:01 | dachary: | proppy: ok |
| 09:38:08 | proppy: | os_poker_send_message({type :"os_poker_sit_down", players: players_at_table}); |
| 09:38:20 | proppy: | dachary: os_poker assume there is an argument in os_poker_sit |
| 09:38:25 | proppy: | but poker.js call it without arguments |
| 09:38:31 | dachary: | proppy: ah ! |
| 09:38:35 | proppy: | so players_at_table will always be undefined |
| 09:38:35 | dachary: | that explains it |
| 09:38:40 | mongolito404: | dachary: As i said, this happen with expired password reset links, for instance from now this will reproduce the issue on drupal-404 http://drupal-404.pokersource.info/drupal6/?q=user/reset/180/1263474182/a6e97be1faf27b282e840a16a9ef3bd6 |
| 09:38:58 | dachary: | mongolito404: yes, and it's ok |
| 09:39:05 | mongolito404: | dachary: Ok |
| 09:39:15 | proppy: | dachary: looking at os_poker to see how it use players_at_table variable |
| 09:39:18 | dachary: | I'm glad it's not a regression and I apologize for thinking you could have let a regression happen ;-) |
| 09:39:40 | mongolito404: | dachary: np |
| 09:39:49 | proppy: | case "os_poker_sit_down": |
| 09:39:49 | proppy: | CheckRewards("sit", $current_user->uid, json_decode($_GET["players"], TRUE)); |
| 09:39:50 | proppy: | $resp["messages"][] = array("type" => "noop", "body" => NULL); |
| 09:40:21 | mongolito404: | This should be CPoker::CheckRewards("sit", $current_user->uid, json_decode($_GET["players"], TRUE)); |
| 09:40:35 | mongolito404: | If just fixed this on drupal-404 and drupal-demo |
| 09:40:36 | dachary: | proppy: could you fix this & install the fix on drupal-demo as soon as we're finished talking ? |
| 09:40:52 | mongolito404: | http://drupal-dev.pokersource.info/trac/ticket/153#comment:2 |
| 09:41:35 | proppy: | it seems that players_at_table is used for CPoker::GiveReward("reward18", $player, $rew); |
| 09:41:40 | dachary: | http://drupal-dev.pokersource.info/trac/ticket/154 good catch |
| 09:42:13 | proppy: | dachary: by fix this, I assume you mean passing players_at_table to the function callback |
| 09:42:23 | dachary: | proppy: yes :-) |
| 09:42:27 | dachary: | proppy: could you pause the exploration so that we can talk about what needs to be done ? |
| 09:42:50 | dachary: | I know it's frustrating but I would appreciate your input. |
| 09:42:50 | proppy: | I finished explored |
| 09:43:03 | proppy: | so reward18 is buggy because players_at_table is always undefined |
| 09:43:14 | proppy: | we will need to fill a ticket about that |
| 09:43:19 | dachary: | yes |
| 09:43:35 | proppy: | dachary: do we need to talk about http://drupal-dev.pokersource.info/trac/ticket/15 ? |
| 09:43:43 | dachary: | proppy: according to your intense work end of last week, what do you think deserves attention today ? |
| 09:43:44 | proppy: | from the backlog it seems mongolito404 is already on it |
| 09:43:54 | dachary: | proppy: it's fixed |
| 09:43:58 | proppy: | ok |
| 09:44:00 | dachary: | proppy: ticket/15 |
| 09:44:30 | proppy: | I see blockers on http://drupal-dev.pokersource.info/trac/query?status=accepted&status=assigned&status=new&status=reopened&component=Poker&order=priority&col=id&col=summary&col=status&col=type&col=priority&col=milestone&col=component |
| 09:44:39 | proppy: | so I believe they need immediate attention |
| 09:45:04 | proppy: | other than that I remember you said #3 and #30 needs "developments" |
| 09:45:23 | proppy: | #108 #110 would need upstream fixes |
| 09:45:31 | dachary: | I think http://drupal-dev.pokersource.info/trac/ticket/127 |
| 09:45:54 | dachary: | is important and could be worked on today. |
| 09:46:04 | proppy: | and #102 could be backported |
| 09:46:29 | proppy: | yes it is tagged at blockers |
| 09:46:41 | proppy: | so I assumed it need immediate attention |
| 09:47:11 | proppy: | dachary: do you agree with saq suggestions on it |
| 09:47:34 | mongolito404: | proppy: I believe you opened http://drupal-dev.pokersource.info/trac/ticket/148 and that it was about the skinning of the jpoker gadget. Right ? |
| 09:47:43 | dachary: | it absolutely makes sense |
| 09:47:55 | dachary: | proppy: something must be done when the page unloads |
| 09:48:03 | proppy: | mongolito404: oh ye sorry I forgot to assign it to Poker component |
| 09:48:09 | Sp4rKy: | heya, maybe pokersource can be interested for a conf during the BEC ? "free games" is one of the proposal : http://www.breizh-entropy.org/cfp.html |
| 09:48:17 | proppy: | dachary: I think something should be also do in os_poker |
| 09:48:23 | proppy: | when a page unload |
| 09:48:26 | dachary: | Sp4rKy: good morning sir |
| 09:48:29 | Sp4rKy: | :) |
| 09:48:42 | dachary: | proppy: yes, because os_poker also has a long poll |
| 09:48:47 | mongolito404: | proppy: Is #148 fixed ? |
| 09:48:47 | proppy: | dachary: so maybe jpoker could call window.top.os_poker_exit |
| 09:48:50 | proppy: | or something like this |
| 09:48:51 | proppy: | mongolito404: no |
| 09:49:22 | proppy: | mongolito404: reassigned it to poker http://drupal-dev.pokersource.info/trac/ticket/148#comment:4 |
| 09:49:47 | dachary: | proppy: agreed |
| 09:49:53 | proppy: | dachary: updating the ticket |
| 09:50:41 | proppy: | http://drupal-dev.pokersource.info/trac/ticket/127#comment:5 |
| 09:50:56 | dachary: | proppy: except the broken reward, there are not pressing matters today. I think it's a good time to fix a real bug that has no visual impact (i.e. the ticket/127). Do you agree with this ? |
| 09:50:56 | proppy: | implementation: * update jpoker gadget so it register a handler on window.on_exit that cancels long poll, and calls window.top.os_poker_exit |
| 09:51:16 | proppy: | sure, there is a visual impact for #127 too |
| 09:51:22 | proppy: | it spawns alert() |
| 09:51:25 | proppy: | when you changes pages |
| 09:51:37 | proppy: | and the workaround (disable all error handling) is ugly |
| 09:51:44 | dachary: | proppy: true :-) |
| 09:51:44 | proppy: | and is a regression |
| 09:51:49 | dachary: | yes |
| 09:51:51 | proppy: | so I agree this needs immediate attention |
| 09:52:21 | dachary: | ok, you're set for today then. Is there anything else you would like to discuss ? |
| 09:52:41 | proppy: | did you reproduce http://drupal-dev.pokersource.info/trac/ticket/103 ? |
| 09:52:49 | proppy: | I noticed you tagged it blocker |
| 09:52:57 | dachary: | Yes I did. |
| 09:53:11 | dachary: | I added a comment too. |
| 09:53:36 | dachary: | updated the description rather. |
| 09:53:40 | proppy: | ok, so you reproduced it friday ? |
| 09:53:44 | dachary: | yes |
| 09:54:14 | proppy: | I believe http://drupal-dev.pokersource.info/trac/ticket/136 should have component Poker |
| 09:54:20 | dachary: | what's even more embarassing is that exit button does not leave the table |
| 09:54:26 | proppy: | +not |
| 09:54:39 | dachary: | when you're stuck without chips the only thing you can do is to wait for the timeout |
| 09:54:41 | proppy: | I believe http://drupal-dev.pokersource.info/trac/ticket/136 should have component Drupal |
| 09:54:44 | dachary: | or sit at another table |
| 09:55:01 | dachary: | proppy: looking |
| 09:55:05 | proppy: | dachary: if you don't have chips, you won't participate to the hand |
| 09:55:08 | proppy: | so there is no timeout |
| 09:55:20 | proppy: | maybe you're talking of table_timeout |
| 09:55:24 | proppy: | not round_timeout |
| 09:55:41 | dachary: | proppy: you are correct |
| 09:55:45 | dachary: | http://drupal-dev.pokersource.info/trac/ticket/136#comment:2 |
| 09:56:38 | dachary: | proppy: I mean that in order to leave the table, the only thing you can do is close the page and wait for the long poll timeout to disconnect you |
| 09:56:42 | j1b | joined #pokersource. |
| 09:56:55 | proppy: | about exit not making the player leave the table |
| 09:56:59 | proppy: | I believe you should reopen http://drupal-dev.pokersource.info/trac/ticket/72 |
| 09:57:10 | proppy: | or update http://drupal-dev.pokersource.info/trac/ticket/75 |
| 09:57:13 | proppy: | or fill a new ticket |
| 09:57:29 | proppy: | dachary: I think there is a race condition |
| 09:57:39 | dachary: | http://drupal-dev.pokersource.info/trac/ticket/155 |
| 09:57:40 | proppy: | between the page redirection, and sending PacketPokerTableQuit |
| 09:57:59 | dachary: | proppy: the redirection must happen in a settimeout |
| 09:58:05 | proppy: | we should wait for the ack of PacketPokerTableQuit |
| 09:58:10 | dachary: | proppy: is it the case ? |
| 09:58:10 | proppy: | before redirecting the player |
| 09:58:16 | dachary: | proppy: it's not necessary |
| 09:58:28 | dachary: | setting a callback to redirect 1 second after is enough |
| 09:58:36 | dachary: | the XHR will go thru |
| 09:58:47 | dachary: | but you're right |
| 09:58:54 | proppy: | currently the callback is |
| 09:58:55 | proppy: | $('.jpoker_ptable_quit', element).click(function() { |
| 09:58:55 | proppy: | setTimeout(function() { |
| 09:58:55 | proppy: | window.top.os_poker_goto_lobby(); |
| 09:58:55 | proppy: | }, 50); |
| 09:58:56 | proppy: | }); |
| 09:58:58 | proppy: | 50 ms |
| 09:59:03 | dachary: | proppy: a queueRunning calling a callback function would be better |
| 09:59:24 | dachary: | proppy: ah, you're correct |
| 09:59:40 | proppy: | server.sendPacket({ type: 'PacketPokerTableQuit', game_id: game_id }); |
| 09:59:40 | proppy: | server.setTimeout(function() { |
| 09:59:41 | proppy: | server.queueRunning(function(server) { |
| 09:59:41 | proppy: | table.handler(server, game_id, { type: 'PacketPokerTableDestroy', |
| 09:59:41 | proppy: | game_id: game_id }); |
| 09:59:41 | proppy: | }); |
| 09:59:43 | proppy: | }, 1); |
| 09:59:51 | proppy: | that's current jpoker code for quitting the table |
| 10:00:08 | proppy: | there is not state for quitting the table |
| 10:00:23 | proppy: | so I believe queueRunning is useless |
| 10:00:43 | proppy: | dachary: I will had your comments to the ticket |
| 10:00:53 | dachary: | then 1000 ms is the only workaround proppy, right ? |
| 10:01:24 | dachary: | but.... |
| 10:01:34 | dachary: | it's not TableDestroy that should be called |
| 10:01:43 | proppy: | dachary: we could also patch upstream to add callback when player has exited the table |
| 10:02:14 | proppy: | dachary: PacketPokerTableDestroy is called for destroy #pokertable div |
| 10:02:16 | dachary: | proppy: PacketPokerTableQuit must be called |
| 10:02:29 | proppy: | dachary: PacketPokerTableQuit is sent to the server |
| 10:02:42 | proppy: | PacketPokerTableDestroy is dispatched to the handlers |
| 10:02:49 | proppy: | as if it was sent by the server |
| 10:02:51 | dachary: | hum |
| 10:02:57 | thy3 | joined #pokersource. |
| 10:03:12 | dachary: | then click on exit should call TableQuit and the TableDestroy handler should redirect |
| 10:03:18 | dachary: | that would work too don't you think ? |
| 10:03:20 | dachary: | proppy: ? |
| 10:04:25 | dachary: | Since there is "TableDestroy" callback it means a handler would have to be registered on the server for this specific purpose. But there already is an example in the opensocial jpoker gadget of Z2 I believe |
| 10:04:50 | proppy: | is there a tabledestroy callback ? |
| 10:05:53 | dachary: | Since there is no "TableDestroy" callback it means a handler would have to be registered on the server for this specific purpose. But there already is an example in the opensocial jpoker gadget of Z2 I believe |
| 10:05:58 | proppy: | there is a quit callback |
| 10:05:59 | dachary: | proppy: sorry for the typo |
| 10:05:59 | proppy: | quit: function(table) { |
| 10:05:59 | proppy: | }, |
| 10:06:22 | dachary: | proppy: yes, but it is called when the exit button is clicked |
| 10:06:25 | proppy: | which is called on table.destroy |
| 10:06:26 | proppy: | jpoker.plugins.table.callback.quit(table, packet); |
| 10:06:34 | dachary: | oh, really ? |
| 10:06:49 | dachary: | I forgot about that :-) |
| 10:06:52 | proppy: | yes, but since jpoker send itself PacketPokerTableDestroy |
| 10:06:55 | proppy: | to the handlers |
| 10:07:07 | proppy: | this has no relation with the handing of PacketPokerTableQuit |
| 10:08:15 | proppy: | dachary: so maybe what should be done |
| 10:08:31 | proppy: | is patch jpoker upstream to be statefull when quitting a table |
| 10:08:44 | proppy: | for the queueRunning(tabledestroy) to have a purpose |
| 10:09:43 | proppy: | dachary: i.e instead of sending PacketPokerTableQuit directory to the server |
| 10:10:02 | dachary: | proppy: this makes sense |
| 10:10:18 | proppy: | dachary: #quit button should call server.tableQuit |
| 10:10:32 | proppy: | tableQuit should setState('leaving table') |
| 10:10:46 | proppy: | and gets back to running when receiving PacketPokerPlayerLeave |
| 10:10:50 | proppy: | dachary: do you agree ? |
| 10:10:54 | Sp4rKy: | dachary: do you confirm there are only 4 existing backups for rentre lvs : http://trac.fsffrance.org/wiki/RentreMigrationPlan?action=diff&version=14&old_version=12 |
| 10:11:00 | dachary: | proppy: there must be a better workaround. Since all packets are sent in sequence. |
| 10:11:31 | proppy: | dachary: even if the packet are send in sequence, TableDestroy is not send to the server, nor by the server |
| 10:11:43 | proppy: | it is sent from jpoker to jpoker |
| 10:12:39 | proppy: | dachary: is there a garanti when we send a xhr to the server, that it is processed before we redirect ? |
| 10:12:44 | dachary: | proppy: let's discuss this some other time, I think we can do better than 1s but it needs thinking. If it was possible to hook a function that is called when TableQuit has been successfully sent, it would be enough. We need no other confirmation but the successfull completion of the XHR call that sends TableQuit. |
| 10:13:28 | dachary: | proppy: when the XHR calls the success callback, it means the server completed the processing, yes. |
| 10:13:50 | proppy: | dachary: yes, but there is no relation between tabledestroy, and xhr success callback yet |
| 10:14:05 | dachary: | Yes. |
| 10:14:06 | proppy: | 50 ms is not enought to garanty that |
| 10:14:12 | dachary: | yes. |
| 10:14:19 | proppy: | and 1000ms might not be enought if there is lag ;) |
| 10:14:25 | proppy: | I agree on discussing this later |
| 10:15:08 | proppy: | updated http://drupal-dev.pokersource.info/trac/ticket/155#comment:1 |
| 10:17:27 | dachary: | Sp4rKy: checking |
| 10:17:28 | proppy: | mongolito404: ping |
| 10:17:36 | proppy: | about "sit" notification |
| 10:17:58 | proppy: | os_poker expect that jpoker send the list of the players currently sitting at the table |
| 10:18:44 | proppy: | maybe it should send the game_id instead |
| 10:19:00 | proppy: | and I believe os_poker has already methods to check the players at the table |
| 10:19:06 | dachary: | Sp4rKy: pokme backup was made by mornifle, that explains why he did not follow the usual conventions |
| 10:19:22 | Sp4rKy: | dachary: ok |
| 10:19:32 | Sp4rKy: | dachary: do you remember the date of this backup ? |
| 10:19:43 | Sp4rKy: | dachary: so that I can move it |
| 10:19:46 | dachary: | no, I don't |
| 10:20:04 | dachary: | I guess the modification date of var/log/syslog is the best clue |
| 10:20:27 | Sp4rKy: | hu ? |
| 10:20:59 | dachary: | if you want to know when the backup was done, looking at the var/log/syslog last modified time stamp will tell you |
| 10:21:52 | Sp4rKy: | ahhh |
| 10:21:58 | Sp4rKy: | var/log/syslog into the backup :) |
| 10:22:06 | dachary: | Sp4rKy: yes |
| 10:22:54 | Sp4rKy: | 2009-04-16 |
| 10:24:07 | mongolito404: | proppy: Yes, os_poker can check the player at the table |
| 10:24:07 | dachary: | Sp4rKy: the fact that there are very few backups for rentre tells me either they are within another backup (did you look into the rentre lv ?) or on another disk |
| 10:24:26 | proppy: | mongolito404: I will just fix poker.js to works with current os_poker code |
| 10:24:36 | proppy: | and will fill a ticket for fixing os_poker later |
| 10:24:42 | mongolito404: | proppy: ok |
| 10:26:21 | Sp4rKy: | dachary: I looked into the rentre lv, there are only rsync from rentre, but I can't find the lvs |
| 10:27:00 | dachary: | Sp4rKy: it's weird that it is 51GB big |
| 10:27:37 | dachary: | Sp4rKy: I will try to find the disk where these backups live |
| 10:27:45 | mongolito404: | proppy, dachary: While working on #144, I see that the user Profile has two field (first and last names) that are never displayed or used by os_poker or std. Drupal pages. I believe these fields ares a requirment of Shindig-Integrator. Si these fields being 'invisible' on the website is not an issue. right ? |
| 10:28:32 | dachary: | Sp4rKy: in any case I confirm they are not anywhere easy to find and you can create LV on dirtychip. Was it the kind of answer you expected ? |
| 10:29:06 | proppy: | mongolito404: yes shindig integrator use theme for opensocial calls like getPersons |
| 10:29:16 | proppy: | mongolito404: and since shindig_integrator query the db directlry |
| 10:29:32 | proppy: | I believe there is no arm in "hidding" them |
| 10:30:03 | dachary: | proppy: mongolito404 IE8 crash reported. I thought it was supposed to be fixed by now. I'll get more information. |
| 10:31:55 | Sp4rKy: | dachary: this one, that was just to be sure they are on some location I was not aware of |
| 10:32:59 | Sp4rKy: | dachary: rentre lv is 51G big, but only 11G are used |
| 10:33:11 | proppy: | mongolito404: we fixed a bug in ie8 vista |
| 10:33:16 | proppy: | http://drupal-dev.pokersource.info/trac/ticket/141 |
| 10:33:24 | proppy: | maybe ie8 xp is still impatced |
| 10:33:30 | proppy: | as shown on #141 comments |
| 10:34:27 | proppy: | mongolito404: about checkRewards/os_poker_sit I will pass, lists of seats |
| 10:34:33 | proppy: | an array of 10 elements |
| 10:34:39 | proppy: | with player_serial in sit position |
| 10:34:40 | proppy: | like |
| 10:34:51 | proppy: | [42, null, null, 45, 58, null, ...] |
| 10:35:02 | proppy: | I believe this will work with current implementation of checkRewards |
| 10:35:10 | mongolito404: | couldn't you filter the array ? |
| 10:35:13 | proppy: | foreach ($buddies as $buddy) |
| 10:35:13 | proppy: | { |
| 10:35:13 | proppy: | if (in_array($buddy, $targets)) |
| 10:35:14 | proppy: | { |
| 10:35:34 | proppy: | mongolito404: do you want me to filter the array for the main player serial too ? |
| 10:35:49 | proppy: | because the current os_poker_sit event has 2 args |
| 10:35:54 | proppy: | player_serial, and player_at_tables |
| 10:36:00 | mongolito404: | proppy: No, just filter the array fro null/undefined |
| 10:36:06 | proppy: | so I believe it except player_at_tables not to contain player_serial |
| 10:36:06 | proppy: | ok |
| 10:36:18 | proppy: | so player_at_tables will contains player_serial |
| 10:36:29 | proppy: | but since a player can't be a buddy with itself |
| 10:36:32 | mongolito404: | That way, the Drupal code don't have to deal with them. The current code doesn't have too but we don't know about the future. |
| 10:36:33 | proppy: | I believe there is no arm :) |
| 10:36:47 | dachary: | http://drupal-dev.pokersource.info/trac/ticket/156 mongolito404 proppy |
| 10:38:07 | mongolito404: | hoo crap, now I need a vista VM :( |
| 10:38:24 | proppy: | dachary: please check that http://drupal-demo.pokersource.info/pb_jpoker/test-poker-opensocial.html |
| 10:38:35 | proppy: | and http://drupal-demo.pokersource.info/pb_jpoker/test-poker.html are green on ie8 |
| 10:38:45 | proppy: | or ask the reporter to do so |
| 10:38:50 | proppy: | it will provide usefull information |
| 10:39:20 | proppy: | dachary: also please qualify http://drupal-dev.pokersource.info/trac/ticket/156 with the OS version |
| 10:39:32 | dachary: | proppy: thanks |
| 10:41:02 | dachary: | mongolito404: do you confirm it works for you on IE8 / XP ? |
| 10:41:17 | julez | quit IRC (Remote closed the connection). |
| 10:41:47 | mongolito404: | dachary: No it doesn't. As soon as I get the jpoker gadget to be displayed, it crash IE8 in my XP VM |
| 10:42:05 | dachary: | mongolito404: is there a ticket for this ? |
| 10:42:19 | dachary: | proppy: ? |
| 10:42:23 | mongolito404: | yes #141 |
| 10:42:41 | proppy: | (10:32:44 AM) proppy: mongolito404: we fixed a bug in ie8 vista |
| 10:42:41 | proppy: | (10:32:49 AM) proppy: http://drupal-dev.pokersource.info/trac/ticket/141 |
| 10:42:41 | proppy: | (10:32:57 AM) proppy: maybe ie8 xp is still impatced |
| 10:42:42 | proppy: | dachary: ^ |
| 10:42:49 | dachary: | ok |
| 10:42:59 | proppy: | we don't know if it is specific to xp in a vm |
| 10:43:07 | proppy: | we need someone to test with a real xp |
| 10:44:41 | dachary: | proppy: did you jslint everything ? |
| 10:44:52 | proppy: | dachary: yes |
| 10:44:53 | dachary: | proppy: I mean all the JS that was home made ? |
| 10:44:57 | proppy: | as shown in #141 comments |
| 10:45:07 | proppy: | I didn't checked os_poker js thought |
| 10:45:44 | dachary: | proppy: please do |
| 10:45:53 | mongolito404: | proppy: AFAIK, os_poker's js have not be checked with jslint (something that I will do when I start to work on #156) |
| 10:46:00 | dachary: | one error is enough to block all |
| 10:46:08 | guyvdb | quit IRC ("Leaving."). |
| 10:46:11 | dachary: | it's a good lead |
| 10:46:12 | julez | joined #pokersource. |
| 10:47:12 | dachary: | it would also be consistent with #156 (i.e. crash when clicking somewhere, therefore when loading new JS code) |
| 10:48:33 | mornifle | joined #pokersource. |
| 10:56:42 | proppy: | reopened http://drupal-dev.pokersource.info/trac/ticket/153#comment:3 |
| 10:56:54 | proppy: | and added poker/pokeropensocial fixes |
| 10:57:08 | proppy: | mongolito404: should I pull your changes and test on drupal-kez before updating drupal-demo ? |
| 10:57:33 | mongolito404: | proppy: yes |
| 10:59:08 | proppy: | checked that Newcomeer is displayed |
| 10:59:35 | proppy: | mongolito404: should I also check rewards18 ? |
| 11:00:01 | mongolito404: | proppy: Yes |
| 11:00:33 | proppy: | mongolito404: is the table the only way I can add a buddy ? |
| 11:02:54 | proppy: | mongolito404: rewards18 is not set |
| 11:03:04 | proppy: | when joining a table with a friend on it |
| 11:03:48 | proppy: | mongolito404: how ok, that's because os_poker_sit only expect players_at_table arg |
| 11:03:51 | proppy: | and not serial |
| 11:03:59 | proppy: | fixing poker.opensocial code |
| 11:06:54 | proppy: | should be fixed with http://drupal-dev.pokersource.info/trac/ticket/153#comment:4 |
| 11:08:16 | proppy: | mongolito404: rewards18 is still not set, even if os_poker_sit is called with good argument |
| 11:08:24 | proppy: | i will closed #153 and fill a new bug report |
| 11:08:30 | mongolito404: | proppy: ok |
| 11:10:06 | proppy: | mongolito404: filled http://drupal-dev.pokersource.info/trac/ticket/157 |
| 11:10:17 | proppy: | mongolito404: did you push your changes on drupal-demo ? |
| 11:11:17 | proppy: | it seems so |
| 11:11:37 | mongolito404: | proppy: YEs I did |
| 11:12:44 | proppy: | dachary: drupal-demo updated with #153 fixes |
| 11:13:18 | dachary: | proppy: thanks |
| 11:13:31 | dachary: | proppy: tryin |
| 11:13:33 | dachary: | g |
| 11:14:16 | proppy: | dachary: be sure to have you cache cleaned |
| 11:14:52 | proppy: | mongolito404: do you want me to jslint os_poker or will you ? |
| 11:16:37 | guyvdb | joined #pokersource. |
| 11:17:09 | mongolito404: | proppy: You can do it since I'm working on #144 which is totally unrelated |
| 11:18:49 | dachary: | proppy: mongolito404 I got the problem does this ring a bell ? the screenshot in PM ? |
| 11:18:57 | dachary: | got it after joining a table |
| 11:19:35 | proppy: | dachary: what is the pb ? |
| 11:19:39 | proppy: | dachary: signup is not displayed ? |
| 11:19:49 | dachary: | proppy: look at the URL |
| 11:19:57 | proppy: | dachary: if you try to join a table signup is not displayed |
| 11:20:00 | dachary: | I got this after joining a table |
| 11:20:06 | proppy: | dachary: when you try to access a table directly |
| 11:20:08 | dachary: | instead of the table |
| 11:20:12 | proppy: | dachary: it means you're not authed to drupal |
| 11:20:25 | dachary: | proppy: could you try to signup + join a table please ? |
| 11:20:31 | proppy: | dachary: if you're not login into drupal, this page will be displayed |
| 11:20:45 | dachary: | if it works for you I'll dig further before anoying you proppy |
| 11:21:06 | proppy: | dachary: I just wanted to be sure we understand each other |
| 11:21:23 | proppy: | because saq reported as a bug, the fact that the signup form is not displayed when joining a table throught url |
| 11:21:27 | proppy: | and that's not a bug AFAIK |
| 11:22:00 | proppy: | dachary: I'm sit on Antigua |
| 11:22:01 | proppy: | with a new user |
| 11:22:06 | proppy: | on drupal-demo |
| 11:22:12 | dachary: | ok, thanks |
| 11:22:20 | dachary: | sorry for the noise |
| 11:22:24 | proppy: | np |
| 11:23:23 | dachary: | proppy: you got your newcomer reward ? |
| 11:23:49 | proppy: | dachary: yes I did |
| 11:25:12 | proppy: | dachary: updated http://drupal-dev.pokersource.info/trac/ticket/153 with a screenshot |
| 11:25:37 | mongolito404: | About dachary's bug (screenshot in PM), if I understand correctly, this is not a bug if the signup form is not displayed but the expected behavior when open a table link when not logged in ? |
| 11:25:50 | dachary: | proppy: I clicked on "exit" and was logged out ... |
| 11:26:20 | dachary: | mongolito404: there seems to be spontaneous logout, does it happen for you too ? |
| 11:26:34 | proppy: | dachary: I clicked on exit and was not logged out |
| 11:26:36 | dachary: | if it's just me I'll restart iceweasel |
| 11:26:42 | proppy: | I got back to http://drupal-demo.pokersource.info/drupal6/ and the lobby is displayed |
| 11:26:53 | dachary: | ok |
| 11:27:00 | bruno|taf | joined #pokersource. |
| 11:27:47 | dachary: | proppy: I confirm the newcomer reward works, proppy. Thanks. |
| 11:28:46 | mongolito404: | dachary: What do you mean by "there seems to be spontaneous logout" ? You get logged out from the site ? |
| 11:29:42 | dachary: | yes, twice, but it might be my navigator was fucked up. I've restarted it and I'll file a proper report if it happens again. |
| 11:29:52 | dachary: | proppy: you're JSlinting ? |
| 11:30:15 | proppy: | dachary: not yet |
| 11:45:07 | proppy: | updated http://drupal-dev.pokersource.info/trac/ticket/156#comment:1 |
| 11:46:20 | proppy: | mongolito404: jslint'ed os_poker's js |
| 11:47:41 | proppy: | dachary: I still get a crash on my vm, when I get to lobby |
| 11:47:51 | proppy: | (even before clicking to profile) |
| 11:50:15 | proppy: | http://drupal-dev.pokersource.info/trac/ticket/156#comment:2 updated |
| 11:50:44 | proppy: | dachary: could you run http://drupal-dev.pokersource.info/drupal6/sites/all/modules/os_poker/tests/js/test.html on ie ? |
| 11:51:27 | mongolito404: | proppy: This is still #141, not #156 |
| 11:51:46 | proppy: | mongolito404: yes |
| 11:51:54 | proppy: | I can't reproduce #156 because of #141 |
| 11:51:59 | dachary: | proppy: http://drupal-dev.pokersource.info/trac/ticket/156#comment:3 |
| 11:52:19 | mongolito404: | #141 -> crash on the lobby or at table (when jpoker gadget is displayed) in IE8/XP |
| 11:52:20 | mongolito404: | #156 -> crash when clicking profile in a working lobby in IE8/vista |
| 11:52:21 | proppy: | #141 is easy to reproduce just go to http://drupal-demo.pokersource.info/pb_jpoker/test-poker-opensocial.html |
| 11:52:56 | proppy: | dachary: you're reporting about #141 in #156 |
| 11:53:08 | dachary: | proppy: sorry |
| 11:53:21 | dachary: | I will move my comments |
| 11:53:44 | proppy: | dachary: could you also add plateform information ? |
| 11:53:46 | proppy: | which windows version |
| 11:54:44 | proppy: | updated http://drupal-dev.pokersource.info/trac/ticket/141#comment:10 |
| 11:55:07 | proppy: | mongolito404: do you have a vista vm ? |
| 11:55:33 | proppy: | dachary: you should not be able to reproduce #156 on xp |
| 11:55:35 | proppy: | because of #141 |
| 11:56:56 | proppy: | dachary: when you reported #156 did it happens with xp or vista ? |
| 11:57:19 | dachary: | I don't know yet |
| 11:57:33 | dachary: | http://drupal-dev.pokersource.info/trac/ticket/141#comment:11 |
| 11:57:47 | dachary: | proppy: I moved the comments from 156 to 141, sorry about the confusion |
| 12:04:06 | dachary: | proppy: http://drupal-dev.pokersource.info/trac/ticket/141#comment:12 |
| 12:06:13 | proppy: | dachary: in a vm or in a real xp ? |
| 12:07:21 | dachary: | proppy: real XP |
| 12:08:29 | proppy: | dachary: thanks for the confirmation |
| 12:10:05 | dachary: | http://drupal-dev.pokersource.info/drupal6/sites/all/modules/os_poker/tests/js/test.html all green on IE8 / XP |
| 12:12:46 | dachary: | proppy: you can use browsershots with account user = loic, password = your usual |
| 12:13:06 | dachary: | this a paid for account good for one month |
| 12:13:14 | dachary: | proppy: it might help |
| 12:13:22 | dachary: | but probably not for the crash :-) |
| 12:13:44 | dachary: | proppy: http://drupal-dev.pokersource.info/drupal6/sites/all/modules/os_poker/tests/js/test.html all green on IE8 / XP + VISTA |
| 12:13:57 | proppy: | dachary: what about test-poker.html ? |
| 12:14:32 | dachary: | it's all green too, I'll ask again |
| 12:14:43 | dachary: | proppy: full URL please ? |
| 12:15:09 | proppy: | (10:37:58 AM) proppy: dachary: please check that http://drupal-demo.pokersource.info/pb_jpoker/test-poker-opensocial.html |
| 12:15:09 | proppy: | (10:38:09 AM) proppy: and http://drupal-demo.pokersource.info/pb_jpoker/test-poker.html are green on ie8 |
| 12:15:12 | proppy: | dachary: ^ |
| 12:16:11 | dachary: | proppy: maybe you can double check by running it on browsershots.org ? |
| 12:16:26 | proppy: | dachary: it's green on my vm |
| 12:16:43 | proppy: | dachary: I just wanted to be sure it's green for the people who had #156 bug |
| 12:16:47 | proppy: | (vista, xp ?) |
| 12:16:54 | dachary: | both |
| 12:17:07 | proppy: | vista has #156 ? |
| 12:17:10 | dachary: | I asked for re-confirmation because it was unclear |
| 12:17:30 | dachary: | proppy: I did not ask specifically |
| 12:17:34 | proppy: | oh ok |
| 12:18:00 | dachary: | #156 happened on IE8 / XP |
| 12:18:21 | dachary: | proppy: could you please confirm you have access to browsershots.org with my account ? |
| 12:18:41 | proppy: | dachary: right now ? |
| 12:19:11 | proppy: | dachary: I can |
| 12:19:11 | proppy: | Hi Loic! This is your private profile page. Only you can see it. |
| 12:19:19 | proppy: | back to #141 |
| 12:21:07 | dachary: | ok |
| 12:22:18 | dachary: | http://drupal-demo.pokersource.info/pb_jpoker/test-poker.html green on IE8 / XP |
| 12:24:12 | proppy: | I found the crashing line |
| 12:24:12 | proppy: | $('').attr('href', os_poker_skin).insertAfter('link:last'); |
| 12:24:36 | dachary: | http://browsershots.org/http://drupal-demo.pokersource.info/pb_jpoker/test-poker.html |
| 12:25:08 | dachary: | http://drupal-demo.pokersource.info/pb_jpoker/test-poker.html green on IE8 + IE7 / XP |
| 12:25:52 | proppy: | dachary: I found the line that trigger the crash |
| 12:25:56 | dachary: | proppy: there is a missing /> right ? |
| 12:25:57 | proppy: | should I comment it on drupal-demo ? |
| 12:26:12 | proppy: | where do you see a missing ? |
| 12:26:16 | dachary: | proppy: understood but I have buffered questions and the answers come after ;-) |
| 12:26:28 | dachary: | |
| 12:26:31 | dachary: | |
| 12:26:32 | dachary: | ? |
| 12:26:44 | proppy: | I thought jquery added the checking |
| 12:26:53 | dachary: | maybe it does |
| 12:27:24 | dachary: | do you see another reason why it should crash ? |
| 12:27:43 | proppy: | $('').attr('href', os_poker_skin).insertAfter('link:last'); |
| 12:27:52 | proppy: | also trigger the crash |
| 12:28:01 | proppy: | dachary: I'm clueless about the reason of this crash |
| 12:28:04 | proppy: | I'll investigate |
| 12:28:51 | dachary: | if you remove this, does it work ? |
| 12:29:00 | dachary: | proppy: ? |
| 12:29:08 | proppy: | yes |
| 12:29:14 | proppy: | if I remove the line it works |
| 12:29:24 | proppy: | that's why I asked if I should update drupal-demo |
| 12:29:30 | dachary: | what is os_poker_skin value ? |
| 12:29:40 | proppy: | checking if the selector is buggy |
| 12:29:44 | dachary: | I'm trying to figure out if it will impact the looks |
| 12:30:34 | dachary: | proppy: it might be a selector that works with jquery-1.3 but not jquery-1.2 which would explain why we're experiencing this problem now |
| 12:31:16 | proppy: | $('link:last') is not to blame |
| 12:31:26 | proppy: | .attr('href, os_poker_skin) trigger the crash |
| 12:31:33 | proppy: | trying to find out os_poker_skin value |
| 12:32:41 | proppy: | os_poker_skin is os_poker_skin "http://host/drupal/skin.css" String |
| 12:33:21 | dachary: | ? |
| 12:33:29 | dachary: | not very useful is it :-) |
| 12:34:30 | mongolito404: | You mean that adding the CSS loading element crash IE8 ? |
| 12:34:59 | dachary: | mongolito404: no, I mean the http://host/drupal/skin.css URL will always be not found. |
| 12:35:09 | dachary: | proppy: unless you mean "host" as a placeholder |
| 12:35:31 | proppy: | yes but it should not crash ie |
| 12:35:35 | dachary: | mongolito404: is it a knowsn IE8 limitation ? |
| 12:35:37 | proppy: | it should trigger a 404 at last |
| 12:35:46 | proppy: | dachary: if I put a real url there it is crashing too |
| 12:35:50 | proppy: | mongolito404: yes |
| 12:36:03 | proppy: | dachary: and that's not only happening in the tests |
| 12:36:09 | dachary: | proppy: it tells us that you can comment out the line without impacting the looks, therefore please do it on drupal-demo |
| 12:36:34 | proppy: | dachary: why does it tell us we can comment out the line without impacting the looks ? |
| 12:36:51 | dachary: | because it does not load anything because it loads a 404 URL |
| 12:36:53 | proppy: | http://host/drupal/skin.css is only in the test |
| 12:36:58 | dachary: | ah |
| 12:36:58 | proppy: | dachary: ^ |
| 12:37:06 | proppy: | dachary: I'm reproducing the probleme in the test |
| 12:37:10 | proppy: | so I'm debugging from here |
| 12:37:11 | dachary: | ok |
| 12:37:37 | dachary: | what's the value of the variable in the real world ? |
| 12:39:20 | proppy: | http://drupal-kez.pokersource.info/drupal6/?q=poker/skin.css |
| 12:39:27 | proppy: | dachary: ok I got the bug |
| 12:39:56 | proppy: | $("").attr("href", "foo.css").insertAfter('link:last'); crashed |
| 12:40:10 | proppy: | $("").insertAfter('link:last').attr("href", "foo.css"); don't crash |
| 12:41:17 | dachary: | interesting |
| 12:41:42 | dachary: | and does it actually load foo.css ? |
| 12:42:17 | proppy: | http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html |
| 12:42:20 | proppy: | green on ie8/xp |
| 12:42:29 | proppy: | dachary: foo.css is 404 |
| 12:43:02 | proppy: | but it is inserted into the dom |
| 12:43:07 | proppy: | like http://host/drupal/skin.css |
| 12:43:09 | mongolito404: | Make sense. When doing $("").attr("href", "foo.css").insertAfter('link:last'), you set the href of the DOM element before attaching it to the current document. If when handling setting the href attribute of a link DOM element, IE8's code assume the element is part of the document then it crash when it doesn't. |
| 12:43:12 | proppy: | and test check after this value |
| 12:43:18 | dachary: | proppy: do you want me to ask for confirmation that http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html works ? |
| 12:43:27 | proppy: | dachary: sure |
| 12:43:34 | proppy: | it works in my vm thought |
| 12:43:36 | proppy: | I'll commit the fix |
| 12:43:52 | proppy: | we should also audit js code for similar issue |
| 12:44:31 | dachary: | mongolito404: we would know if it was proprietary software. It looks like a plausible theory though. |
| 12:45:33 | proppy: | dachary: +not |
| 12:46:02 | dachary: | proppy: injection of is uncommon |
| 12:46:10 | dachary: | it's easy to grep |
| 12:46:14 | dachary: | and I agree with you |
| 12:47:40 | mongolito404: | dachary: (unrelated to the JS isseus), I assume there is no additional cache mechanism on drupal-404. Nither on PHP, neither on the DB ? |
| 12:48:21 | mongolito404: | Because I get weird results when manually updating the profile_values table. |
| 12:49:36 | dachary: | shindig has a cache |
| 12:49:44 | dachary | filled http://drupal-dev.pokersource.info/trac/ticket/158 |
| 12:50:21 | dachary: | mongolito404: you can clear the shindig cache with rm -fr /tmp/shindig/ |
| 12:50:35 | dachary: | I'm not aware of any other cache |
| 12:51:18 | proppy: | marked #141 as fixed |
| 12:51:24 | mongolito404: | #158 -> item are not only imported but also editable from a Web GUI |
| 12:51:27 | proppy: | attached a xp screenshot http://drupal-dev.pokersource.info/trac/ticket/141 |
| 12:51:37 | proppy: | dachary: should I update drupal-demo with the fix ? |
| 12:51:50 | dachary: | proppy: yes please |
| 12:52:09 | proppy: | dachary: about auditing the code, I believe this may also fail with non element |
| 12:52:15 | dachary: | did you try http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html on browsershots ? |
| 12:52:24 | proppy: | like any element that you are editing the properties before inserting to the dom |
| 12:52:28 | proppy: | dachary: non |
| 12:52:39 | proppy: | dachary: I tried it on xp vm |
| 12:53:01 | mongolito404: | It also works for me in my XP Vm |
| 12:53:05 | dachary: | if it's all green you get a valuable information. If it's not, it's probably because it's taking too long too run. |
| 12:53:06 | proppy: | dachary: updated drupal demo with the fix |
| 12:53:17 | proppy: | dachary: be sure to clean/refresh your cash before testing |
| 12:53:27 | dachary: | s/cash/cache/ |
| 12:53:42 | dachary: | => lunch |
| 12:54:00 | dachary: | proppy: mongolito404 thanks for the emergency fix & quick reaction |
| 12:54:44 | dachary: | http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html now shows all green on IE 6, IE 7 and IE 8. |
| 12:56:32 | proppy: | I don't grep other attr() insert/append() pattern in the code |
| 12:56:50 | proppy: | not for me :) |
| 12:56:50 | proppy: | http://browsershots.org/http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html |
| 13:32:44 | thy3 | quit IRC ("Leaving."). |
| 14:36:15 | mongolito404: | Yeah, another WTF in user profile data handling... |
| 15:00:26 | proppy: | back on http://drupal-dev.pokersource.info/trac/ticket/127 |
| 15:01:51 | proppy: | checking on_exit is called before xhr error handlers |
| 15:08:00 | mornifle | quit IRC (Read error: 60 (Operation timed out)). |
| 15:11:23 | proppy: | onbeforeunload seems the way to go |
| 15:11:27 | proppy: | (tiddlywiki use it) |
| 15:12:51 | mongolito404: | proppy: beware, this is a not public-specified event. It has been introduced by MS and copied by other browser (accordign to https://developer.mozilla.org/en/DOM/window.onbeforeunload) |
| 15:13:08 | proppy: | yes I'm reading it too |
| 15:13:16 | proppy: | I wonder if jquery has some event for it |
| 15:16:01 | proppy: | trying 'unload' event in jquery |
| 15:16:15 | proppy: | and checking it is called before ajax handlers are interrupted by redirect |
| 15:17:05 | proppy: | it is called after :( |
| 15:21:01 | proppy: | ah onbeforeunload is for displaying a string ! |
| 15:21:51 | dachary: | proppy: mongolito404 IE8 fix confirmed to work, thanks |
| 15:30:33 | proppy: | ah actually according to drupal folks |
| 15:30:37 | proppy: | that's a firefox bug |
| 15:30:38 | proppy: | https://bugzilla.mozilla.org/show_bug.cgi?id=488605 |
| 15:31:49 | proppy: | firefox returns error 0 if the ajax call are interrupted |
| 15:31:49 | proppy: | http://hg.mozilla.org/mozilla-central/rev/151522b6da28 |
| 15:32:21 | proppy: | drupal actually ignore all error "0" |
| 15:32:22 | proppy: | http://drupal.org/node/634628 |
| 15:46:16 | proppy: | I think that ingnoring Error 0 is fine |
| 15:46:25 | proppy: | since it is a firefox only issue |
| 15:48:43 | proppy: | marked http://drupal-dev.pokersource.info/trac/ticket/127 as fixed |
| 15:49:46 | proppy: | no more alert on drupal-kez.pokersource.info |
| 15:50:14 | proppy: | dachary: could I update drupal-demo and remove uncomment error handling ? |
| 15:54:13 | mongolito404: | proppy: The jpoker gadget get the country property of the user (profile_country) from shindig right ? |
| 15:54:20 | proppy: | mongolito404: yes |
| 15:54:37 | proppy: | I patched shindig to add support for addresses |
| 15:54:38 | mongolito404: | proppy: Currently this is a string displayed as passed to the gadget ? |
| 15:54:52 | proppy: | mongolito404: http://drupal.org/node/673756 |
| 15:55:25 | mongolito404: | What format is this string supposed to have ? |
| 15:56:14 | proppy: | mongolito404: the country format ? |
| 15:56:18 | mongolito404: | Yes |
| 15:56:26 | proppy: | there is not format it is displayed as this in jpoker |
| 15:56:41 | mongolito404: | Ok, becaise I'm changing this while implementing #144 |
| 15:57:00 | mongolito404: | The value will be the country code (ISO code in 2 char) |
| 15:57:17 | mongolito404: | If this doesn't break the OpenSocial-ness of the value |
| 15:58:29 | proppy: | http://wiki.opensocial.org/index.php?title=Opensocial.Address_%28v0.8%29 |
| 15:58:39 | proppy: | opensocial.Address.Field.COUNTRY The country, specified as a string. This field may be used interchangeably with the string 'country'. |
| 15:59:17 | proppy: | mongolito404: so it is ok for the poker gadget to display the country as an ISO code ? |
| 15:59:45 | mongolito404: | proppy: Not, my understanding is that it should display the country in the user language |
| 16:00:18 | proppy: | oh I understand |
| 16:00:23 | proppy: | so it will be a translation issue then |
| 16:00:26 | mongolito404: | 'The country, specified as a string' what a lousy specs. |
| 16:01:05 | proppy: | mongolito404: http://wiki.opensocial.org/index.php?title=Opensocial.Person_%28v0.8%29#opensocial.Person.Field.SEXUAL_ORIENTATION :) |
| 16:01:16 | mongolito404: | Could be interpreted as a) the country name in English, b) the country name in the Person language c) The country name in the country language (so much for Belgium), d) Any std. country code |
| 16:02:07 | dachary: | mongolito404: ahahaha |
| 16:02:53 | dachary: | mongolito404: your understanding is correct. But everyone will be happy if it's done in the most straightforward drupal supported way |
| 16:03:30 | proppy: | mongolito404: for a) d) it could uses gettext for gadget side translation |
| 16:03:50 | proppy: | if you want to display it like b) or c) |
| 16:03:58 | proppy: | but I'm not sure I'm understanding the rational of this |
| 16:04:18 | proppy: | are you talking about the value of the field as exposed by opensocial |
| 16:04:30 | proppy: | of the value of the field as seens by the user in the small profile ? |
| 16:05:58 | mongolito404: | I4m speaking of the field as stored by Drupal and exposed to OS gadgets |
| 16:06:22 | mongolito404: | There is no Drupal Way, the field is a textfield and I can store whatever I want in it. I just find it ackwad and error prone to store the country name. Storing the country name encourage consumer to use it as-is and not to think about location issue. |
| 16:06:45 | proppy: | filled http://drupal-dev.pokersource.info/trac/ticket/159 |
| 16:19:15 | mongolito404: | dachary: The current widget for the country filed in the buddy search is a textfield. Is it ok to use a dropdown ? |
| 16:20:48 | proppy: | working on #103 |
| 16:23:02 | proppy: | moved #159 to Poker http://drupal-dev.pokersource.info/trac/ticket/159#comment:1 |
| 16:25:28 | proppy: | dachary: I can't reproduce http://drupal-dev.pokersource.info/trac/ticket/103 |
| 16:25:36 | proppy: | the rebuy button is shown |
| 16:25:38 | proppy: | I'm confused :) |
| 16:25:47 | proppy: | after loosing allin, I can click rebuy |
| 16:26:14 | proppy: | trying harder |
| 16:27:40 | dachary: | proppy: let me try |
| 16:29:35 | dachary: | proppy: where can I play with you ? |
| 16:29:43 | proppy: | dachary: http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=435 |
| 16:29:47 | dachary: | k |
| 16:31:55 | proppy: | filled http://drupal-dev.pokersource.info/trac/ticket/160 |
| 16:32:00 | dachary: | proppy: please call ? |
| 16:32:18 | proppy: | dachary: I don't see you |
| 16:32:27 | dachary: | Antigua ? |
| 16:32:44 | dachary: | you left |
| 16:32:44 | proppy: | because of #160 |
| 16:32:47 | proppy: | refreshing the browser |
| 16:33:15 | proppy: | 36o |
| 16:33:32 | dachary: | i have no rebuy button |
| 16:33:47 | proppy: | I see you with still 10 in money |
| 16:33:55 | dachary: | oh |
| 16:33:56 | dachary: | yes |
| 16:34:06 | dachary: | it's a known problem |
| 16:34:09 | dachary: | shoot |
| 16:34:18 | dachary: | I don't have enough to buyin |
| 16:34:34 | dachary: | but the rebuy button should show because I can rebuy |
| 16:35:00 | proppy: | dachary: I tried excatly the same with 2 browsers and the rebuy button was shown |
| 16:35:01 | dachary: | jpoker is supposed to display a buyin button whenever you can rebuy |
| 16:35:05 | dachary: | and hide it when you cannot |
| 16:35:21 | proppy: | I'll post a screenshot |
| 16:35:23 | dachary: | I doubt you had exactly the same case : i'm not broke |
| 16:35:33 | proppy: | dachary: yes, but it was displayed when I was broke with another borwser |
| 16:35:42 | proppy: | therefore I'm confused |
| 16:36:03 | dachary: | there are 3 cases proppy |
| 16:36:16 | dachary: | a) you are broke and the button shows (what you see) |
| 16:36:49 | dachary: | b) you are not broke and you don' thave enough to buy in : the button does not show although it should |
| 16:37:19 | dachary: | c) you are not broke and you have enough to buy in : the button should show if you don't have more chips than the maximum buyin |
| 16:37:26 | dachary: | proppy: is this making sense ? |
| 16:37:47 | proppy: | I think c) does work |
| 16:38:04 | proppy: | I'm playing with 2 browser and rebuy botton are shown |
| 16:38:13 | proppy: | so I guess #103 is about b) |
| 16:38:21 | dachary: | proppy: does exit send TableQuit on drupal-kez ? |
| 16:39:10 | proppy: | dachary: yes, but #155 |
| 16:39:41 | dachary: | and you did not change the timeout to 1s ? |
| 16:39:43 | dachary: | proppy: ^ |
| 16:39:49 | dachary: | I'm stuck at the table |
| 16:39:56 | dachary: | I click exit and it won't quit |
| 16:40:15 | dachary: | that would suggest you did not change the timeout |
| 16:40:20 | proppy: | I'll try to change it to 1 seconds |
| 16:40:31 | dachary: | thanks |
| 16:40:36 | proppy: | in my past experience it didn't fix the issue |
| 16:40:48 | dachary: | it's a loosy workaround at best |
| 16:41:32 | proppy: | updated http://drupal-dev.pokersource.info/trac/ticket/155#comment:2 |
| 16:42:44 | dachary | clearing cache & reloading |
| 16:43:02 | proppy: | I was broke |
| 16:43:07 | proppy: | sitin button is shown |
| 16:43:10 | proppy: | clicking it does nothing |
| 16:43:13 | proppy: | rebuy button is shown |
| 16:43:27 | proppy: | if clicking it with auto_sitin checkbox checked |
| 16:43:37 | proppy: | it rebuy + sit you in |
| 16:43:57 | dachary: | proppy: could you please remove the redirect ? not schedule it at all ? |
| 16:44:16 | proppy: | if you don't check the checkboxe you're stuck |
| 16:44:19 | dachary: | I would like to see if the TableQuit really is sent |
| 16:44:41 | proppy: | dachary: done |
| 16:45:08 | dachary: | ah |
| 16:45:33 | dachary: | proppy: this behavior is weird |
| 16:45:49 | dachary: | proppy: ah, no : sitin is called after buying in |
| 16:46:13 | dachary: | there was an error related to the fact that "buyin" is sent instead of "rebuy" |
| 16:46:24 | dachary: | did you fix this ? |
| 16:47:34 | proppy: | dachary: no I didn't fix anything yet |
| 16:47:41 | proppy: | dachary: I'm still investigating on the packet |
| 16:47:47 | proppy: | as the packet comments shows there is no commit |
| 16:48:43 | dachary: | proppy: http://drupal-dev.pokersource.info/trac/ticket/103 i'm refering to this one |
| 16:48:49 | dachary: | but you know ;-) |
| 16:48:50 | proppy: | dachary: me too |
| 16:48:51 | proppy: | http://drupal-dev.pokersource.info/trac/ticket/103 |
| 16:48:55 | proppy: | I updated the description |
| 16:49:02 | proppy: | with the informations you supplied to me |
| 16:49:16 | proppy: | I can't reproduce the error highlighted in the ticket |
| 16:49:43 | proppy: | I will try to reproduce b) cases |
| 16:50:48 | proppy: | ok now this is wierd :) |
| 16:50:52 | proppy: | I'm broke a) case |
| 16:50:56 | proppy: | and rebuy button is not shown |
| 16:53:49 | proppy: | ok I managed to reproduce the error |
| 16:53:50 | proppy: | queueIncoming {"code":0,"other_type":84,"cookie":"","game_id":435,"message":"no message","type":"PacketPokerError","serial":273,"time__":1263829976597} |
| 16:53:57 | proppy: | when broke and refresh the browser |
| 16:54:08 | proppy: | it ask the player to buy in |
| 16:54:18 | proppy: | instead of "rebuy in" |
| 16:54:56 | proppy: | updated ticket description http://drupal-dev.pokersource.info/trac/ticket/103#comment:5 |
| 16:58:01 | mongolito404: | dachary: Did fixing #141 alwos fixed #156 ? I'm unable to reproduce the bug with IE8 XP |
| 16:58:05 | dachary: | shum |
| 16:58:16 | dachary: | mongolito404: it's likely |
| 16:58:40 | dachary: | you can close it for now |
| 17:00:22 | proppy: | dachary: when refreshing the browser and broke, player.state is 'buyin' |
| 17:00:30 | dachary: | proppy: regarding the exit button: because there is a pending long poll, the tablequit won't be sent until the longpollreturn returns. And because your machine lags (often >1s) there is no time for it to happen. |
| 17:00:31 | proppy: | I believe this is the problem |
| 17:00:52 | proppy: | jpoker does check for the player state, to check if rebuy dialog should send PacketPokerBuyIn or PacketPokerRebuy |
| 17:01:14 | dachary: | the long poll makes the timeout trick / hack more likely to fail. There definitely need an upstream fix. |
| 17:01:22 | proppy: | dachary: sendPacket will send a PacketLongPollReturn if there is a pending long poll |
| 17:03:17 | proppy: | when creating playerSelf, jpoker always set its state to buyin |
| 17:04:12 | proppy: | he should be able to set its states to rebuy if the player has already payed the buyin |
| 17:04:18 | dachary: | proppy: can you set the exit timeout to 10 seconds please ? |
| 17:04:45 | proppy: | dachary: you mean restoring the timeout |
| 17:04:53 | proppy: | because you asked me to remove the rediretion |
| 17:05:09 | proppy: | dachary: done |
| 17:05:14 | dachary: | yes, please restore the redirection and set it to 10 s |
| 17:05:18 | dachary: | thanks |
| 17:05:44 | bkuhn | joined #pokersource. |
| 17:08:00 | proppy: | if(player.state == 'buyin') { |
| 17:08:01 | proppy: | packet_type = 'PacketPokerBuyIn'; |
| 17:08:01 | proppy: | label = _("Buy In"); |
| 17:08:01 | proppy: | } else { |
| 17:08:02 | proppy: | packet_type = 'PacketPokerRebuy'; |
| 17:08:02 | proppy: | label = _("Rebuy"); |
| 17:08:03 | proppy: | } |
| 17:08:05 | proppy: | should be |
| 17:08:20 | proppy: | if(player.state == 'buyin' && player.broke == false) { |
| 17:08:20 | proppy: | packet_type = 'PacketPokerBuyIn'; |
| 17:08:20 | proppy: | label = _("Buy In"); |
| 17:08:20 | proppy: | } else { |
| 17:08:21 | proppy: | packet_type = 'PacketPokerRebuy'; |
| 17:08:21 | proppy: | label = _("Rebuy"); |
| 17:08:22 | proppy: | } |
| 17:08:26 | proppy: | or something like that |
| 17:08:58 | dachary: | hum |
| 17:09:15 | dachary: | no |
| 17:09:52 | dachary: | a player who is broke does not go to state rebuy |
| 17:10:05 | proppy: | but maybe player.broke will always be true, for a joining player |
| 17:10:55 | proppy: | dachary: a player who is broke has definitly not the state buyin |
| 17:14:13 | proppy: | added http://drupal-dev.pokersource.info/trac/ticket/103#comment:6 |
| 17:14:20 | proppy: | I believe this provide a diagnostic for #103 |
| 17:14:49 | proppy: | bb in 1h |
| 17:17:13 | proppy: | chores time |
| 17:17:40 | proppy: | grocery chores that is :) |
| 17:27:15 | mongolito404: | dachary: I'm done with #144. It did my best to avoid any regression (several existing test case were used to ensure this) but I modified some sensible code and installing the patch requires changes in the database. Is it ok the push the changes to drupal-demo now I should I wait for tommorow morning to avoid letting drupal-demo in a unstable state while I'm not availabel to quick fix it ? I don't expect my changes to cause havoc, but I'm being ca |
| 17:28:55 | dachary | reading |
| 17:29:16 | dachary: | s/sensible/sensitive/ ;-) |
| 17:30:04 | dachary: | you will be available tomorrow morning ? |
| 17:31:14 | dachary: | mongolito404: |
| 17:31:27 | dachary: | mongolito404: forget the question |
| 17:31:38 | dachary: | it's ok to push your changes now |
| 17:31:52 | dachary: | thanks for asking. There is no demo scheduled tonight :-) |
| 18:03:41 | Sp4rKy: | "both Maxence and Johan and proppy" :} |
| 18:12:09 | mornifle | joined #pokersource. |
| 18:12:38 | proppy: | back |
| 18:19:29 | proppy: | dachary: mongolito404: about pwm, please note that current javascript fixes have been commited to pb_jpoker, |
| 18:19:57 | proppy: | and that planc will need to "pull" from pb_jpoker in order to includes last week fixes |
| 18:20:18 | emilie | quit IRC ("Leaving."). |
| 18:24:22 | mornifle | quit IRC (Read error: 113 (No route to host)). |
| 18:25:36 | proppy: | dachary: can I disable temporly seTimeout exit redirection on drupal-kez ? |
| 18:26:36 | proppy: | nvm I'll put a breakpoint |
| 18:32:32 | mornifle | joined #pokersource. |
| 18:35:13 | dachary: | proppy: you can do whatever you like with drupal-kez |
| 18:35:59 | proppy: | described upstream fix for #155 here: http://drupal-dev.pokersource.info/trac/ticket/155#comment:3 |
| 18:39:24 | proppy: | ah, I won't work |
| 18:39:27 | proppy: | it won't work |
| 18:39:56 | proppy: | there is no response to PacketPokerTableQuit, when the user has not take a seat at the table |
| 18:40:16 | bruno|taf1 | joined #pokersource. |
| 18:40:56 | proppy: | maybe we should hide 'exit' button when the player is not sit |
| 18:41:26 | proppy: | http://drupal-dev.pokersource.info/trac/ticket/155#comment:4 |
| 18:43:21 | dachary: | proppy: that would be nice indeed |
| 18:43:46 | proppy: | otherwise the fixe suggested in #comment:3 will not work |
| 18:44:31 | bruno|taf | quit IRC (Read error: 113 (No route to host)). |
| 18:50:01 | dachary: | Sp4rKy: "both Maxence and Johan and proppy" :} :-) |
| 18:50:07 | dachary: | ok ok |
| 18:52:37 | j1b | quit IRC ("Ex-Chat"). |
| 19:05:15 | proppy: | dachary: about drupal-demo do you want me to update exit timeout ? |
| 19:05:41 | dachary: | proppy: good idea, yes, please |
| 19:05:53 | proppy: | 1000ms ? |
| 19:06:41 | proppy: | update to 1000ms |
| 19:06:57 | proppy: | test are green for tableQuit |
| 19:06:58 | proppy: | http://drupal-kez.pokersource.info/pb_jpoker/jpoker/jpoker/test-jpoker.html?jpoker%20module%3A%20jpoker.server.tableQuit |
| 19:24:57 | proppy: | dachary: fixed #155 in pb_jpoker jpoker clone http://pastebin.com/f3b366920 |
| 19:25:04 | proppy: | feel free to review the patch |
| 19:25:17 | dachary: | reading |
| 19:25:19 | proppy: | and test the quit button behaviour on drupal-kez |
| 19:26:03 | proppy: | will update jpoker css to hide exit button if self player has no seat |
| 19:26:14 | dachary: | very nicely done |
| 19:29:43 | proppy: | using jpoker_self should do the trick |
| 19:31:05 | proppy: | I should move #quit initialisation to playerSelf |
| 19:31:08 | proppy: | to match other button |
| 19:37:30 | proppy: | +.jpoker_table .jpoker_ptable_quit { |
| 19:37:30 | proppy: | + display: none; |
| 19:37:30 | proppy: | +} |
| 19:37:30 | proppy: | + |
| 19:37:31 | proppy: | +.jpoker_table.jpoker_self .jpoker_ptable_quit { |
| 19:37:31 | proppy: | + display: block; |
| 19:37:32 | proppy: | +} |
| 19:37:34 | proppy: | will do the trick |
| 19:40:01 | proppy: | dachary: ah :( |
| 19:40:07 | proppy: | the fix is no good |
| 19:40:15 | proppy: | if there is more than more avatar watching the table |
| 19:40:18 | proppy: | player leave is never send |
| 19:40:25 | proppy: | more than one |
| 19:40:37 | proppy: | and destroy/redirect to lobby will never be called |
| 19:41:32 | dachary: | hum |
| 19:41:35 | proppy: | so we have no answer from server, other than [] when handling a PacketPokerTableQuit |
| 19:41:54 | proppy: | therefore I can't wait for a specific packet, for going back to running state |
| 19:41:55 | dachary: | but thanks to your fix |
| 19:41:59 | proppy: | in tableQuit |
| 19:42:12 | dachary: | hum |
| 19:42:17 | proppy: | currently tableQuit is waiting for PacketPokerPlayerLeave |
| 19:42:31 | dachary: | interesting situation |
| 19:42:39 | proppy: | but if there is more than one avatar for the same player at the table PacketPokerPlayerLeave will never be called |
| 19:42:51 | dachary: | I see what you mean |
| 19:42:58 | proppy: | so PacketPokerPlayerLeave is not a good condition for evaluating the success or the failure of TableQuit |
| 19:43:51 | dachary: | it's embarrassing |
| 19:44:02 | dachary: | i don't see any other side effect |
| 19:44:06 | dachary: | good catch |
| 19:44:30 | proppy: | and I can't hook on the success of a sendPacket |
| 19:44:40 | proppy: | maybe we should add a callback to sendPacket |
| 19:44:46 | proppy: | dachary: if(packet_type != 'PacketPokerLongPollReturn') { |
| 19:44:47 | proppy: | $this.receivePacket(data); |
| 19:44:47 | proppy: | } |
| 19:44:50 | dachary: | hum |
| 19:45:03 | proppy: | in sendPacketAjax success callback |
| 19:45:07 | dachary: | yes |
| 19:45:20 | proppy: | I should check that the server always return an empty response for PacketPokerLongPollReturn :) |
| 19:45:22 | proppy: | it's scary |
| 19:45:45 | dachary: | it's deep |
| 19:46:54 | proppy: | or we add a PacketAck server side |
| 19:47:05 | proppy: | for acknowledging PacketPokerTableQuit |
| 19:48:12 | dachary: | proppy: I thought exactly this |
| 19:48:31 | dachary: | it's also scary because it means modifying the server |
| 19:48:43 | proppy: | yes |
| 19:49:02 | proppy: | I think adding an optional callback to sendPacket is no harm |
| 19:49:16 | dachary: | I wonder if the general idea of "calling a callback when a packet has been successfully sent" is good or twisted. |
| 19:49:34 | dachary: | It looks appealing now but I'm not sure ;-) |
| 19:49:41 | dachary: | gtg ttyl |
| 19:51:26 | dachary | quit IRC (Read error: 60 (Operation timed out)). |
| 20:18:20 | guyvdb | quit IRC ("Leaving."). |
| 20:37:56 | goundy | joined #pokersource. |
| 20:41:34 | guyvdb | joined #pokersource. |
| 20:52:18 | dachary | joined #pokersource. |
| 21:00:26 | dachary | quit IRC (Read error: 54 (Connection reset by peer)). |
| 21:00:34 | dachary | joined #pokersource. |
| 21:12:21 | proppy: | updated patch with sendPacket callback |
| 21:12:22 | proppy: | http://pastebin.com/f23584e41 |
| 21:15:40 | goundy | quit IRC ("Ex-Chat"). |
| 21:22:21 | dachary: | proppy: very nice patch sir |
| 21:24:31 | proppy: | mailed |
| 21:27:06 | mornifle | quit IRC (Read error: 113 (No route to host)). |
| 21:35:50 | mornifle | joined #pokersource. |
| 22:26:20 | proppy | quit IRC ("Leaving."). |
| 22:50:18 | osivinyuk | joined #pokersource. |
| 22:50:44 | osivinyuk: | Hello bruno |
| 23:10:11 | bkuhn | quit IRC ("back in a few minutes."). |
| 23:12:52 | osivinyuk | quit IRC (Read error: 113 (No route to host)). |
| 23:16:13 | dachary | quit IRC ("Leaving."). |
| 23:17:20 | bkuhn | joined #pokersource. |
| 23:19:27 | dachary | joined #pokersource. |
| 23:48:47 | thy1 | quit IRC ("Leaving."). |
Proceed to Tuesday 19 January 2010
Brought to you by your friendly neighborhood Logger Bot.