#pokersource@irc.freenode.net IRC Log for
Friday 15 January 2010

Back to #pokersource@irc.freenode.net Log Calendar

Back to to Thursday 14 January 2010


Poker Free Software http://pokersource.info/ with IRC archives http://pokersource.info/irc/pokersource@irc.freenode.net/"

00:11:27 bruno|98 quit IRC (Read error: 113 (No route to host)).
00:38:38 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
01:56:00 bleader_ joined #pokersource.
02:06:41 proppy quit IRC ("Leaving.").
02:07:42 bleader quit IRC (Read error: 113 (No route to host)).
02:42:25 macmaN joined #pokersource.
02:48:24 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
04:51:28 macmaN joined #pokersource.
04:54:26 macmaN quit IRC (Read error: 54 (Connection reset by peer)).
06:58:03 macmaN joined #pokersource.
07:54:07 mongolito404 joined #pokersource.
07:54:25 mongolito404: Hi
07:54:57 dachary joined #pokersource.
08:02:58 Sp4rKy: mongolito404: I would sync pmw.pokersource from drupal-demo in the next hour, could you stop your work a few minutes when I'll need ?
08:03:59 mongolito404: Ok, chance are that I'll not push anything on drupal-demo on the next hour
08:04:47 Sp4rKy: k
08:15:37 dachary: mongolito404: could you switch back the theme to pokermania on drupal-demo before Sp4rKy does the sync ?
08:15:50 dachary: proppy will do the jpoker switch when he arrives
08:15:56 dachary: bb in 1 hour
08:17:08 Sp4rKy: mongolito404: let me know if you can do :)
08:23:36 mongolito404: Ok, I changed the theme
08:23:48 mongolito404: (on drupal-demo)
08:23:52 mongolito404: Sp4rKy: ^
08:25:41 Sp4rKy: k
08:25:47 Sp4rKy: mongolito404: ping me when it's done
08:26:10 mongolito404: Sp4rKy: It's done
08:27:17 Sp4rKy: thanks
08:32:36 mongolito404: dachary: I patched (one line) simpletest to ease testing of item buying. What should I do to ensure proper propagation to drupal-demo and drupal-kez ?
08:34:30 dachary quit IRC (Read error: 110 (Connection timed out)).
08:53:52 proppy joined #pokersource.
09:03:10 Sp4rKy: proppy: hi
09:03:29 Sp4rKy: could you please not work on drupal-demo during the next minutes ?
09:03:44 Sp4rKy: I'm going to sync pmw from drupal-demo
09:10:47 H|- quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 MotherOfCOBOL quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 proppy quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 bleader_ quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 guyvdb quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 tarbo2_ quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 saqimtiaz quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 thy1 quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 julez quit IRC (niven.freenode.net irc.freenode.net).
09:10:47 brian__ quit IRC (niven.freenode.net irc.freenode.net).
09:13:38 proppy joined #pokersource.
09:13:38 bleader_ joined #pokersource.
09:13:38 guyvdb joined #pokersource.
09:13:38 saqimtiaz joined #pokersource.
09:13:38 thy1 joined #pokersource.
09:13:38 julez joined #pokersource.
09:13:38 MotherOfCOBOL joined #pokersource.
09:13:38 brian__ joined #pokersource.
09:13:38 H|- joined #pokersource.
09:13:38 tarbo2_ joined #pokersource.
09:15:46 mongolito404: proppy: For the gift, can you confirm that all purchase for other players activate the item ?
09:23:25 proppy: mongolito404: you mean play the gift animation, or activate the item in medium profile ?
09:23:50 proppy: will check both
09:24:29 bleader_ is now known as bleader.
09:26:34 proppy: mongolito404: yes when buying a gift throught medium profile/buy gift
09:26:44 proppy: the gift animation is played
09:26:46 proppy: and
09:26:55 mongolito404: Sorry, I wasn't clear
09:27:02 emilie joined #pokersource.
09:27:02 proppy: when clicking medium profile on the other browser, the gift is activated
09:27:11 mongolito404: I wanted to confirm that is what is supposed to happen
09:27:26 proppy: ah ok, you mean in the specification
09:27:35 mongolito404: YEs
09:27:39 proppy: I remember something like this, that say to default activated item
09:27:49 proppy: is the last gift
09:27:51 proppy: w8
09:28:33 dachary joined #pokersource.
09:28:41 proppy: mongolito404: Only one item can have the status „activated“ if not set by the user it is
09:28:41 proppy: automatically the last item he received. It will be shown at the table
09:28:41 proppy: during the game.
09:28:44 proppy: from the specification
09:29:04 dachary: hop
09:29:08 proppy: 5.5.3
09:29:42 mongolito404: Ok
09:30:55 proppy: filled http://drupal-dev.pokersource.info/trac/ticket/140
09:33:19 dachary: proppy: I know you've worked yesterday after I left, is there anything you would like to discuss with me ?
09:33:24 proppy wonders the difference between http://drupal-dev.pokersource.info/trac/ticket/32 and http://drupal-dev.pokersource.info/trac/ticket/11
09:33:24 proppy: they have the same title :)
09:33:25 dachary looking at the tickets
09:33:26 proppy: dachary: do you agree with the plan I send you throught email, or do you have other suggestion ?
09:33:30 proppy: I moved challenge ticket to drupal
09:33:30 proppy: http://drupal-dev.pokersource.info/trac/ticket/4
09:33:43 proppy: because the poker part seems implemented
09:34:06 proppy: I wonder what remains to be done on http://drupal-dev.pokersource.info/trac/ticket/3
09:34:13 proppy: it is not clear why the ticket is still open
09:34:33 proppy: or rather has been reopened 7 weeks ago
09:34:37 proppy: Changed 7 weeks ago by admin ¶ status changed from closed to reopened
09:34:38 dachary: proppy: the challenge part of drupal is also supposed to be implemented
09:34:53 proppy: dachary: ok so integration/testing is needed then
09:35:27 proppy: (drupal part of challenge) :)
09:35:29 dachary: proppy: yes
09:35:47 dachary: regarding reward system, there is a missing logic
09:35:49 proppy: moved it to poker http://drupal-dev.pokersource.info/trac/ticket/4#comment:7
09:35:55 dachary: in the opensocial adapter
09:36:08 dachary: the opensocial adapter does not implement all the specs
09:36:39 proppy: opensocial adapter is python-pokersocial ?
09:36:46 dachary: yes
09:37:00 proppy: do you confirm http://drupal-dev.pokersource.info/trac/ticket/30 is also not implemented in the opensocial adapter ?
09:37:06 dachary: opensocial.pokersource.info
09:37:12 dachary: yes
09:37:17 dachary: it's the same
09:37:52 dachary: I would work on 30 before 3 because it's more visible
09:38:59 dachary: the idea for both is to set appdata based on poker events
09:39:01 mongolito404: proppy, dachary: If I understand 5.5.3, if user A doesn't set an active item (from his medium profile). After he receive a first gift, his active item is this first received gift. But after he receive a secodn gift, his active item is the second gift. Right ?
09:40:38 proppy: added http://drupal-dev.pokersource.info/trac/ticket/3#comment:8
09:40:55 proppy: is it another bug but for the same component ok
09:41:00 proppy: dachary: I think http://drupal-dev.pokersource.info/trac/ticket/70 is a duplicate of http://drupal-dev.pokersource.info/trac/ticket/127
09:41:00 proppy: but there is a milestone attached to it 'Deliverable 4'
09:41:00 proppy: should I close it (if you agree this is a duplicated), and report the milestone on 127 ?
09:41:07 proppy: mongolito404: that's how I understand the specification
09:41:14 proppy: but it could also be understood the other way around
09:41:17 proppy: "Only one item can have the status „activated“ if not set by the user it is
09:41:17 proppy: automatically the last item he received."
09:41:47 proppy: i.e last gift is set to activated only if there is no activated item by the user
09:42:43 dachary: proppy: I agree on the duplicate
09:44:39 proppy: I'm not sure to understand the rational of http://drupal-dev.pokersource.info/trac/ticket/124
09:44:40 proppy: jpoker itself doesn't hook on os_poker
09:44:40 proppy: poker.opensocial.js does
09:44:45 dachary: mongolito404: it is also how I understand it.
09:44:45 proppy: and poker.opensocial.js hooks itself on a lot of window.top.os_poker_* functions
09:44:46 proppy: (i.e not event)
09:45:05 proppy: I also added to #124 that poker.js hooks itself on os_poker while I believe poker.opensocial.js should
09:46:02 dachary: mongolito404: but that would imply to change the code so that the activated item is set when the player sits at a table
09:46:02 dachary: at the moment there is not item next to the player when he sits down
09:46:03 dachary: the player has to activate it manually
09:46:03 proppy: dachary: does it means that poker.opensocial.js should only contains "generic" opensocial code
09:46:26 proppy: and that os_poker specific code should be moved to os_poker.js or something like this ?
09:46:26 proppy: closed http://drupal-dev.pokersource.info/trac/ticket/70#comment:4
09:46:26 proppy: feel free to report the milestone to #127
09:46:33 proppy: dachary: is there a ticket for item activation of the player, when he join the table ?
09:47:34 proppy: I wonder what is the difference between http://drupal-dev.pokersource.info/trac/ticket/32 and http://drupal-dev.pokersource.info/trac/ticket/11
09:47:41 dachary: proppy: my bad, I meant poker.opensocial.js
09:47:42 dachary: and I agree that the problem is not limited to this hook
09:47:42 dachary: mongolito404: however, it is ok that the player has no item next to him when he sits at the table. Although the specs make it quite clear that it should, it's not an issue.
09:47:43 dachary: mongolito404: in other words, we can ignore this aspect of the specifications.
09:47:45 dachary: mongolito404: am I making sense ?
09:47:59 mongolito404: Continuing to understand how thing should be work. When a user who has set an active item receive a gift. The gift animation should be played. But the active item should not be chnaged (nor at the Drupal side, not the icon next to the player avatar)
09:48:01 mongolito404: dachary: Yes
09:48:02 dachary: proppy: yes, that's what it means. But we don't need to address this urgently. Only we need to keep it under control.
09:49:45 proppy: dachary: does it means that poker.opensocial.js should only contains "generic" opensocial code, and that os_poker specific code should be moved to os_poker.js or something like this ?
09:50:08 proppy: updated http://drupal-dev.pokersource.info/trac/ticket/124#comment:2
09:50:19 dachary: mongolito404: the active item (i.e. the one that shows next to him) must be the latest item he received while sitting at the table. In the drupal code it is also set as the "active" item, IIRC. It's not just about showing the animation.
09:50:27 dachary: proppy: it's the same !
09:50:32 dachary: good catch :-D
09:50:46 dachary: I thought this ticket was lost
09:50:51 proppy: mongolito404: that would be problematic, on the js side, because currently it set the item at the end of the animation
09:51:02 dachary: rather, I thought the content of this ticket was lost.
09:51:20 proppy: dachary: should we merge them, and how ?
09:51:30 proppy: I take the most recent one and reports comments ?
09:51:32 dachary: I think you can just invalidate #11
09:51:38 mongolito404: dachary: The problem with the actual code is that there is no disctinction between active item set by the user and set when he receive a gift.
09:52:09 dachary: just cut/paste the reference to the specs, it's the only useful information it contains
09:52:11 mongolito404: The code set the received gift as the activeitem if there isn't any. So when a second gift is received, it is not activated
09:53:32 proppy: I will add #11 description to #32
09:53:39 proppy: http://drupal-dev.pokersource.info/trac/ticket/11#comment:4 marked as duplicate
09:53:45 proppy: updated http://drupal-dev.pokersource.info/trac/ticket/32
09:54:05 dachary: mongolito404: why is it a problem ? I operate under the assumption that both behave exactly the same but I may be mistaken.
09:54:05 dachary: proppy: you've done an excellent work nuking the tickets last time
09:54:05 dachary added a link to http://drupal-dev.pokersource.info/trac/ that shows poker tickets
09:54:11 proppy: mongolito404: checking
09:54:55 dachary: raised #32 to blocker
09:55:06 proppy: remaining tickets are clear to me
09:55:08 proppy: only http://drupal-dev.pokersource.info/trac/ticket/32 is not
09:55:49 proppy doesn't get the distinction between os_poker_imsg, and message he already receive for gift animation for example
09:56:06 proppy: reading 6.3.8 and 5.7.3
09:57:39 dachary: proppy: my understanding is that imsg stands for "in game message" and they are snippets of HTML that are sent to a player and made to be displayed in the poker area if available
09:57:43 mongolito404: dachary: If the user does not set his active item, the last received gift should be his activeitem. When he receive a first gift, it is set as his active item. When he receive aa second gift, it is not activated since the user already has an activeitem (the first gift)
09:58:48 proppy: 6.3.8 reference a link to 5.22
09:58:49 dachary: mongolito404: that's the logic you see in the code ?
09:59:38 proppy: I don't grep any 5.22 in the specifications
09:59:38 proppy: looking at the toc
09:59:38 proppy: ok my grep was wrong :)
09:59:39 proppy: sorry for the noise
09:59:39 mongolito404: dachary: Yes
09:59:39 mongolito404: And since I refactored the gift notification to rely on the item activation code, that's why the animation doesn't play.
09:59:43 proppy: mongolito404: yes but currently in js code every gift animation set the item to the last animated gift
10:00:18 proppy: dachary: thanks for your time, it is clear to me what needs to be done now
10:00:31 dachary: that would explain why sending gifts works sometime. I.e. it does not work after the first time because once a user has a gift activated he just ignores the other gifts. The logic should be that the item displayed at the table is always the latest gift sent to the user.
10:01:05 dachary: proppy: thanks for your hard work, I fully appreciate how much you've extended yourself
10:01:31 mongolito404: dachary: yes
10:01:42 proppy: mongolito404: ah you're right
10:01:48 proppy: mongolito404: when buying a second gift
10:01:53 proppy: mongolito404: the animation doesn't play
10:02:34 dachary: mongolito404: I'm glad you were able to figure out the logic in the pile of code. It's an archeological tasks that's not for the faint of heart ;-)
10:02:50 proppy: dachary: yes but the specification could be understand the other way around ""Only one item can have the status „activated“ if not set by the user it is automatically the last item he received.""
10:03:05 proppy: "if not set by the user" is the catchy part
10:03:09 dachary: proppy: I fully agree on that
10:03:44 dachary: i wish this ambiguity had been raised by the implementors of the gift system
10:06:13 mongolito404: dachary: Should I seek to fix this activeitem issue. Or to only get the animation to play when expected ?
10:06:32 proppy: mongolito404: should we sent a different event for gift and item activation ?
10:06:49 proppy: mongolito404: I agree on what dachary said "The logic should be that the item displayed at the table is always the latest gift sent to the user."
10:06:57 proppy: even if it might not match the specification
10:08:31 mongolito404: proppy: I don't. As a user, if a set my active item to be a beer. I don't expect that another player sitting at my table can force a glass of water in front of me.
10:08:37 proppy: (10:00:41 AM) dachary: proppy: thanks for your hard work, I fully appreciate how much you've extended yourself <- that could mean you wish I had extended before :)
10:09:06 proppy: mongolito404: that would mean a different event should be sent for item activation and gift
10:09:24 proppy: or another field in gift event
10:09:32 proppy: to say if it should activate the gift or not
10:10:43 dachary: proppy: :-)
10:12:40 mongolito404: proppy: The "gift" event is misnamed. The event is actually "item bougth". And we need a second "item activated" event. Altough a single "item" event could be used (with an active property and an optional received_from one).
10:14:08 mongolito404: According to the specs, all item bouth for a players (by another player) should play the animation.
10:14:08 mongolito404: And we also want to play the animation when an item is activated by the user (altough I didn't see this in the spec)
10:16:20 mongolito404: The event to fire when a user activate an item could be {uid: user_uid, item: name, cls: css-class, active: true}
10:16:20 mongolito404: The event when as user receive a item could be {uid: user_uid, item: name, cls: css-class, active: true_or_false, from: sender_uid}
10:18:27 mongolito404: dachary: Should I seek to fix this currently discussed active item/event/animation issue. Or to only get the animation to play as now on all puchases ?
10:18:28 Sp4rKy: can I shut down drupal-demo for ~ 30 min ?
10:18:34 Sp4rKy: the pmw disk has not the same layout (not full virt etc) so rsync failed :(
10:18:34 Sp4rKy: I would dd the whole disk
10:21:45 dachary: mongolito404: I'm not sure I understand the different
10:22:31 dachary: s/rent/rence/
10:23:17 dachary: I assume you're talking about doing a quick hack or a proper fix
10:24:00 dachary: the answer is that if the proper fix is not going to be complete today, you should do the quick hack
10:24:36 proppy: mongolito404: I need your help
10:24:36 mongolito404: dachary: I could fix the server logic issue. But I could also ensure that a notification is sent without actually changing the current logic.
10:24:37 dachary: if the proper fix is the only thing you'll be able to do today, you should do it. The gift system has been in our way for too long, we need it to be fixed.
10:24:42 proppy: mongolito404: do you have internet explorer ?
10:25:03 mongolito404: proppy: Yes
10:25:04 dachary: mongolito404: understood. Are my remarks making sense ?
10:25:21 proppy: mongolito404: could you take a screenshot of the raise input
10:25:22 mongolito404: dachary: Yes, so I'll do the quick hack
10:25:24 proppy: as shown on http://drupal-dev.pokersource.info/trac/ticket/101
10:25:55 dachary: mongolito404: ok, I trust your judgement on this.
10:26:24 mongolito404: proppy: What do I do to get this ?
10:26:58 proppy: mongolito404: go to http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=405
10:27:28 mongolito404: proppy: http://www.microsoft.com/downloads/details.aspx?FamilyID=21eabb90-958f-4b64-b5f1-73d0a413c8ef&displaylang=en
10:27:28 proppy: seat
10:27:28 proppy: when it is your turn to play
10:27:28 proppy: take a screenshut
10:28:49 mongolito404: proppy: When I got to this URL, after login IE8 crash
10:30:49 proppy: mongolito404: what is it ?
10:30:51 mongolito404: And also on drupal-404
10:30:53 proppy: mongolito404: nice
10:30:53 proppy: mongolito404: when does it crash ?
10:30:57 proppy: mongolito404: could you fill a ticket explaining the crash on ie ?
10:31:07 proppy: i.e: Step to reproduce and screenshot
10:31:11 proppy: so I can close http://drupal-dev.pokersource.info/trac/ticket/101 and link to it ?
10:32:03 mongolito404: proppy: Opening any page as a logged user crash
10:32:07 mongolito404: I'm looking into it
10:33:02 Sp4rKy: are you working on drupal-demo ?
10:37:53 mongolito404: Sp4rKy: no
10:38:02 Sp4rKy: proppy: mongolito404 dachary ^
10:38:14 Sp4rKy: so I can stop it during 30 minutes ?
10:38:21 Sp4rKy: that's not a problem for you ?
10:38:24 mongolito404: Sp4rKy: yes
10:38:56 Sp4rKy: k
10:39:00 Sp4rKy: proppy: ok for you ?
10:42:23 dachary: Sp4rKy: no
10:42:23 Sp4rKy: no for which question ? :)
10:42:24 j1b joined #pokersource.
10:44:02 Sp4rKy: dachary: ^
10:46:07 dachary: ahaha
10:46:27 dachary: Sp4rKy: I'm not going to use drupal-demo or pwm all day
10:47:34 Sp4rKy: :}
10:47:34 Sp4rKy: ok
10:48:43 Sp4rKy: so I'm going to stop it and dd to pmw
10:48:43 proppy: reopened http://drupal-dev.pokersource.info/trac/ticket/137#comment:6
10:49:40 dachary: Sp4rKy: my answer should have been : no, yes, no
10:49:40 dachary: Sp4rKy: next time I suggest you create a poll http://www.peacefrogs.net/papillon-dev/ if you have multiple questions
10:49:40 dachary joking
10:49:47 mongolito404: proppy: I there a way to launch the jpoker gadget outside drupal to test ?
10:50:01 Sp4rKy: dachary: :D
10:50:07 proppy: mongolito404: http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html
10:50:18 proppy: http://drupal-kez.pokersource.info/pb_jpoker/test-poker.html
10:50:46 mongolito404: The first URL crash IE8
10:52:03 mongolito404: The second don't
10:56:20 mongolito404: The crash also happens on drupal-404; which means that whatecer cause it, it has been introduced before I sync. with drupal-kez
10:56:20 mongolito404: drupal-404:/usr/src/pb_jpoker# hg parents
10:56:20 mongolito404: changeset: 161:04f322e356dd
10:56:20 mongolito404: tag: tip
10:56:27 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
10:56:28 mongolito404: user: root@drupal-kez
10:56:28 mongolito404: date: Thu Jan 14 17:42:57 2010 +0100
10:56:28 mongolito404: summary: link should use href instead of src
11:09:49 proppy: mongolito404: it was working before that on drupal-404 ?
11:09:49 proppy: mongolito404: could you fill a ticket describing ie crashers ?
11:09:52 macmaN joined #pokersource.
11:14:06 mongolito404: proppy: http://drupal-dev.pokersource.info/trac/ticket/141
11:16:03 proppy: mongolito404: that may be sounds
11:16:10 proppy: mongolito404: because I insert item in the top iframe for sounds
11:16:35 proppy: mongolito404: did you pull 93d8fe7a2547 ?
11:17:23 proppy: filled http://drupal-dev.pokersource.info/trac/ticket/141#comment:2
11:18:15 proppy: updated http://drupal-dev.pokersource.info/trac/ticket/101#comment:7
11:18:17 mongolito404: proppy: drupal-404:/usr/src/pb_jpoker# hg parents
11:18:17 mongolito404: changeset: 161:04f322e356dd
11:18:17 mongolito404: tag: tip
11:18:17 mongolito404: user: root@drupal-kez
11:18:17 mongolito404: date: Thu Jan 14 17:42:57 2010 +0100
11:18:17 mongolito404: summary: link should use href instead of src
11:18:37 proppy: so it is not that :/
11:23:25 proppy: http://drupal-dev.pokersource.info/trac/ticket/137 fixed
11:26:58 proppy: filled http://drupal-dev.pokersource.info/trac/ticket/142
11:27:54 proppy: mongolito404: about ie blockers do you have tools that could help to diagnosticate the crash ?
11:28:06 proppy: mongolito404: was did it work in ie for the last time ?
11:28:07 Sp4rKy: dachary: ok, pmw is back, am I supposed to do anything on it ?
11:31:06 dachary: Sp4rKy: just make sure the proxy reaches it. Then it needs configuration and I'll do it
11:31:21 Sp4rKy: dachary: http://pokermaniaworld.com/drupal6/ works here
11:34:08 proppy: dachary: do you have a windows vm with ie on it ?
11:36:23 proppy: dachary: could you assign priority to http://drupal-dev.pokersource.info/trac/ticket/141
11:36:31 proppy: I guess this is a blocker I just want to be sure
11:37:16 dachary: it is
11:37:17 dachary: gtg
11:37:22 proppy: dachary: thanks
11:37:22 dachary: bb in one hour
11:37:56 proppy: Sp4rKy: is it possible to install a windows vm on the cluster ?
11:38:01 proppy: for debugging ie issues ?
11:38:12 Sp4rKy: proppy: it should be possible
11:38:23 Sp4rKy: (don't ask me how :p)
11:38:32 proppy: Sp4rKy: do you have time scheduled to help us today ?
11:38:56 Sp4rKy: not schedulded, but I don't think it will be a problem
11:39:06 Sp4rKy: my other task is write migration plan of rentre
11:39:10 proppy: ok
11:39:50 proppy: Sp4rKy: do you have access to bayou/bayou2 ?
11:40:09 Sp4rKy: which dns ?
11:40:19 proppy: proppy@pasokon:~$ ssh root@bayou.pokersource.info
11:40:20 proppy: root@bayou.pokersource.info's password:
11:40:20 proppy: Permission denied, please try again.
11:40:33 Sp4rKy: the same
11:40:47 proppy: I'm trying to access 3dprod.pokersource.info
11:40:54 proppy: I know there is a windows cd image on it
11:41:49 Sp4rKy: I can't help you :'(
11:41:50 proppy: Sp4rKy: dirtychip down ?
11:42:10 Sp4rKy: not for me
11:42:27 proppy: z2-6:~# ssh root@dirtychip.tld
11:42:29 proppy: hangs
11:42:36 Sp4rKy: not for me
11:42:37 Sp4rKy: :D
11:43:59 proppy: mongolito404: will build jslint on drupal-kez
11:44:02 proppy: to check js files
11:47:54 proppy: that's the only thing I can do for helping #41 right now
11:53:59 mongolito404: IE8 provides a JS Debbuger. It's a bit hard to get it to debug before the crash
11:54:41 proppy: mongolito404: saqimtiaz doesn't have the crash
11:55:07 saqimtiaz: http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html does not crash for me on IE8 but it does not display properly. That is, I cannot see the header colours etc for the tests
11:55:27 dachary quit IRC (Read error: 113 (No route to host)).
11:55:49 saqimtiaz: I've got an alert with an error when joining table on drupal-kez
11:56:31 saqimtiaz: and then its stuck on "please wait, table is loading"
11:57:49 mongolito404: proppy: weird
11:58:26 saqimtiaz: Unexpected call to method or property access. line 776 jquery.jpoker.js
11:58:55 saqimtiaz: LOG: {"number":-2147418113,"description":"Unexpected call to method or property access.","message":"Unexpected call to method or property access."}
11:58:56 saqimtiaz: {anonymous}(#object)
11:58:56 saqimtiaz: {anonymous}(#object)
11:58:56 saqimtiaz: {anonymous}("0",#object)
11:58:56 saqimtiaz: {anonymous}()
11:58:57 saqimtiaz: {anonymous}()
12:00:26 proppy: mongolito404: jslint clear now http://drupal-dev.pokersource.info/trac/ticket/141#comment:3
12:00:53 proppy: saqimtiaz: thanks for the test
12:00:58 saqimtiaz: np
12:05:00 mongolito404: http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html still crash IE8 for me
12:05:24 saqimtiaz: I don't know if you already know this proppy but in IE8 clicking on any link in the top menu gives a error: document.body is null or not an object
12:06:01 saqimtiaz: mongolito404: what OS?
12:06:12 mongolito404: XP
12:06:32 saqimtiaz: Win 7 here, that could be the difference I guess
12:07:12 saqimtiaz: I have an XP VM... let me see if it has IE8
12:08:44 guyvdb quit IRC ("Leaving.").
12:09:45 proppy: saqimtiaz: maybe it is because of the interruption of long poll
12:09:49 proppy: as you described yesterday
12:10:00 proppy: long poll should be cancelled using windows.on_exit
12:14:53 dachary joined #pokersource.
12:15:20 saqimtiaz: proppy: possibly
12:15:41 saqimtiaz: I only have IE7 on the XP VM
12:18:32 proppy: saqimtiaz: I'will try disable errorHandling
12:18:49 saqimtiaz: in IE7 when I log in, there is a javascript error when loading the lobby and then the page is stuck loading for some time and then the browser crashes proppy
12:18:51 proppy: saqimtiaz: will you be able to try to sit at a table then ?
12:18:55 saqimtiaz: sure
12:20:22 proppy: saqimtiaz: error handler commented
12:20:28 proppy: be sure to refresh your cash
12:20:30 proppy: cache
12:20:36 proppy: on http://drupal-kez.pokersource.info/pb_jpoker/js/poker.opensocial.js
12:20:37 proppy: and
12:20:53 proppy: http://drupal-kez.pokersource.info/pb_jpoker/jpoker/jpoker/js/jquery.jpoker.js
12:22:29 mongolito404: proppy: When I click on a player in the gadget, his medium profile opens in a thcikbox. Does the gadget open the thickbox or does it pass the event to the top frame ?
12:23:00 saqimtiaz: proppy: I don't see any errors now but its just stuck on the loading screen
12:23:03 proppy: mongolito404: plugins.player.callback.seat_click = function(player, id) {
12:23:04 proppy: parent.os_poker_show_medium_profile(player.serial);
12:23:04 proppy: };
12:23:21 proppy: saqimtiaz: after of before double / clicking a table in the table list
12:23:24 proppy: saqimtiaz: are you logged ?
12:23:39 proppy: saqimtiaz: could you try to load http://drupal-kez.pokersource.info/drupal6/?view=table&game_id=405 directly
12:23:54 saqimtiaz: im logged in, lobby loads fine in IE8 (haven't tried IE7 after your change), Double click to join table and it gets stuck on loading screen
12:23:58 mongolito404: proppy: It should be parent.os_poker_show_medium_profile(player.serial, game_id);
12:24:13 saqimtiaz: proppy: same behaviour
12:24:14 mongolito404: Wher game id is the table/game ID (or serial)
12:24:25 proppy: mongolito404: I don't have the game_id from there
12:24:28 proppy: I'm afraid
12:24:59 proppy: I mean directly in the callback params
12:25:54 dachary: mongolito404: could you please go to http://drupal-demo.pokersource.info/drupal6/ make sure you're logout, type login and confirm the error message do not show
12:26:46 mongolito404: What error message ?
12:27:08 dachary: if you click login without filling anything, what happens ?
12:27:16 mongolito404: If I put wrong crendentila, the rror overlay does not overlay
12:27:27 mongolito404: And is at the bottom of the page
12:27:41 dachary: can you please fill this bug as being critical ?
12:29:40 mongolito404: yes
12:33:17 proppy: mongolito404: trying to find out where i can get game_id for show_medium_profile
12:34:09 proppy: mongolito404: may I ask why is this needed ?
12:34:37 mongolito404: The code for the shop get the table id from the URL
12:34:47 mongolito404: It is needed to find the player sitting at the table
12:35:40 proppy: mongolito404: sorry there is a game_id field in player that I didn't know of
12:35:48 proppy: I can pass it to the callback
12:40:33 mongolito404: thanks
12:43:27 proppy: mongolito404:
12:43:28 proppy: changeset: 176:c015c0cf4c89
12:43:28 proppy: user: root@drupal-kez
12:43:28 proppy: date: Fri Jan 15 12:41:41 2010 +0100
12:43:28 proppy: files: js/poker.js js/poker.opensocial.js js/test-poker.opensocial.js
12:43:29 proppy: description:
12:43:30 proppy: move seat click to poker.opensocial, added game_id arg
12:43:59 proppy: saqimtiaz: do you have suggestion on how to debug the i.e issue
12:44:02 proppy: I'm clueless
12:44:53 proppy: maybe I should meet you and grab you windows xp iamge
12:45:33 saqimtiaz: proppy: sure you're welcome, its vbox image
12:46:13 saqimtiaz: its a tricky problem to debug. I'd check the line I reported in the code and see exactly what is supposed to be happening there
12:46:56 proppy: mongolito404: about http://drupal-dev.pokersource.info/trac/ticket/32 is os_poker already sending os_poker_imsg ?
12:47:22 proppy: (11:58:02 AM) saqimtiaz: Unexpected call to method or property access. line 776 jquery.jpoker.js
12:47:22 proppy: (11:58:31 AM) saqimtiaz: LOG: {"number":-2147418113,"description":"Unexpected call to method or property access.","message":"Unexpected call to method or property access."}
12:47:33 mongolito404: proppy: I don't know
12:47:37 mongolito404: Can't check it now
12:48:06 proppy: added http://drupal-dev.pokersource.info/trac/ticket/141#comment:4
12:48:21 mongolito404: dachary: http://drupal-dev.pokersource.info/trac/ticket/143
12:48:56 proppy: is seems so
12:48:57 proppy: os_poker_bind_message("os_poker_imsg", null, function(event, arg) {
12:48:57 proppy: alert(arg.text);
12:48:57 proppy: $("iframe#remote_iframe_os_poker").find("*").triggerHandler("os_poker_imsg", arg);
12:48:58 proppy: });
12:48:58 saqimtiaz: http://drupal-dev.pokersource.info does not have the problem I mentioned earlier when clicking the links in the top menu.
12:48:58 proppy: :)
12:49:20 proppy: (12:05:00 PM) saqimtiaz: I don't know if you already know this proppy but in IE8 clicking on any link in the top menu gives a error: document.body is null or not an object
12:49:22 proppy: adding it
12:49:42 proppy: http://drupal-dev.pokersource.info/trac/ticket/141#comment:5
12:49:43 saqimtiaz: ^^ it doesn't happen in drupal-dev
12:50:32 proppy: oh ok
12:50:44 proppy: saqimtiaz: drupal-dev is a very old version
12:50:50 saqimtiaz: aha
12:50:53 proppy: saqimtiaz: does drupal-404 has it ?
12:50:56 saqimtiaz: I thought it was the newer one?
12:51:00 saqimtiaz: checking
12:51:18 mongolito404: proppy: Are you sure os_poker_show_medium_profile is used to open the profile. I can't catch it with Firebug
12:51:40 proppy: mongolito404: let me try
12:51:49 saqimtiaz: no, drupal-404 is good for this problem, it doesn't happen
12:52:48 proppy: mongolito404:
12:52:50 proppy: I can trap it
12:52:51 proppy: os_poker_s...um_profileseat_click()(?)()handle()(?)()
12:52:53 proppy: in firebug
12:53:10 proppy: saqimtiaz: really ?
12:53:14 proppy: good to know
12:53:18 saqimtiaz: yep
12:54:13 proppy: saqimtiaz: that's wierd
12:54:20 proppy: because 404 has the same code
12:54:20 proppy: drupal-kez:~/drupal# hg incoming ssh://root@drupal-404.pokersource.vm.gnt//etc/drupal/6/sites/all/
12:54:20 proppy: comparing with ssh://root@drupal-404.pokersource.vm.gnt//etc/drupal/6/sites/all/
12:54:21 proppy: searching for changes
12:54:21 proppy: no changes found
12:54:21 proppy: drupal-kez:~/drupal# cd /usr/src/pb_jpoker
12:54:22 proppy: drupal-kez:/usr/src/pb_jpoker# hg outgoing -vp ssh://root@drupal-404.pokersource.vm.gnt//usr/src/pb_jpoker
12:54:25 proppy: running ssh root@drupal-404.pokersource.vm.gnt "hg -R /usr/src/pb_jpoker serve --stdio"
12:54:27 proppy: comparing with ssh://root@drupal-404.pokersource.vm.gnt//usr/src/pb_jpoker
12:54:29 proppy: searching for changes
12:54:31 proppy: no changes found
12:54:33 proppy: saqimtiaz: is your cache cleaned ?
12:54:56 saqimtiaz: yep
12:55:14 proppy confused
12:55:28 proppy: saqimtiaz: I'll make a break and join you @2 gares
12:55:34 proppy: so I can debug ie issues from there
12:55:49 saqimtiaz: you're coming now? because then I won't go out :D
12:55:50 proppy: I'll bring an external hard drive
12:55:55 saqimtiaz: have you had lunch?
12:55:55 proppy: oh sorry
12:56:00 saqimtiaz: no its fine
12:56:01 proppy: if you had plan for going out
12:56:03 saqimtiaz: I don't have any plans
12:56:07 proppy: we can meet else where
12:56:08 saqimtiaz: im just bored :D
12:56:12 proppy: you could also come here :)
12:56:13 proppy: ahahah
12:56:14 saqimtiaz: come over
12:56:24 saqimtiaz: yes but my laptop weighs 50 kg
12:56:29 proppy: and bring me a pizza
12:56:32 proppy: what a good idea
12:56:42 saqimtiaz: no no, you bring pizza. its closer to you :D
12:56:56 saqimtiaz: oh wait, you're at mksp?
12:57:03 saqimtiaz: just come over. I don't want to carry this machine
12:57:07 proppy: no @my home
12:57:14 saqimtiaz: ahahahahah then yes, come over
12:57:18 proppy: it 2 metro stop come on ! (joking)
12:57:37 proppy: yes with a pizza, but it will be cold
12:59:16 saqimtiaz: just come over... I haven't had lunch so ill wait for you proppy
12:59:38 proppy: :)
13:00:04 proppy: mongolito404: about http://drupal-dev.pokersource.info/trac/ticket/32 I believe drupal js code is wrong
13:00:37 proppy: it should not fw the message directly to the iframe
13:00:53 proppy: since the iframe can register on window.top event, (as it does for gift)
13:02:22 proppy: mongolito404: about os_poker_show_medium_profile I can confirm it is fired
13:02:38 mongolito404: ok
13:03:08 proppy: (with the game_id)
13:03:39 mongolito404: proppy: Don't ping me about anything excpet #135, I'm loosing my mind trying to get it to work (os_poker_show_medium_profile was part of it)
13:04:49 proppy: mongolito404: sorry for disturbing
13:06:11 proppy: if you were in france I would have offered you some pizza :)
13:06:46 proppy quit IRC ("Leaving.").
13:23:02 guyvdb joined #pokersource.
13:43:49 sacounet joined #pokersource.
13:49:48 sacounet quit IRC (Read error: 104 (Connection reset by peer)).
13:50:38 sacounet joined #pokersource.
13:56:42 sacounet quit IRC (Read error: 104 (Connection reset by peer)).
13:58:59 proppy joined #pokersource.
14:01:45 mongolito404: dachary, proppy: I think that I fixed gift on drupal-404
14:01:54 mongolito404: I need a break to fetch something to eat
14:02:10 mongolito404: It needs to be tested
14:02:18 dachary: mongolito404: :-)
14:02:25 dachary: mongolito404: congrats
14:04:51 mongolito404: I finally found what was going wrong: a) Notification were relying on itemactivation, but as discussed this morning, only the first gift is activated. So notification for additional goft didn't work. b) The table id was not propagated from the gadget to the medium profile page then not to the shop page. So the form for the shop didn't know what table the player is sitting at, and could's find the other players.
14:05:04 proppy: mongolito404: congrats !
14:07:30 bkuhn joined #pokersource.
14:07:55 mongolito404: I've written a new testcase for the shop but it can't test the "Bug for Table". The tables information is stored in the "poker" database. Currently it is not possible to change the poker database used when calling drupalGet/drupalPost, so when submitted in test, the testform try to find players sitting at the table in the "real" poker database and not in the "test" one.
14:08:23 mongolito404: But now: a) ibuprofen b)something warm o eat
14:08:57 mongolito404: Could someone test the various "Buy" button ?
14:09:12 proppy: mongolito404: there is fonction to mock up the poker database
14:10:03 proppy: createPokerDatabase in 5.5
14:10:46 dachary: mongolito404: I'm trying to make http://pokermaniaworld.com/drupal6/ work and I have two questions, which have a simple answer I hope
14:10:48 mongolito404: Yeah but it doesn't change the database used by the HTTP request done though drupalGet/drupalPost
14:11:16 dachary: 1) what do I need to do to switch http://pokermaniaworld.com/drupal6/ to http://pokermaniaworld.com/
14:11:26 dachary: do I have to tell drupal anything ?
14:11:36 dachary: or is it just an apache configuration thing ?
14:11:56 mongolito404: I believe just apache
14:11:58 proppy: mongolito404: ah I see
14:13:39 proppy: mongolito404: maybe you can add an extra arg to the drupalPost
14:13:43 dachary: mongolito404: I'll give it a try, thanks
14:13:44 proppy: that could override the db
14:14:42 mongolito404: proppy: Yes, I think it can be done this way. Pass an additional argument to drupalPost and have os_poker_init() retrieve it to set in on the CPoker class.
14:15:24 mongolito404: dachary: Should I wait for your second question before going out to buy some food ?
14:15:43 mongolito404: Because I have not (yet) confitured any IRC client on my Android phone
14:15:56 sacounet joined #pokersource.
14:16:13 dachary: mongolito404: no thanks, I'll ask after, it's not urgent
14:16:13 sacounet quit IRC (Read error: 54 (Connection reset by peer)).
14:16:33 proppy: mongolito404: buy button is working
14:16:43 proppy: mongolito404: the first time you bought an item to another player
14:16:48 proppy: there is a gift animation
14:16:49 proppy: but
14:16:53 proppy: the second time, there is none
14:17:00 proppy: is that the expected behaviour ?
14:17:03 proppy: howw waait
14:17:10 proppy: I guess I should pull code from drupal-404 first :)
14:17:12 proppy: sorry for the noise
14:17:18 dachary: mongolito404: when I signup on http://pokermaniaworld.com/ i get redirected to a "permision denied page"
14:17:48 dachary: mongolito404: if you have a hint about why it happens, please send me a mail. Otherwise don't bother looking, I don't want to distract you.
14:18:05 dachary: mongolito404: the apache configuration did the trick
14:18:20 sacounet joined #pokersource.
14:18:20 sacounet quit IRC (Read error: 104 (Connection reset by peer)).
14:19:39 proppy: mongolito404: buy gift works
14:19:49 proppy: first time you buy a gift to a player
14:19:52 proppy: the gift animation is player
14:19:54 proppy: second time too
14:20:07 proppy: buy for table always return "Sorry !You don't have enough Chips. "
14:20:39 proppy: when I buy gift for myself it is not activated , and no animation
14:20:52 proppy: when I activate it the animation is played
14:21:28 sacounet joined #pokersource.
14:21:55 proppy: buy for buddies also works
14:21:56 sacounet quit IRC (Read error: 104 (Connection reset by peer)).
14:22:18 proppy: when I click on myself, I only have two option in the shop
14:22:21 proppy: buy / buy for buddy
14:22:25 proppy: when I click on another player
14:22:28 proppy: I have three
14:22:45 proppy: buy / buy for table / buy for table and buddy
14:23:28 proppy: buy for table and buddies also work
14:23:38 dachary: proppy: did you link your jpoker skinning HOWTO from the toplevel wiki home page ?
14:23:58 proppy: dachary: refresh my mind
14:24:08 proppy: I don't remember what jpoker skinning HOWTO means
14:24:39 dachary: what must be done to skin jpoker / CSS html
14:24:59 dachary: what you had to do to change planc in pb_poker
14:25:09 dachary: the research you did and documented on monday
14:25:21 proppy: looking on the tickets
14:25:53 proppy: http://drupal-dev.pokersource.info/trac/wiki/SwitchingTheme
14:26:08 proppy: that's the page we've done with mongolito404
14:26:10 dachary: thanks
14:26:16 dachary: I'll add a link from the home page
14:26:43 proppy: added it to http://drupal-dev.pokersource.info/trac/wiki/WikiStart?version=23
14:26:53 proppy: sorry for forgetting to link it
14:27:07 dachary: ok, you've been faster than me ;-)
14:28:15 proppy: dachary: did you see the video I made yesterday ?
14:28:35 dachary: no I did not
14:28:39 proppy: http://drupal-dev.pokersource.info/player-join-exit/
14:28:44 dachary: (not finished reading my mail)
14:28:59 proppy: about #133 and #111 fix
14:29:12 proppy: http://drupal-dev.pokersource.info/trac/attachment/ticket/133/player-join-exit.ogv
14:29:14 proppy: ogg version
14:33:18 dachary: nice
14:33:44 dachary: it shows the price you pay when you don't have cache as well as demostrating the join + exit bug fix ;-)
14:35:33 proppy: I don't undestand your sentence, but it's ok :)
14:37:19 dachary: the redisplay of the page starts with a white page because you have nothing in cache
14:37:34 dachary: meeting, bbl
14:43:45 proppy: http://drupal-dev.pokersource.info/trac/ticket/32#comment:9 updated
14:45:12 brian__ quit IRC (Read error: 110 (Connection timed out)).
14:47:44 mongolito404: back
14:58:04 proppy: mongolito404: welcome back
14:58:14 proppy: mongolito404: working on #135 now that I have a vm
14:59:29 dachary quit IRC (Read error: 110 (Connection timed out)).
15:00:23 mongolito404: proppy: You mean testing #135 fix ?
15:00:52 proppy: oups sorry
15:00:54 proppy: wrong ticket number
15:01:21 proppy: I'm working on #141 :)
15:01:23 proppy: sorry for the confusion
15:01:36 proppy: mongolito404: I tested #135 fix, and reported my conclusion here
15:01:40 proppy: should I add them to the ticket ?
15:02:25 mongolito404: Did you test all the Buy buttons ?
15:02:50 mongolito404: Ok, I've found your reports
15:03:33 proppy: mongolito404: did I forgot to test something ?
15:06:04 mongolito404: I don't think so. I just teste "Buy", "Buy for Table" and "Buy for Table and Buddies" and they all seems to work. When two player are setting at the table.
15:06:36 proppy: no
15:06:41 proppy: Buy For table didn\t work
15:06:44 mongolito404: on drupal-404 ?
15:06:47 mongolito404: Which user ?
15:07:02 proppy: (02:19:43 PM) proppy: buy for table always return "Sorry !You don't have enough Chips. "
15:07:18 proppy: on drupal-kez with drupal-404 code pulled
15:07:39 mongolito404: Do you have enough chips to buy for the table ?
15:07:53 proppy: I guess yes, because I was only playing with one player
15:08:01 mongolito404: And is the amount on the Buy for table correct ?
15:08:02 proppy: buy the buy for table was always showing 0$
15:08:12 proppy: in case it helps
15:08:31 mongolito404: Go to admin/settings/performance and clear the cache
15:08:39 proppy: mongolito404: ok
15:12:07 proppy: mongolito404: ok buy for table works as expected
15:12:15 proppy: mongolito404: and it also buy a gift for myself
15:12:19 proppy: (and activate it)
15:15:04 mongolito404: Yes, I only fixed the notifications and the shop. I didn't change the implemented logic
15:15:28 mongolito404: But the item is not actually activated if you already have an activated item
15:15:58 proppy: mongolito404: repruced ie8 crashes
15:16:42 sacounet joined #pokersource.
15:21:52 mongolito404: good
15:27:20 proppy: got a lead
15:27:54 proppy: might be because of
15:27:54 proppy: //var os_poker_skin = prefs.getString('os_poker_skin');
15:27:55 proppy: //if (os_poker_skin) {
15:27:55 proppy: //$('').attr('href', os_poker_skin).insertAfter('link:last');
15:27:56 proppy: //}
15:27:58 proppy: trying to comment it
15:40:40 proppy: I think I found the ie8 bug
15:40:46 proppy: there was an error in the html markup
15:41:09 proppy: http://drupal-dev.pokersource.info/trac/ticket/141#comment:6
15:42:42 saqimtiaz: Progress :D
15:42:49 saqimtiaz: IE debugging is fun ;)
15:44:38 mongolito404: As fun as in digging a hole with a spoon...
15:44:49 mongolito404: in concrete !
15:44:57 proppy: mongolito404: dachary: please create new account when testing on drupal-kez
15:45:13 proppy: the application_id has changed
15:45:17 proppy: so all appdata are gone
15:45:30 mongolito404: :(
15:46:00 proppy: and jpoker is not happy when appdata are gone
15:46:04 proppy: because he try to fetch money
15:51:38 saqimtiaz: mongolito404: shawshank redemption? :D Spoon + concrete wall
15:51:52 proppy: saqimtiaz: please screenshot !
15:52:00 saqimtiaz: http://dl.dropbox.com/u/385674/ie8-drupalkez.png
15:52:00 saqimtiaz: IE 8 + drupalkez. playing a hand with proppy. Works but some css issues with the skin
15:52:02 proppy: I want to show the work it is working with ie
15:52:06 proppy: because nobody will believe me
15:53:17 saqimtiaz: now who is brave enough to test in IE6 and IE7?
15:54:08 mongolito404: I don't know for Shawshank. But if you love IE8 it's a sin and you should seek redemption :D
15:54:23 proppy: saqimtiaz: http://drupal-kez.pokersource.info/pb_jpoker/test-poker-opensocial.html
15:58:43 proppy: http://drupal-dev.pokersource.info/trac/ticket/141#comment:8 fixed
15:59:01 proppy: filled http://drupal-dev.pokersource.info/trac/ticket/148
15:59:05 saqimtiaz: http://dl.dropbox.com/u/385674/ie8-skinning%20issues.png
15:59:16 proppy: filled http://drupal-dev.pokersource.info/trac/ticket/150
15:59:44 saqimtiaz: mongolito404: no one likes IE8.... but I am relieved that the debugging tools for IE8 are better than what we've had in the past
16:00:38 proppy: http://drupal-dev.pokersource.info/trac/ticket/149
16:02:01 dachary joined #pokersource.
16:02:16 proppy: see ie8 skinning issue there
16:02:17 proppy: http://drupal-dev.pokersource.info/trac/ticket/148
16:02:19 proppy: created a ticket
16:02:26 proppy: dachary: not crashing anymore with ie8
16:02:27 proppy: \o/
16:02:37 proppy: dachary: saqimtiaz helped a lot
16:02:49 saqimtiaz: :)
16:04:25 mongolito404: saqimtiaz: True, the developper tools in IE8 is nicer than any solution I've ever seen for IE6 or IE7 (but I didn't test Visual Studio)
16:04:53 dachary hugs saqimtiaz and bless the french strikes
16:05:05 dachary: proppy: :-)
16:06:08 dachary: Do you require anything from me before I go ? (20 minutes) mongolito404 proppy ?
16:06:37 proppy: dachary: html of the opensocial gadget was wrong
16:06:40 proppy: there was a typo
16:06:43 proppy: so I had to re-add it
16:06:48 proppy: so the application_id changed
16:07:02 proppy: dachary: please keep in mind that you will need to create new user for testing
16:07:04 dachary: k
16:07:05 proppy: in order to have money
16:07:06 mongolito404: dachary: no
16:07:31 proppy: dachary: I filled new tickets for ie related things
16:07:31 proppy: http://drupal-dev.pokersource.info/trac/ticket/148
16:07:35 proppy: http://drupal-dev.pokersource.info/trac/ticket/149
16:07:40 proppy: could you assign priority to them
16:07:45 proppy: (i.e blocker on not)
16:08:15 dachary: proppy: ok
16:09:04 mongolito404: Strikes in France... In Belgium we have a strike at the larger beer brewer... :D
16:09:23 dachary: ahahah
16:09:53 dachary: saqimtiaz: wanted to go to bruxelles by train in hope the flights take off
16:10:15 saqimtiaz: well if there's no beer then everything should be on time there!
16:10:34 dachary: 148 => blocker, 149 => not blocker
16:10:37 mongolito404: Don't worry, we have several brewers and the beer won't stop to flow.
16:10:49 dachary: proppy: I updated the priorities
16:10:54 dachary: mongolito404: :-D
16:10:54 proppy: closed http://drupal-dev.pokersource.info/trac/ticket/101#comment:8
16:10:58 proppy: but that's virtual
16:11:14 proppy: because ie skinning work goes to #148
16:12:03 proppy: dachary: I don't see them in http://drupal-dev.pokersource.info/trac/query?status=accepted&status=assigned&status=new&status=reopened&component=Poker&order=priority&col=id&col=summary&col=status&col=type&col=priority&col=milestone&owner=!~mongolito
16:12:23 proppy: maybe they are not "Poker"
16:13:33 mongolito404: dachary: http://drupal-dev.pokersource.info/trac/ticket/145 Surely, you don't xant me to add a Loremipsum at the bottom of the page.
16:14:00 proppy: will get back to http://drupal-dev.pokersource.info/trac/ticket/32
16:14:08 proppy: as it flagged as blocker
16:14:14 proppy: mongolito404: did you see my comment on #32 ?
16:14:23 proppy: I confirm that: os_poker_imsg is fired,
16:14:23 proppy: I believe the following code is node needed anymore in os_poker.events:
16:14:30 proppy: os_poker_bind_message("os_poker_imsg", null, function(event, arg) { alert('os_poker_imsg:' + arg.text); $("iframe#remote_iframe_os_poker").find("*").triggerHandler("os_poker_imsg", arg); });
16:14:34 proppy: The gadget could register itself on 'os_poker_imsg' by using:
16:14:35 proppy:
16:14:38 proppy: window.top.os_poker_bind_message('os_poker_imsg', undefined, function(event, args) { });
16:14:53 dachary: mongolito404: yes I do :-)
16:15:20 proppy: I suggest that when the last blocker are gone
16:15:24 proppy: we merge stuff on drupal-demo
16:15:27 dachary: if you do, it will show in the translation files and it will be given to the content people. Otherwise it does not show. It's not completly absurd ;-)
16:15:31 dachary: mongolito404: ^
16:16:13 dachary: instead of the default text you could write : "The text that shows at the bottom of the first profile page and that has yet to be defined".
16:16:17 mongolito404: dachary: Ok
16:16:32 mongolito404: proppy: I' agree with the last comment in #32
16:16:42 proppy: mongolito404: thanks
16:16:49 dachary: mongolito404: it's all about being in the workflow
16:16:51 proppy: do you want me to remove the code ?
16:17:44 mongolito404: proppy: yes
16:18:36 proppy: mongolito404:
16:18:37 proppy: changeset: 158:8da13fd4fd82
16:18:37 proppy: tag: tip
16:18:37 proppy: user: root@drupal-kez
16:18:37 proppy: date: Fri Jan 15 16:18:00 2010 +0100
16:18:38 proppy: files: modules/os_poker/js/os_poker.events.js
16:18:39 proppy: description:
16:18:41 proppy: remove os_poker_bind_message for os_poker_ims
16:18:43 proppy: feel free to pull from drupal-kez
16:19:04 proppy: http://drupal-dev.pokersource.info/trac/ticket/32#comment:10 updated
16:20:17 proppy: mongolito404: also do you know what "os_poker_invite_user" means ?
16:20:45 proppy: that's the only os_poker_imsg notification I grep with challenge in os_poker code base
16:22:39 mongolito404: no
16:53:45 proppy: mongolito404: I think there is a missing property in the notification event
16:53:46 proppy: called http://drupal-dev.pokersource.info/trac/ticket/32
16:53:50 proppy: called 'title'
16:55:44 mongolito404: You mean that os_poker_imsg messages should have a title ?
16:57:43 mongolito404: In the os_poker code, there is two different os_poker_imsg sent; You just challenged !user and Invitation sent to !user
17:03:50 dachary: mongolito404: can I try gifts on drupal-demo or should I wait for your signal ?
17:04:44 mongolito404: dachary: You can try
17:04:56 dachary: mongolito404: thanks
17:13:55 proppy: got notification skinning to work: http://drupal-kez.pokersource.info/pb_jpoker/skin/table.html#poker_02_notification
17:14:16 proppy: mongolito404: is our stuff merged on drupal-demo ?
17:14:26 proppy: mongolito404: I tried them on drupal-kez
17:14:32 proppy: but I don't merged them on drupal-demo
17:14:41 proppy: mongolito404: yes, because there is title on the specification
17:14:52 proppy: and also in the spec you've got message for:
17:14:56 proppy: buddy request
17:14:59 proppy: new level
17:15:01 proppy: rewards
17:15:06 proppy: buddy online status
17:16:56 mongolito404: Clearly notifications are done done properly in the code. Could you make a ticket with all the required os_poker_imsg notifications (or references to the specs) ? So I know what I need to do.
17:25:00 proppy: mongolito404: + not ?
17:25:19 proppy: I will add them on 32
17:25:24 proppy: 6.3.8 layouts
17:25:24 proppy: 5.7.3 behaviour
17:25:26 proppy: #32
17:28:49 proppy: mongolito404: do you know how to trigger invitation ?
17:28:58 mongolito404: no
17:29:01 proppy: (sorry if you already answered)
17:30:42 proppy: I'll set the title to 'notification' for now
17:32:13 dachary: proppy: are your changes pushed to drupal-demo ?
17:32:22 proppy: dachary: no
17:32:26 proppy: unless mongolito404 pushed them
17:32:30 dachary: that would explain :-)
17:32:35 mongolito404: proppy: Did you push changeset http://drupal-dev.pokersource.info/trac/ticket/135#comment:2 to drupal-demo ?
17:32:45 mongolito404: too late
17:32:46 dachary: I was trying gifts on drupal-demo but if your changes are not there
17:32:48 proppy: mongolito404: no
17:33:17 proppy: 05:13:52 PM) proppy: mongolito404: is our stuff merged on drupal-demo ?
17:33:17 proppy: (05:14:01 PM) proppy: mongolito404: I tried them on drupal-kez
17:33:18 proppy: (05:14:07 PM) proppy: but I don't merged them on drupal-demo
17:33:18 proppy: (
17:33:18 proppy: that's what I said :)
17:33:22 dachary: when do you want to update drupal-demo with todays work ?
17:33:26 dachary: proppy: mongolito404 ?
17:33:43 dachary: I don't mean to pressure you, I'll try when it's ready :-)
17:33:46 mongolito404: I pushed my chnages to drupal-demo, sorry I though proppy did.
17:33:48 proppy: dachary: I was suggesting we update drupal-demo when all the blocker are gone
17:34:07 dachary: proppy: ok
17:34:24 proppy: mongolito404: sorry, I didn't pushed them on drupal-demo
17:34:31 proppy: I thought we were doing the merge later
17:34:41 mongolito404: I will not be able to fix #136 and #144 today. So all my blockers for today are done (and pushed on drupal-demo)
17:36:39 mongolito404: proppy: Do you push your to drupal-demo or should I do it ?
17:37:00 proppy: mongolito404: I'm still working on #32
17:51:00 proppy: moved to http://drupal-dev.pokersource.info/trac/ticket/32#comment:12
17:51:09 proppy: moved to Drupal http://drupal-dev.pokersource.info/trac/ticket/32#comment:12
17:51:20 proppy: to add support for other invitation, and title
17:53:09 proppy: updated description http://drupal-dev.pokersource.info/trac/ticket/32#comment:13
17:53:10 proppy: mongolito404: ^
17:53:27 proppy: mongolito404: I'm ready to merge on drupal-demo
17:54:22 saqimtiaz quit IRC (Read error: 104 (Connection reset by peer)).
17:55:01 mongolito404: proppy: ok
17:55:10 mongolito404: You should just have to push your changes
18:03:30 proppy: mongolito404: merge stuff
18:03:47 proppy: on pb_jpoker, and drupal
18:03:48 proppy: I had a commit ahead in drupal-kez
18:03:49 proppy: you should pull
18:03:51 mongolito404: Buy for Table works on drupal-demo
18:04:30 proppy: mongolito404: dachary: I have to remove/add the gadget
18:04:34 proppy: because the markup has changed
18:04:38 proppy: mongolito404: all player money will be lost
18:04:43 proppy: and you will have to create new account
18:04:53 proppy: mongolito404: could reset user database on drupal-demo
18:05:02 proppy: after I updated the gadget
18:06:21 proppy: restarting the poker server on drupal-demo
18:06:29 proppy: updated application_id in poker.social.xml
18:06:55 mongolito404: proppy: What do you mean reset the user DB ?
18:07:00 mongolito404: Remove all existing users ?
18:07:06 proppy: mongolito404: yes
18:07:12 emilie quit IRC ("Leaving.").
18:07:14 proppy: mongolito404: because they will lost their money anyway
18:07:19 proppy: because the application_id has changed
18:07:23 mongolito404: I cannot remove the root user
18:07:26 proppy: and that could crash the jpoker gadget
18:07:29 proppy: if they have no money
18:07:45 mongolito404: We can also update the existing rows in the DB (if they have not been removed)
18:08:17 proppy: dachary: are you ok removing all the user of drupal-demo ?
18:08:45 proppy: dachary: ah maybe that's not needed after all
18:08:47 proppy: sorry for the noise
18:08:52 proppy: mongolito404: I just logged root
18:08:57 proppy: and I've got 2000$ in chips
18:09:16 proppy: it seems that os_poker allocate money some how
18:10:21 proppy: join/quit is working
18:10:23 proppy: sound is working
18:10:38 proppy: checking default avatar
18:10:47 guyvdb quit IRC ("Leaving.").
18:11:11 proppy: mongolito404: maybe that's only for root
18:11:18 proppy: becaues I logged player263
18:11:21 proppy: and it has no money
18:11:40 mongolito404: meaning he has 0 chips ?
18:11:49 proppy: mongolito404: default avatar does not work on drupal-demo
18:11:55 proppy: shinding integrator has to be patched
18:12:02 proppy: os_poker display 0 chips
18:12:06 proppy: but I can sit at the table
18:13:25 proppy: mongolito404: can I patch shindigintegrator
18:13:25 proppy: ?
18:13:29 mongolito404: proppy: yes
18:13:36 proppy: with the following patches
18:13:36 proppy: http://drupal.org/node/685182
18:13:40 proppy: could you review it ?
18:13:43 proppy: before I patch ?
18:13:49 proppy: (it comes from the following ticket)
18:13:58 dachary: ok to remove all users
18:14:00 dachary: proppy:
18:14:30 proppy: mongolito404: also we would have to set default_avatar image file, in user picture preferences
18:14:44 proppy: because the patch relies on variables['user_picture_default']
18:15:35 mongolito404: This is a variable set by Drupal ?
18:15:44 mongolito404: I mean from std. Drupal admin UI ?
18:16:27 mongolito404: In your pathc, $result = db_query('SELECT * FROM {variable} WHERE name = "%s"', 'user_picture_default'); should be variable_get('user_picture_default', NULL)
18:17:25 proppy: mongolito404: yes
18:17:32 mongolito404: If {variable} is what I think
18:17:35 proppy: mongolito404: it doesnt work
18:17:50 proppy: because ShindigDbFetcher is called from shindig
18:17:56 proppy: and lives outside drupal
18:18:00 mongolito404: Ha ok
18:18:12 proppy: mongolito404: I tried to include init stuff
18:18:16 proppy: using variable_init
18:18:19 proppy: but it didn't work
18:18:34 proppy: because I was missing some configuration I guess
18:18:51 proppy: and since the ShindigDbFetch is also doing select for profile or user, I thought it was intended
18:19:03 proppy: mongolito404: do you see no harm in appliying that patch in production ?
18:19:13 mongolito404: proppy: no
18:19:17 mongolito404: The patch it fine
18:19:23 mongolito404: s/it/is
18:19:24 proppy: mongolito404: is it ok to set user_picture_default in drupal admin ?
18:20:01 mongolito404: Yes, why not
18:20:12 mongolito404: Should I do it ?
18:21:11 proppy: mongolito404: sure
18:21:22 proppy: mongolito404: I was wondering it is will play well with theming
18:22:05 proppy: patched shindingintegrator
18:22:17 mongolito404: You mean std. Drupal theming of theming of ps_poker and the current themes ?
18:23:33 mongolito404: AFAIK, the current code use and hardcoded defautl picture
18:23:40 mongolito404: so it will needs to be fixed
18:23:40 proppy: I mean would a theme be able to override picture default this way
18:23:41 proppy: ok
18:23:50 mongolito404: But using the variable is the right thing to do
18:23:58 mongolito404: and it has been configured on drupal-demo
18:24:15 mongolito404: proppy: No a theme will ne be able to override it
18:24:24 proppy: mongolito404: sad :/
18:24:25 mongolito404: In Drupal default picture is not part of the theme
18:24:30 proppy: ok
18:24:42 proppy: mongolito404: it's fine if it is the "drupal way"
18:24:51 proppy: mongolito404: did you update picture_default ?
18:24:59 proppy: in admin, or should I do it
18:25:09 mongolito404: Yes, in http://drupal-demo.pokersource.info/drupal6/?q=admin/user/settings
18:26:19 mongolito404: Do i still need to delete all users ?
18:26:38 proppy: mongolito404: got Access denied You are not authorized to access this page.
18:26:46 proppy: on first_profile after creating a new user
18:26:52 mongolito404: Yes you have to be logged as root
18:27:14 proppy: mongolito404: no I mean when using regular signup
18:27:20 proppy: not when trying to browser user/settings
18:27:51 proppy: mongolito404: I tried it again, and it works
18:28:40 proppy: mongolito404: I should run test of shindig integrator package after patching
18:28:51 proppy: otherwise the files doesn't get copied into shindig subdirectory
18:28:51 mongolito404: Yes
18:29:14 mongolito404: which files ?
18:29:41 proppy: mongolito404: this one drupal-demo:/usr/src# hg st ShindigIntegrator
18:29:42 proppy: M ShindigIntegrator/shindig_integrator/shindig/php/src/social/sample/ShindigIntegratorDbFetcher.php
18:29:53 proppy: from ShindigIntegrator/shindig_files
18:29:55 proppy: ran the test
18:29:57 proppy: filed copied
18:31:08 proppy: default picture works
18:31:09 proppy: \o/
18:31:17 mongolito404: proppy: I have to go. Do you need anything from me now ?
18:31:24 mongolito404: (deleting users, etc.) ?
18:31:37 proppy: mongolito404: maybe reset the user database yes
18:31:41 proppy: before you leave
18:31:46 proppy: if it doesn't take too much time
18:32:20 proppy: mongolito404: ho and also test if the page crash with ie8)
18:34:00 mongolito404: users deleted
18:34:22 mongolito404: IE8 still crashes
18:35:39 proppy: really ?
18:35:46 mongolito404 deleting browsing history...
18:35:49 proppy: ok I'll try to debug it from the vm
18:36:01 proppy: yes delete your cash
18:36:09 proppy: mongolito404: it's fine if you've to go
18:36:13 proppy: I've a vm with ie8
18:36:16 proppy: I should be able to test
18:38:06 bkuhn quit IRC ("Back around 17:00 US/Eastern").
18:40:02 mongolito404: Clearing the cache take like foreever in my XP vm :(
18:40:49 proppy: mongolito404: it also crash in my vm
18:41:16 proppy: mongolito404: I was not crashing with a vista + ie8
18:41:28 proppy: mongolito404: we'll see later
18:41:38 proppy: mongolito404: thanks for your hard work today :)
18:41:40 mongolito404: S it's a ie8 xp feature :D
18:41:46 mongolito404: see you monday
18:41:52 proppy: yes
18:42:55 mongolito404 quit IRC ("Leaving.").
18:45:03 proppy: #121 checked
18:45:30 proppy: #111 checked
18:46:24 proppy: #101 checked
18:46:38 proppy: #137 checked
18:47:31 proppy: #135 checked
18:49:12 proppy: cheked that #32 does work by typing window.top.os_poker_process_message({messages: [{type: 'os_poker_imsg', body: {text:'foo'}}]}); in the console
18:58:50 asymptote joined #pokersource.
18:59:03 asymptote: hi I just have a general question about poker
18:59:05 asymptote: anyone around ?
19:01:05 guyvdb joined #pokersource.
19:07:31 asymptote left #pokersource.
19:35:17 proppy: moved challenge ticket to drupal
19:35:17 proppy: http://drupal-dev.pokersource.info/trac/ticket/4#comment:10
19:35:43 proppy: http://drupal-dev.pokersource.info/trac/ticket/4#comment:9
19:38:02 proppy: http://drupal-dev.pokersource.info/trac/ticket/32#comment:15 updated with new image
19:38:08 pokerhai joined #pokersource.
19:46:53 dachary: back
19:47:52 dachary: proppy: can I try drupal-demo or do you advise me not to ?
19:48:14 dachary clears cache
19:48:37 dachary restarts browser
19:49:25 proppy: dachary: sure
19:49:33 proppy: dachary: I'm working on drupal-kez now
19:49:37 dachary: thanks
19:49:49 proppy: dachary: I checked drupal-demo and confirmed that today tickets I worked on are working
19:50:09 dachary: great
19:50:41 dachary: users base was reset ?
19:52:04 dachary: proppy: I just signed up and the table list does not display
19:52:21 dachary trying with firebug enabled
19:52:58 dachary: proppy: does it work for you ?
19:53:33 proppy: dachary: user base was reset
19:53:38 proppy: dachary: please create a new user
19:53:44 proppy: dachary: yes I tried with two new user
19:53:47 proppy: for validating tickets
19:53:55 dachary: proppy: I just signed up and the table list does not display, trying again
19:54:08 proppy: signed up means create a new user ?
19:54:15 dachary: yes
19:54:41 dachary: this time it displays
19:54:43 dachary: :-)
19:55:03 dachary: I hear sounds
19:55:35 dachary: i can activate a gift
19:55:42 dachary running another browser
19:57:19 dachary: the sounds will quickly be irritating
19:57:44 j1b quit IRC ("Ex-Chat").
19:59:00 dachary: but I'm sure it will please the people who decided to have them :-)
20:09:20 proppy: #102 fixed http://drupal-dev.pokersource.info/trac/ticket/102#comment:2
20:13:08 dachary: it seems the first reward (sit at a table) is not working, does this ring a bell proppy or should I file a bug ?
20:15:05 proppy: dachary: it rings no bell, I'm afraid I didn't tested rewards,
20:15:18 proppy: because I thought that part of the code was not impacted
20:16:51 dachary: it's not important for today, I'll post a bug
20:20:09 dachary: http://drupal-dev.pokersource.info/trac/ticket/153
20:40:03 proppy: reopened http://drupal-dev.pokersource.info/trac/ticket/141#comment:9
20:41:14 proppy left #pokersource.
23:16:38 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
23:27:40 bkuhn joined #pokersource.
23:43:59 H|- quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 guyvdb quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 MotherOfCOBOL quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 tarbo2_ quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 bleader quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 julez quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 thy1 quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 Sp4rKy quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 bkuhn quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 thy quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 Nurbs quit IRC (niven.freenode.net irc.freenode.net).
23:43:59 pokerhai quit IRC (niven.freenode.net irc.freenode.net).
23:53:42 poker_log joined #pokersource.
23:53:47 CIA-35 joined #pokersource.

Proceed to Saturday 16 January 2010



Brought to you by your friendly neighborhood Logger Bot.