#pokersource@irc.freenode.net IRC Log for
Thursday 7 January 2010

Back to #pokersource@irc.freenode.net Log Calendar

Back to to Wednesday 6 January 2010

Poker Free Software http://pokersource.info/ with IRC archives http://pokersource.info/irc/pokersource@irc.freenode.net/"

00:18:04 proppy quit IRC (Remote closed the connection).
00:18:22 proppy joined #pokersource.
01:13:34 proppy quit IRC ("Leaving.").
01:18:46 proppy joined #pokersource.
01:55:35 proppy quit IRC (Read error: 113 (No route to host)).
01:58:53 proppy joined #pokersource.
02:00:55 proppy1 joined #pokersource.
02:07:03 proppy1 quit IRC (Read error: 104 (Connection reset by peer)).
02:07:12 proppy2 joined #pokersource.
02:17:00 proppy1 joined #pokersource.
02:18:23 proppy quit IRC (Read error: 113 (No route to host)).
02:30:12 proppy2 quit IRC (Read error: 113 (No route to host)).
02:30:12 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
02:55:28 proppy1 quit IRC ("Leaving.").
04:33:53 macmaN joined #pokersource.
05:04:00 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
07:07:02 macmaN joined #pokersource.
07:10:00 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
08:13:24 saqimtiaz joined #pokersource.
08:40:37 mongolito404 joined #pokersource.
08:43:07 mongolito404: Hi
09:13:02 macmaN joined #pokersource.
09:15:50 proppy joined #pokersource.
09:21:56 proppy quit IRC (Read error: 104 (Connection reset by peer)).
09:22:04 proppy1 joined #pokersource.
09:22:33 proppy1 is now known as proppy.
09:25:05 mongolito404: proppy: For #86, the gift notification should be sent to all players siting at the same table(s) as the receiver ?
09:25:21 proppy: mongolito404: yes
09:25:31 proppy: mongolito404: including the receiver
09:25:33 proppy: and the buyer
09:25:50 proppy: to that everybody see the gift animation
09:25:53 mongolito404: Ok
09:26:17 proppy: dachary: I have a thought tonight, that we may use a chat message what do you think ?
09:26:32 proppy: "too hacky" ?
09:26:58 mongolito404: The system used for 'live' message can be used for this.
09:28:16 proppy: mongolito404: ok
09:28:41 proppy: mongolito404: I made progress yesterday on the client side implementation
09:29:18 proppy: http://drupal-kez.pokersource.info/planc/skin/table.html#poker_01_gift
09:30:17 proppy: mongolito404: also something related to this is that app data should be updated
09:30:24 proppy: when a player receive a gift
09:30:46 proppy: for it to be displayed when a user join a table
09:31:18 proppy: dachary: mongolito404: maybe instead of waiting for a message, jpoker could poll the appdata ?
09:31:25 proppy: (for a change)
09:31:30 proppy: what do you think ?
09:31:33 dachary: proppy: could we go over the http://drupal-dev.pokersource.info/trac/report/1 poker tickets together ?
09:31:52 dachary reading the backlog
09:32:20 proppy: dachary: ok, but I thought you wanted to discuss #86 with mongolito404 first
09:32:33 dachary: proppy: good thinking
09:33:16 dachary: because the poker server is ignorant of gifts, I think using the "message / chat" of the poker server is indeed not the best approach
09:33:17 proppy: http://drupal-dev.pokersource.info/trac/query?component=Poker&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=milestone&order=priority
09:33:41 proppy: to list only "poker" related ticket
09:33:48 dachary: mongolito404: did you see the cmirey suggestion at http://drupal-dev.pokersource.info/trac/ticket/86
09:34:06 proppy: dachary: what do you think about the appdata polling ?
09:34:39 dachary: ah
09:34:47 mongolito404: dachary: Yes I saw the suggestion
09:35:58 dachary: that would be bloated (in term of infrastructure) with the two long poll currently in place ( drupal js long poll + poker long poll ) because it is fully redundant with the drupal js long poll, don't you think ?
09:36:18 proppy: dachary: yes but it is also simpler from an implementation pov
09:36:53 proppy: but I agree, that's far from optimal
09:36:56 dachary: I don't see how it is simpler, please explain
09:37:52 proppy: dachary: no code is need on the drupal side
09:38:14 dachary: but code is need on the poker server side
09:38:16 proppy: dachary: apart from settings application data when a a player is buying a gift
09:38:27 proppy: which should be already done,
09:38:29 dachary: oh
09:38:31 proppy: no
09:38:34 proppy: no code either
09:38:43 dachary: you're suggesting a pure JS poll using the opensocial API
09:38:53 proppy: yes
09:38:54 dachary: not a long poll
09:38:59 proppy: not at all
09:39:05 proppy: a 3s poll on appdata
09:39:11 proppy: and see if key "gift" has changed
09:39:14 dachary: this is a killer
09:39:16 proppy: ok
09:39:25 dachary: never ever non long poll
09:39:39 dachary: the infrastrcture impact is much too high
09:40:04 dachary: switching from regular poll to long poll is not an easy undertaking
09:41:04 dachary: and we're not going to introduce a 3s poll after all the work done to implement the two long poll communication channels ( drupal / poll )
09:41:17 dachary: proppy: do you see my point of view or do you think I'm mistaken ?
09:41:38 dachary: http://drupal-dev.pokersource.info/trac/query?status=accepted&status=assigned&status=new&status=reopened&component=Poker&order=priority&col=id&col=summary&col=owner&col=type&col=status&col=priority&col=milestone poker tickets except closed ones
09:42:16 proppy: current os_poker drupal long poll implementation is not optimal either
09:42:24 proppy: it is not even long poll
09:42:32 proppy: dachary: I have a last suggestion
09:42:36 mongolito404: I think this is all what need on the drupal side to sent the information in JS: http://pastebin.com/d6989556c. The evnt is sent like the instant message for in http://drupal-dev.pokersource.info/trac/ticket/32
09:43:10 proppy: when you looked at opensocial api for notification, did you look into the activity stream ?
09:43:26 proppy: like described on opensocial api gift tutorial http://code.google.com/apis/opensocial/articles/tutorial/tutorial-0.8.html#received
09:43:39 proppy: is there a way to register a callback on activity changes
09:43:39 proppy: ?
09:44:16 proppy: mongolito404: nice to know that this is easy to implement in os_poker :)
09:45:07 dachary: mongolito404: from what I can see this is a sensible approach
09:46:24 mongolito404: The JS isn't hard neither... just use add a binding from the iframe
09:47:42 dachary trying http://drupal-dev.pokersource.info/trac/ticket/6
09:47:50 proppy: mongolito404: yes just need to bing poker.gift_animation function on the corresponding jquery event
09:48:13 proppy: dachary: could you answer my question ? this is the last suggestion I have regarding gift notification
09:48:30 mongolito404: Something window.top.os_poker_bind_message('os_poker_gift', NULL, function(event, arg){ ... process the data in arg...})
09:48:32 dachary: I'm still having a big JS error when I try to join the table on drupal-kez
09:48:37 dachary: despite the upgrade
09:49:32 dachary: but
09:49:38 dachary: I can see the short status !
09:49:45 proppy: define "big JS error" please
09:49:45 dachary: I can see the small profile
09:50:01 dachary: (the same screenshot I sent you monday)
09:50:05 proppy: dachary: you could also test from the skin test cases
09:50:22 proppy: dachary: FYI, I don't have any JS error when joining
09:50:31 proppy: could you test on another browser
09:50:42 proppy: do confirm that is not related to your setup
09:50:43 dachary: proppy: the small profile does not cover the dealer area to the bottom
09:50:50 dachary: is is as shown in the mockups ?
09:51:35 proppy: dachary: that's a theming issue
09:51:39 proppy: I agree
09:52:05 proppy: that's because the previous implementation was not covering the dealer area title
09:52:11 dachary: http://dachary.org/specs/9-Elements/mouseover_profil.jpg
09:52:16 proppy: height should be updated in the css
09:52:24 proppy: in poker_small_profile.css that is
09:53:43 proppy: dachary:
09:53:49 proppy: please ask for an update of images/bg_overlaybox.gif
09:53:59 dachary: http://drupal-dev.pokersource.info/trac/ticket/6 I updated the ticket with a reference to the mockup
09:54:02 proppy: to match the mockup side
09:54:08 proppy: size
09:54:14 dachary: 6.3.7 shows how it should look like
09:54:24 dachary: the title bar is missing
09:54:25 proppy: http://drupal-kez.pokersource.info/planc/css/images/bg_overlaybox.gif
09:54:56 dachary: and the close button is missing too
09:55:15 proppy: dachary: I don't see any new comment on http://drupal-kez.pokersource.info/planc/css/images/bg_overlaybox.gif
09:55:44 proppy: dachary: ah I see, title bar should be implemented
09:55:47 dachary: check 6.3.7 in the specs
09:55:51 proppy: this way no change of the image is needed
09:56:00 dachary: http://drupal-dev.pokersource.info/trac/ticket/6?action=diff&version=12
09:57:57 proppy: dachary: since you are reviewing this ticket could you comment on the remaining issue I added
09:57:58 proppy: http://drupal-dev.pokersource.info/trac/ticket/6#comment:10
10:00:46 dachary: could you make sure the remaining issues are visible in the description of a ticket ? it's a lot easier to check the description when thinking "what's next on this ticket" rather than checking the logs backward to make sure there is not a pending issue expressed in them
10:00:46 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
10:01:50 proppy: dachary: sure I will update the description from now on
10:01:54 dachary: http://drupal-dev.pokersource.info/trac/ticket/6 answered
10:02:04 dachary: use the default blue avatar image when the avatar has no image
10:05:48 dachary quit IRC (Read error: 104 (Connection reset by peer)).
10:05:55 mongolito404: dachary, proppy: I would like to test the gift event for #86. The gift giving workflow is tested in os_poker_spec_5.5.test but it doesn't seems to contains test for the instant message notification. Do you now if there is any tests for the messages/long poll ?
10:06:09 dachary joined #pokersource.
10:08:10 proppy: -*- mode: grep; default-directory: "/etc/drupal/6/sites/all/modules/os_poker/tests/" -*-
10:08:10 proppy: Grep started at Thu Jan 7 10:07:37
10:08:11 proppy: grep -nH -e Message
10:08:11 proppy: Grep finished with no matches found at Thu Jan 7 10:07:37
10:08:22 proppy: I don't see any tests
10:08:52 proppy: ah that's because grep doesn't follow symbolink link
10:09:42 proppy: dachary: I see
10:09:42 proppy: ./os_poker_spec_5.7.test: * Verify Message on Gift
10:09:43 proppy: ./os_poker_spec_5.7.test: function testMessageOnGift(){
10:09:46 proppy: oups
10:09:47 proppy: mongolito404: ^
10:10:18 proppy: but I'm not sure this is testing the Instant messages
10:12:05 proppy: it seems that challenge and invitation uses instant message
10:14:31 proppy: mongolito404: is it helping ?
10:16:15 proppy: just seen http://drupal-dev.pokersource.info/trac/ticket/32#comment:5
10:16:41 proppy: mongolito404: can I update #86 with http://pastebin.com/d6989556c ?
10:17:35 guyvdb quit IRC (Read error: 60 (Operation timed out)).
10:17:51 mongolito404: proppy: I'll push it with mercurial on drupal-404
10:18:07 proppy: mongolito404: ok http://drupal-dev.pokersource.info/trac/ticket/86#comment:4
10:18:32 mongolito404: I'll ensure the chnageset only contains this chaneg so it should be possible for you to get the only this change from drupal-404 to drupal-kev
10:19:20 mongolito404: The various test in the 5.7 test file always check the messagebox for messages. So these are not "instant message" tests
10:24:26 dachary quit IRC (Read error: 110 (Connection timed out)).
10:24:47 mongolito404: proppy: http://drupal-dev.pokersource.info/trac/ticket/86#comment:5
10:25:12 proppy: mongolito404: thanks
10:25:21 thy quit IRC ("Leaving.").
10:26:33 proppy: mongolito404: is it safe to pull other changeset too ?
10:26:38 proppy: #97 + ?
10:26:54 mongolito404: It should be safe
10:27:18 proppy: added 18 changesets with 28 changes to 15 files
10:27:24 proppy: mongolito404:
10:27:24 proppy: 14 files updated, 0 files merged, 0 files removed, 0 files unresolved
10:27:26 proppy: thanks :)
10:34:08 thy joined #pokersource.
10:35:16 mongolito404: proppy: Is anything more needed for #86 ? Should the Drupal's JS forward the event to the iframe ?
10:41:06 guyvdb joined #pokersource.
10:49:24 proppy: mongolito404: I don't think so, I'll check if I'm able to register on parent jquery event as you advised
10:49:44 mongolito404: ok
10:51:26 proppy: mongolito404: window.top.jQuery("#message_container").bind("os_poker_imsg"_pok1", function(event, arg){...})
10:51:27 proppy: that is
10:52:24 proppy: mongolito404: is parent.jQuery also working ?
10:53:29 proppy: they seems to bind message on document, not container
10:53:35 proppy: $(document).trigger(msg[i].type, msg[i].body);
10:54:21 guyvdb quit IRC ("Leaving.").
10:54:31 mongolito404: Yes. I think the doc on #32 is wrong because the messagebox menu entry is updated with messages from the long poll
10:55:00 mongolito404: It should work if you use something like window.top.os_poker_bind_message('os_poker_gift', NULL, function(event, arg){ ... process the data in arg...})
10:55:36 proppy: trying
10:56:49 proppy: window.top.os_poker_bind_message('os_poker_gift', NULL, function(event, arg){
10:56:49 proppy: console.log("os_poker_gift", event, arg);
10:56:49 proppy: });
10:59:56 j1b joined #pokersource.
11:01:25 mongolito404: proppy: Does it work ?
11:02:13 proppy: I have $ 0 Chip
11:02:18 proppy: so it is difficult to buy gift
11:02:26 proppy: I'm trying to buy a gift to my self thought
11:02:34 proppy: I don't know if it is supposed to work
11:02:40 mongolito404: Can can send the event in JS yourself
11:03:21 proppy: mongolito404: ah I thought you wanted me to try to notification bits you've just written
11:03:38 mongolito404: proppy: Yes, that one too
11:03:41 proppy: mongolito404: you're right I will test first that registering window.top.os_poker_bind_message works
11:04:37 mongolito404: with firebug, os_poker_process_message([{type: 'os_poker_gift', body: {...}}])
11:06:12 proppy: mongolito404: it works
11:06:13 proppy: >>> os_poker_trigger('os_poker_gift', 'name', 'args');os_poker_gift Object type=os_poker_gift timeStamp=1262858698109 name
11:06:57 proppy: os_poker_process_message([{type: 'os_poker_gift', body: {a:1, b:2}}]); TypeError: msg is undefined
11:07:02 proppy: checking process_message
11:07:20 proppy: ah it should be in an object
11:07:31 proppy: os_poker_process_message({messages: [{type: 'os_poker_gift', body: {a:1, b:2}}]});
11:07:54 proppy: os_poker_process_message({messages: [{type: 'os_poker_gift', body: {a:1, b:2}}]});os_poker_gift Object type=os_poker_gift timeStamp=1262858842174 Object a=1 b=2
11:07:59 proppy: mongolito404: it works
11:08:58 proppy: mongolito404: I'm not sure I understand how to buy a gift "from the shop" thought
11:09:06 proppy: so more manual testing may be needed
11:15:09 mongolito404: In the shop, click on an item and then click on "Buy for buddies"
11:15:36 mongolito404: If you are sitting on a table with your buddies, you should receive the message
11:15:56 proppy: ah ok I was clicking buy
11:16:34 proppy: I guess that at least one of my buddy should be sitted at the same table
11:16:54 proppy: buy for buddies doesn't include myself
11:16:58 proppy: I guess
11:17:45 mongolito404: Yes for buddies should not include you
11:18:03 proppy: mongolito404: FYI parent also work instead of window.top
11:19:11 mongolito404: if you are one (i)frame, window.parent == window.top
11:19:23 mongolito404: window.top is always the top most frame
11:21:13 guyvdb joined #pokersource.
11:21:54 mongolito404: I believe it is safer to use window.top
11:22:09 proppy: mongolito404: ok, I'will replace parent with window.top
11:31:38 proppy: I should setup a testenv for integration between the jpoker iframe
11:31:43 proppy: and os_poker.message.js
11:42:27 saqimtiaz: seen mornifle
11:46:00 proppy: mongolito404: here is a test env for pokersocial integration
11:46:00 proppy: http://drupal-kez.pokersource.info/planc/test-poker-opensocial.html
11:46:20 proppy: it creates an iframe and include os_poker_messages on the top document
11:48:19 mongolito404: Why do you wrap the test case in an iframe ?
11:48:52 proppy: mongolito404: because I want to access os_poker_* function from the top document
11:48:59 proppy: mongolito404: does it makes senses ?
11:49:08 mongolito404: Yes but it is not needed
11:49:08 proppy: I want to be in the sames conditions that when included from drupal
11:49:23 mongolito404: You want to test your code, not os_poker.message.js
11:49:42 mongolito404: In the test module, you can create mockup functions for os_poker_*
11:50:00 proppy: mongolito404: yes but I can't create them in the parent document
11:50:03 proppy: since there is no parent
11:50:23 proppy: http://drupal-dev.pokersource.info/trac/ticket/86#comment:6
11:50:37 mongolito404: if the frame is the top most parent, window == window.parent == window.top
11:50:47 proppy: mongolito404: I just wanted to write some code for the manual test we've done together
11:51:10 proppy: but I agree this overload with existing os_poker.messages.js
11:53:04 proppy: mongolito404: I guess that instead of defining a new callback, poker.opensocial.js could just forward the message to the iframe
11:53:47 proppy: or I'll call poker.gift_animation from pokersocial, I guess that's fine
11:53:49 mongolito404: I'm not sure I understand
12:00:02 proppy: mongolito404: currently there are 2 layers on top of jpoker
12:00:26 proppy: poker.js which define some jpoker customisation specific to z2
12:00:29 proppy: and
12:00:41 proppy: poker.opensocial.js which take care of integration with the social network
12:00:56 proppy: poker.opensocial.js register the callback on window.top
12:01:01 proppy: and will forward it to poker.js
12:01:12 proppy: gift animation is already implemented in poker.js
12:01:18 proppy: mongolito404: these are implementation details thought
12:01:25 proppy: mongolito404: but I thought you might be interested
12:01:26 mongolito404: ok, I understand
12:04:50 macmaN joined #pokersource.
12:07:12 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
12:07:47 proppy: mongolito404: updated the gift_animation implementation to match the event callback calling convention
12:07:47 proppy: http://drupal-dev.pokersource.info/trac/ticket/9#comment:13
12:07:56 proppy: next step is to branch it :)
12:08:52 mongolito404: branch ?
12:11:16 proppy: http://drupal-dev.pokersource.info/trac/ticket/86#comment:8
12:11:21 proppy: mongolito404: to plug it
12:12:29 proppy: mongolito404: lunch time
12:12:42 mongolito404: me too
12:12:46 proppy: mongolito404: I will test it for real, ( I mean manually ) after lunch
12:13:00 proppy: mongolito404: thanks a lot for your help
12:31:23 proppy quit IRC ("Leaving.").
13:07:26 macmaN joined #pokersource.
13:26:44 proppy joined #pokersource.
13:42:41 mongolito404: proppy: Do you know if tests for 5.5 are supposed to work ?
13:56:46 proppy: mongolito404: hi
13:56:48 proppy: mongolito404: i guess yes
13:57:03 proppy: I'm not aware they shouldn't work
14:00:21 mornifle quit IRC (Read error: 60 (Operation timed out)).
14:12:20 dachary joined #pokersource.
14:12:57 proppy: mongolito404: which test is failing ?
14:13:11 dachary: hopla
14:15:33 mongolito404 wanted to test his work for #86... Now he suffers in os_poker_spec_5.5.test
14:33:42 mongolito404: dachary: I'm trying to make my test for #83 work in os_poker_spec_5.5.test. Currently they don't pass. Probably because in the test CUser::Tables return an empty array.
14:34:35 mongolito404: I think the array is empty because the db query to find a player's table is a JOINT between `pokertables` and `user2table`.
14:35:20 mongolito404: While pokertables table is not filled by the test class (the test use its own poker database).
14:36:19 mongolito404: Where can I find sample data for this table ?
14:41:12 mornifle joined #pokersource.
14:46:22 proppy: mongolito404: ping
14:46:40 proppy: I think there are api call to fill this table
14:46:42 proppy: wait
14:47:14 mongolito404: Yep, in test 5.7
14:47:39 proppy: mongolito404: did you try
14:47:40 proppy: function joinPokerTable($user, $game_id) {
14:47:40 proppy: $previous_db = db_set_active($this->createPokerDatabase());
14:47:40 proppy: $sql = "INSERT INTO user2table VALUES (%d, %d, 0, 0)";
14:47:40 proppy: db_query($sql, $user->uid, $game_id);
14:47:40 proppy: db_set_active($previous_db);
14:47:41 proppy: }
14:47:42 proppy: ?
14:47:45 proppy: in 5.5
14:48:28 mongolito404: I changed it to http://pastebin.com/d2261be12
14:49:13 mongolito404: The last assertion passes, so CPoker::UsersAtTable($game_id) works. The assertion to test the result of CUserManager::instance()->User($user->uid)->Tables() fails.
14:49:35 proppy: mongolito404: why do you need static $tables
14:49:45 dachary quit IRC (Read error: 104 (Connection reset by peer)).
14:50:04 proppy: IIRC setUp is called between each test
14:50:07 mongolito404: BEcause I'm working on some code to create the table... but I will use the code in 5.7 to create the table
14:50:11 dachary joined #pokersource.
14:50:21 proppy: mongolito404: ah ok
14:50:38 proppy: mongolito404: did you took a look to pokertables
14:50:44 proppy: in pythonpokernetwork database
14:50:47 mongolito404: I'll move joinPokerTable, createPokerDatabase and createPokerTable from 5.7 and 5.5 to OsPokerWebTestCase
14:50:54 proppy: I believe there are many sample data here
14:51:02 dachary: mongolito404: sorry, not available to talk
14:51:13 mongolito404: proppy: The tests use pythonpokernetworktest
14:52:20 proppy: mongolito404: yes but the test create pythonpokernetworktest
14:52:20 proppy: using
14:52:21 proppy: function createPokerDatabase() {
14:52:21 proppy: static $POKER_DB;
14:52:21 proppy: if(!isset($POKER_DB)) {
14:52:22 proppy: $POKER_DB = "pythonpokernetworktest";
14:52:22 proppy: require_once(drupal_get_path('module', 'os_poker') . "/poker.class.php");
14:52:25 proppy: shell_exec("mysqladmin -f -u root drop $POKER_DB");
14:52:26 proppy: shell_exec("mysqladmin -u root create $POKER_DB");
14:52:29 proppy: shell_exec("mysql -u root $POKER_DB < /usr/share/poker-network/schema.sql");
14:52:31 proppy: global $db_url;
14:52:32 proppy: if (is_string($db_url)) { $db_url = array('default' => $db_url); } // Thanks Bdragon
14:52:35 proppy: $db_url[$POKER_DB] = "mysql://root@localhost/$POKER_DB";
14:52:38 proppy: }
14:52:40 proppy: return $POKER_DB;
14:52:42 proppy: }
14:53:00 proppy: mongolito404: does it helps ?
14:55:01 proppy: mongolito404: interesting
14:55:03 proppy: Chips: $ -4
14:55:10 proppy: I've negative chips on http://drupal-kez.pokersource.info/drupal6/
14:57:18 proppy: filled http://drupal-dev.pokersource.info/trac/ticket/90
14:57:23 proppy: with http://drupal-dev.pokersource.info/trac/attachment/ticket/90/negative_chips.png
15:03:24 dachary quit IRC ("Leaving.").
15:07:09 proppy: mongolito404: I confirm that the event is fired in the iframe
15:07:12 proppy: when buying a gift
15:07:15 proppy: mongolito404: good work :)
15:07:50 mongolito404: :D
15:36:48 proppy: mongolito404: gift animation works ;)
15:36:55 proppy: you can try it on http://drupal-kez.pokersource.info/drupal6/
15:40:04 mongolito404: The moving div is just a yellow square ?
15:42:54 proppy: updated http://drupal-dev.pokersource.info/trac/ticket/9
15:42:58 proppy: with an howto
15:43:07 proppy: mongolito404: yes, this is the default skinning
15:43:17 proppy: mongolito404: there is a css class with the name of the item
15:43:30 proppy: so using css we should be able to attribute image to gifts
15:44:00 mongolito404: Do you clean the gift name to make it a css class name ?
15:45:24 proppy: mongolito404: ah no, I guess I should
15:45:51 proppy: I was assuming the string you send to me was a valid css classes
15:45:53 mongolito404: Yes, because "Bowl of rice" is a not a vlid class name
15:46:08 mongolito404: I can clean the gift name on the server side
15:46:18 proppy: but I since I never stated this on #86
15:46:22 proppy: that was a false assumption
15:46:30 proppy: mongolito404: what would make more sense ?
15:46:40 mongolito404: I assumed it was done on the JS side since you asked for a string...
15:47:26 mongolito404: Both are acceptable, but having the full name on the JS means that you can also display it to the user (if needed)
15:48:11 proppy: mongolito404: yes you're right
15:48:20 proppy: I think doing the cleaning part on js would be nice
15:48:38 proppy: mongolito404: could you add this as a remaining issue of #9 in the description, and reopen the ticket
15:48:51 mongolito404: For instance, you can assign the gift name as "title" of the element so hovering on it display its name
15:48:52 proppy: I can make it if you have no time
15:49:12 proppy: mongolito404: I should also do research on "how to clean a css class name"
15:50:07 mongolito404: I've some PHP to do it somewhere...
15:50:57 mongolito404: http://api.drupal.org/api/function/drupal_clean_css_identifier/7
15:51:30 mongolito404: I'll do it server side
15:53:06 proppy: maybe there is some jquery plugin do do this
15:53:14 proppy: mongolito404: maybe you could use an additional field
15:53:31 proppy: like gift_id
15:53:37 proppy: or gift_class
15:53:44 proppy: which would be an unique string
15:53:46 proppy: describing the gift
15:53:51 proppy: mongolito404: suitable for a css class
15:53:54 proppy: what do you think ?
15:53:57 mongolito404: cls
15:54:09 proppy: since way we also have the name
15:54:11 proppy: on the js class
15:54:21 proppy: in the gift field
15:54:28 proppy: and a unique string suitable for a css class
15:54:32 proppy: in the cls field
15:56:14 proppy: mongolito404: updated http://drupal-dev.pokersource.info/trac/ticket/86?action=diff&version=9 description
16:06:27 proppy: mongolito404: do you know the url of the default avatar image ?
16:08:40 mongolito404: proppy: No
16:09:25 mongolito404: http://drupal-dev.pokersource.info/trac/ticket/86#comment:10
16:10:09 proppy: found sites/default/files/pictures/picture-default.png
16:10:47 proppy: http://drupal-kez.pokersource.info/drupal6/sites/default/files/pictures/picture-default.png
16:18:42 mongolito404: proppy: Would it be safe for me to merge what's on drupal-kez to drupal-404 ?
16:18:52 proppy: mongolito404: I bet there is no changes
16:18:56 proppy: on the drupal side
16:20:21 proppy: drupal-kez:/etc/drupal/6/sites/all# hg outgoing ssh://root@drupal-404.pokersource.vm.gnt//etc/drupal/6/sites/all/
16:20:21 proppy: comparing with ssh://root@drupal-404.pokersource.vm.gnt//etc/drupal/6/sites/all/
16:20:22 proppy: searching for changes
16:20:22 proppy: no changes found
16:31:51 mongolito404: ok
16:40:51 proppy: updated http://drupal-dev.pokersource.info/trac/ticket/6#comment:15
17:00:21 proppy: mongolito404: updating drupal-kez from drupal-404
17:00:26 proppy: with your changes
17:01:52 proppy: mongolito404: what is jquery_update ?
17:01:55 proppy: should I pull it ?
17:02:21 proppy: found http://drupal.org/project/jquery_update
17:03:07 mongolito404: Latest Drupal 6.x ships jQuery 1.2.6. jquery_update is a module to update it to use more recent version. The version I installed use 1.3.5
17:03:44 mongolito404: See http://drupal-dev.pokersource.info/trac/ticket/85#comment:3
17:04:35 mongolito404: dachary don't know why the jquery file from Drupal was updated to 1.3.6 but without jquery_update it breaks the teaser.js provided by Drupal.
17:09:36 bkuhn joined #pokersource.
17:10:25 proppy: mongolito404: poker_player_item poker_gift_Water
17:10:27 proppy: it works :)
17:10:45 proppy: mongolito404: thanks
17:11:24 mongolito404: proppy: For what ?
17:11:45 bkuhn: seen dachary?
17:12:08 proppy: mongolito404: http://drupal-dev.pokersource.info/trac/ticket/86#comment:11
17:12:17 proppy: clean of css class
17:12:31 proppy: mongolito404: do you want to play a hand on drupal-kez to proof test the gift system ?
17:13:58 proppy: mongolito404: I think you could close http://drupal-dev.pokersource.info/trac/ticket/86#comment:11
17:14:56 mongolito404: proppy: I don't know howto play poker :)
17:15:04 proppy: mongolito404: ahaha :)
17:15:27 proppy: just follow the instruction on http://drupal-dev.pokersource.info/trac/ticket/9
17:15:35 proppy: you could be browser A
17:15:40 proppy: and I'm browser B
17:16:35 mongolito404: proppy: ok
17:17:01 mongolito404: What account can I use ? My user has 0 chip
17:17:08 proppy: mongolito404: please accept my buddy invite
17:17:17 mongolito404: (weird, because I should get some at login)
17:17:48 proppy: mongolito404: I can use root account
17:17:52 proppy: to offer gift
17:18:06 proppy: mongolito404: could you accept friend invite
17:18:25 proppy: from root and proppy
17:18:47 mongolito404: Done
17:19:45 proppy: mongolito404: did you see something ?
17:19:52 mongolito404: No
17:20:35 mongolito404: Now I saw the two moving yellow square
17:20:43 mongolito404: and again
17:20:44 proppy: ok
17:20:52 proppy: and when you hover the pink square
17:20:55 proppy: which title do you get ?
17:21:09 mongolito404: Coffee
17:21:15 proppy: now Beer !
17:21:16 mongolito404: And now beer
17:21:16 proppy: :)
17:21:19 proppy: \o/
17:21:20 mongolito404: w00t
17:21:33 mongolito404: Mmmm beer
17:23:34 proppy: :)
17:24:35 proppy: mongolito404: do you see anything else missing regarding gift implemention
17:24:38 proppy: mongolito404: do you have comment ?
17:24:48 mongolito404: No
17:38:43 mongolito404: proppy: I guess we can close 86
17:40:06 proppy: mongolito404: congrats :)
18:07:01 j1b quit IRC ("Ex-Chat").
18:10:20 mornifle quit IRC (Read error: 113 (No route to host)).
18:14:37 proppy: updated http://drupal-dev.pokersource.info/trac/ticket/6#comment:18
18:19:15 mongolito404 quit IRC (Read error: 110 (Connection timed out)).
18:25:26 mongolito404 joined #pokersource.
18:26:45 saqimtiaz quit IRC ("Leaving.").
18:37:03 proppy quit IRC ("Leaving.").
18:50:23 mornifle joined #pokersource.
18:50:39 mornifle quit IRC (Remote closed the connection).
19:37:05 dachary joined #pokersource.
19:43:31 mongolito4041 joined #pokersource.
19:56:46 mongolito404 quit IRC (Read error: 110 (Connection timed out)).
20:44:07 guyvdb quit IRC ("Leaving.").
20:55:30 dachary quit IRC (Read error: 110 (Connection timed out)).
21:39:05 guyvdb joined #pokersource.
21:55:34 bruno98 quit IRC ("Leaving.").
22:17:55 mongolito4041 quit IRC ("Leaving.").
22:30:19 saqimtiaz joined #pokersource.
23:26:31 elninja joined #pokersource.
23:40:34 saqimtiaz quit IRC ("Leaving.").
23:51:37 macmaN quit IRC (Read error: 104 (Connection reset by peer)).
23:54:38 saqimtiaz joined #pokersource.
23:55:19 saqimtiaz quit IRC (Client Quit).

Proceed to Friday 8 January 2010

Brought to you by your friendly neighborhood Logger Bot.